[JBoss JIRA] (WFCORE-4837) (7.3.z) [WFCORE-4596] Write lock is acquired reading patching resource using include-runtime
by Bartosz Spyrko (Jira)
Bartosz Spyrko created WFCORE-4837:
--------------------------------------
Summary: (7.3.z) [WFCORE-4596] Write lock is acquired reading patching resource using include-runtime
Key: WFCORE-4837
URL: https://issues.redhat.com/browse/WFCORE-4837
Project: WildFly Core
Issue Type: Bug
Components: Patching
Reporter: Bartosz Spyrko
Assignee: Yeray Borges
Fix For: 11.0.0.Beta3
This is initially created as a bug but it needs first some investigation to discover if it is really necessary to acquire the write lock when the patching resource is read. If it is unnecessary, we should remove this need.
The following operation is acquiring the write lock:
{noformat}
/host=slave/core-service=patching:read-resource(include-runtime=true)
{noformat}
It potentially will block if there is any other operation that has already acquired the lock. One consequence found due to this issue was HAL could block and hang if an HC is starting and the user clicks on 'Patching' menu entry. It was fixed in HAL, where an HC being restarted is no longer shown in the Patching menu.
The main problem seems to be in PatchStreamResourceOperationStepHandler, which is the parent handler used for the handlers that manage patching operations. This parent handler is always acquiring the write lock.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (WFCORE-4836) (7.3.z) Validate composite operation steps just before executing them
by Bartosz Spyrko (Jira)
Bartosz Spyrko created WFCORE-4836:
--------------------------------------
Summary: (7.3.z) Validate composite operation steps just before executing them
Key: WFCORE-4836
URL: https://issues.redhat.com/browse/WFCORE-4836
Project: WildFly Core
Issue Type: Enhancement
Components: Management
Reporter: Bartosz Spyrko
Assignee: Yeray Borges
Fix For: 9.0.0.Beta7, 9.0.0.Final
Say we have a composite operation with 2 steps:
1) /extension=org.jboss.as.messaging:add
2) /subsystem=messaging:add
This will fail:
Failed to execute batch: JBAS014739: No handler for add at address
[("subsystem" => "messaging")]
This fails because at the time of validation the /subsystem=messaging:add is not valid.
To illustrate, the execution order is
Validate 1-2
1
2
A possible solution is to convert this to the following:
V1
1
V2 (works now because 1 has registered the subsystem API)
2
I think that should work but it's a very complex area, particularly in a managed domain, so it's not at all certain this would prove feasible.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5017) DMN Validation does not provide a proper descriptive error message
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5017?page=com.atlassian.jira.plug... ]
Matteo Mortari commented on DROOLS-5017:
----------------------------------------
> the error messages suggests KIE's DMN validation barfed
I beg to differ, looks to me more a kie compilation attempted before the VALIDATE_MODEL have a chance of being executed.
> DMN Validation does not provide a proper descriptive error message
> ------------------------------------------------------------------
>
> Key: DROOLS-5017
> URL: https://issues.redhat.com/browse/DROOLS-5017
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.32.0.Final
> Reporter: Duncan Doyle
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot 2020-02-06 at 11.25.18.png, vacation-days.dmn
>
>
> The attached DMN file is invalid as it contains a trailing space in one of its decision nodes (Base Vacation Days). I've checked with [~tari_manga], and according to him, the backend DMN validator is capable of detecting the problem and giving a proper error message. However the DMN editor in the workbench does not give any user friendly hint what the problem is, and hence it's almost impossible for a user to figure out what's wrong.
> I've attached both the DMN model and a screenshot of the error message displayed by our editor.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5017) DMN Validation does not provide a proper descriptive error message
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5017?page=com.atlassian.jira.plug... ]
Michael Anstis commented on DROOLS-5017:
----------------------------------------
Well.. the error messages suggests KIE's DMN validation barfed when trying to validate the model...
I will however investigate and report back soon.
> DMN Validation does not provide a proper descriptive error message
> ------------------------------------------------------------------
>
> Key: DROOLS-5017
> URL: https://issues.redhat.com/browse/DROOLS-5017
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.32.0.Final
> Reporter: Duncan Doyle
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot 2020-02-06 at 11.25.18.png, vacation-days.dmn
>
>
> The attached DMN file is invalid as it contains a trailing space in one of its decision nodes (Base Vacation Days). I've checked with [~tari_manga], and according to him, the backend DMN validator is capable of detecting the problem and giving a proper error message. However the DMN editor in the workbench does not give any user friendly hint what the problem is, and hence it's almost impossible for a user to figure out what's wrong.
> I've attached both the DMN model and a screenshot of the error message displayed by our editor.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5017) DMN Validation does not provide a proper descriptive error message
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5017?page=com.atlassian.jira.plug... ]
Matteo Mortari commented on DROOLS-5017:
----------------------------------------
The validator reports the following messages:
{code:java}
Message [id=0, level=WARNING, path=null, line=108, column=-1
text=DMN: Variable name contains leading or traling spaces 'Base Vacation Days ' on node 'Base Vacation Days ' (DMN id: _34B27FCC-31C7-419B-85D4-63F8E6B8DD71, The listed name is not a valid FEEL identifier) ]
Message [id=0, level=WARNING, path=null, line=137, column=-1
text=DMN: Decision table with single output on node 'Extra days case 1' should not have an output type reference (DMN id: _0CD749C5-FABA-4A0C-9AAF-C44AC9D19CE2, The referenced element should not have a typeref set) ]
Message [id=0, level=WARNING, path=null, line=77, column=-1
text=DMN: Decision table with single output on node 'Extra days case 3' should not have an output type reference (DMN id: _F385BCF6-3C6E-464A-B5D8-8B74F0985421, The referenced element should not have a typeref set) ]
Message [id=0, level=WARNING, path=null, line=24, column=-1
text=DMN: Decision table with single output on node 'Extra days case 2' should not have an output type reference (DMN id: _5F5AF524-E9FF-4DC4-8609-18093C4D1C47, The referenced element should not have a typeref set) ]
{code}
> DMN Validation does not provide a proper descriptive error message
> ------------------------------------------------------------------
>
> Key: DROOLS-5017
> URL: https://issues.redhat.com/browse/DROOLS-5017
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.32.0.Final
> Reporter: Duncan Doyle
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot 2020-02-06 at 11.25.18.png, vacation-days.dmn
>
>
> The attached DMN file is invalid as it contains a trailing space in one of its decision nodes (Base Vacation Days). I've checked with [~tari_manga], and according to him, the backend DMN validator is capable of detecting the problem and giving a proper error message. However the DMN editor in the workbench does not give any user friendly hint what the problem is, and hence it's almost impossible for a user to figure out what's wrong.
> I've attached both the DMN model and a screenshot of the error message displayed by our editor.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months
[JBoss JIRA] (DROOLS-5017) DMN Validation does not provide a proper descriptive error message
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5017?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-5017:
-----------------------------------
Labels: drools-tools (was: )
> DMN Validation does not provide a proper descriptive error message
> ------------------------------------------------------------------
>
> Key: DROOLS-5017
> URL: https://issues.redhat.com/browse/DROOLS-5017
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Affects Versions: 7.32.0.Final
> Reporter: Duncan Doyle
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: Screenshot 2020-02-06 at 11.25.18.png, vacation-days.dmn
>
>
> The attached DMN file is invalid as it contains a trailing space in one of its decision nodes (Base Vacation Days). I've checked with [~tari_manga], and according to him, the backend DMN validator is capable of detecting the problem and giving a proper error message. However the DMN editor in the workbench does not give any user friendly hint what the problem is, and hence it's almost impossible for a user to figure out what's wrong.
> I've attached both the DMN model and a screenshot of the error message displayed by our editor.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 5 months