[JBoss JIRA] (DROOLS-5060) [DMN Designer] Editor allows node with prefix/trailing space
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5060?page=com.atlassian.jira.plug... ]
Michael Anstis commented on DROOLS-5060:
----------------------------------------
{{ItemDefinition}} names are possibly equally affected.
> [DMN Designer] Editor allows node with prefix/trailing space
> ------------------------------------------------------------
>
> Key: DROOLS-5060
> URL: https://issues.redhat.com/browse/DROOLS-5060
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: ItemDefinition-white-space.png
>
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062])
> * While editing a DRGElement and hitting OK to save its name
> For your consideration, thanks.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5062) [DMN Designer] Automatically correct node prefix/trailing space on import
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5062?page=com.atlassian.jira.plug... ]
Michael Anstis commented on DROOLS-5062:
----------------------------------------
{{ItemDefinition}} names are possibly equally affected.
> [DMN Designer] Automatically correct node prefix/trailing space on import
> -------------------------------------------------------------------------
>
> Key: DROOLS-5062
> URL: https://issues.redhat.com/browse/DROOLS-5062
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Attachments: ItemDefinition-white-space.png
>
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * While Importing a DMN model from file Upload
> * -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
> For your consideration, thanks.
> See [comment|https://issues.redhat.com/browse/DROOLS-5060?focusedCommentId=139...] on DROOLS-5060:-
> {quote}
> I'd like to move the other request ("While Importing a DMN model from file Upload") to a new JIRA for the following reason:
> * It is an automated correction/cleanse
> * We already have one automated correction (when layout information is missing or insufficient)
> * We may, in the future, want to support other automated corrections
> * I'd therefore like to consolidate the approach to how automated corrections are detected, ran and reported to the User. My initial opinion is that when opening (or importing or some other trigger to be determined) a DMN file we collect (probably via CDI discovery) all implementations of "Automated Fixers" (one of which if layout another is trim leading/trailing space etc). We then show the list of possible fixes to the User, they can select whatever they like and then we run them and save the file. Anyway, IMO, it's out of scope of this JIRA as it'd need some UX involvement.
> {quote}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5060) [DMN Designer] Editor allows node with prefix/trailing space
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5060?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-5060:
-----------------------------------
Attachment: ItemDefinition-white-space.png
> [DMN Designer] Editor allows node with prefix/trailing space
> ------------------------------------------------------------
>
> Key: DROOLS-5060
> URL: https://issues.redhat.com/browse/DROOLS-5060
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Labels: drools-tools
> Attachments: ItemDefinition-white-space.png
>
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * -While Importing a DMN model from file Upload- (See [DROOLS-5062|https://issues.redhat.com/browse/DROOLS-5062])
> * While editing a DRGElement and hitting OK to save its name
> For your consideration, thanks.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5062) [DMN Designer] Automatically correct node prefix/trailing space on import
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5062?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-5062:
-----------------------------------
Attachment: ItemDefinition-white-space.png
> [DMN Designer] Automatically correct node prefix/trailing space on import
> -------------------------------------------------------------------------
>
> Key: DROOLS-5062
> URL: https://issues.redhat.com/browse/DROOLS-5062
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
> Attachments: ItemDefinition-white-space.png
>
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * While Importing a DMN model from file Upload
> * -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
> For your consideration, thanks.
> See [comment|https://issues.redhat.com/browse/DROOLS-5060?focusedCommentId=139...] on DROOLS-5060:-
> {quote}
> I'd like to move the other request ("While Importing a DMN model from file Upload") to a new JIRA for the following reason:
> * It is an automated correction/cleanse
> * We already have one automated correction (when layout information is missing or insufficient)
> * We may, in the future, want to support other automated corrections
> * I'd therefore like to consolidate the approach to how automated corrections are detected, ran and reported to the User. My initial opinion is that when opening (or importing or some other trigger to be determined) a DMN file we collect (probably via CDI discovery) all implementations of "Automated Fixers" (one of which if layout another is trim leading/trailing space etc). We then show the list of possible fixes to the User, they can select whatever they like and then we run them and save the file. Anyway, IMO, it's out of scope of this JIRA as it'd need some UX involvement.
> {quote}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFLY-12765) Webservice deployment fails
by Jim Ma (Jira)
[ https://issues.redhat.com/browse/WFLY-12765?page=com.atlassian.jira.plugi... ]
Jim Ma commented on WFLY-12765:
-------------------------------
[~jbliznak] Yes. It's the same issue.
> Webservice deployment fails
> ---------------------------
>
> Key: WFLY-12765
> URL: https://issues.redhat.com/browse/WFLY-12765
> Project: WildFly
> Issue Type: Bug
> Components: Web Services
> Affects Versions: 18.0.0.Final
> Reporter: Jim Ma
> Assignee: Jim Ma
> Priority: Major
> Fix For: 20.0.0.Beta1
>
>
> Enabling elytron in undertow subsystem, EAP fails to deploy a webservice war and show the following error messages:
> 17:44:48,834 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([("deployment" => "wsat-simple.war")]) - failure description: {
> "WFLYCTL0412: Required services that are not installed:" => ["jboss.security.security-domain.other"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => ["jboss.ws.endpoint.\"wsat-simple.war\".\"org.jboss.as.quickstarts.wsa
> t.simple.RestaurantServiceATImpl\" is missing [jboss.security.security-domain.other]"]
> }
> 17:44:48,836 ERROR [org.jboss.as.server] (management-handler-thread - 1) WFLYSRV0021: Deploy of deployment "wsat-simple.war" was rolled back with the following failure message:
> {
> "WFLYCTL0412: Required services that are not installed:" => ["jboss.security.security-domain.other"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => ["jboss.ws.endpoint.\"wsat-simple.war\".\"org.jboss.as.quickstarts.wsat.simple.RestaurantServiceATImpl\" is missing [jboss.security.security-domain.other]"]
> }
> 17:44:48,867 ERROR [org.jboss.ws.common.deployment] (MSC service thread 1-7) JBWS022102: Cannot stop endpoint in state UNDEFINED: jboss.ws:context=,endpoint=org.jboss.as.quickstarts.wsat.simple.RestaurantServiceATImpl
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (ELY-1934) SSO support for BASIC authentication
by Mark Banierink (Jira)
Mark Banierink created ELY-1934:
-----------------------------------
Summary: SSO support for BASIC authentication
Key: ELY-1934
URL: https://issues.redhat.com/browse/ELY-1934
Project: WildFly Elytron
Issue Type: Feature Request
Reporter: Mark Banierink
Assignee: Darran Lofthouse
With the legacy login system, single sign-on was supported for any mechanism. However, when using Elytron, SSO is supported for FORM, SPNEGO and CLIENT-CERT, but not supported for BASIC authentication mechanism.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5062) [DMN Designer] Automatically correct node prefix/trailing space on import
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5062?page=com.atlassian.jira.plug... ]
Michael Anstis commented on DROOLS-5062:
----------------------------------------
[~karreiro], [~dadossan], [~tirelli]
WDYT (about a mechanism to present "automatic fixes" to users and allowing them to select which to apply when opening/importing a file)?
> [DMN Designer] Automatically correct node prefix/trailing space on import
> -------------------------------------------------------------------------
>
> Key: DROOLS-5062
> URL: https://issues.redhat.com/browse/DROOLS-5062
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * While Importing a DMN model from file Upload
> * -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
> For your consideration, thanks.
> See [comment|https://issues.redhat.com/browse/DROOLS-5060?focusedCommentId=139...] on DROOLS-5060:-
> {quote}
> I'd like to move the other request ("While Importing a DMN model from file Upload") to a new JIRA for the following reason:
> * It is an automated correction/cleanse
> * We already have one automated correction (when layout information is missing or insufficient)
> * We may, in the future, want to support other automated corrections
> * I'd therefore like to consolidate the approach to how automated corrections are detected, ran and reported to the User. My initial opinion is that when opening (or importing or some other trigger to be determined) a DMN file we collect (probably via CDI discovery) all implementations of "Automated Fixers" (one of which if layout another is trim leading/trailing space etc). We then show the list of possible fixes to the User, they can select whatever they like and then we run them and save the file. Anyway, IMO, it's out of scope of this JIRA as it'd need some UX involvement.
> {quote}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5062) [DMN Designer] Automatically correct node prefix/trailing space on import
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5062?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-5062:
-----------------------------------
Description:
I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
But, imho, an UX point is not being considered, where is necessary instead.
By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
Further, I consider is just the Analyst which slipped a space.
In my perspective, the editor should just strip away the prefix/trailing space:
* While Importing a DMN model from file Upload
* -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
For your consideration, thanks.
See [comment|https://issues.redhat.com/browse/DROOLS-5060?focusedCommentId=139...] on DROOLS-5060:-
{quote}
I'd like to move the other request ("While Importing a DMN model from file Upload") to a new JIRA for the following reason:
* It is an automated correction/cleanse
* We already have one automated correction (when layout information is missing or insufficient)
* We may, in the future, want to support other automated corrections
* I'd therefore like to consolidate the approach to how automated corrections are detected, ran and reported to the User. My initial opinion is that when opening (or importing or some other trigger to be determined) a DMN file we collect (probably via CDI discovery) all implementations of "Automated Fixers" (one of which if layout another is trim leading/trailing space etc). We then show the list of possible fixes to the User, they can select whatever they like and then we run them and save the file. Anyway, IMO, it's out of scope of this JIRA as it'd need some UX involvement.
{quote}
was:
I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
But, imho, an UX point is not being considered, where is necessary instead.
By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
Further, I consider is just the Analyst which slipped a space.
In my perspective, the editor should just strip away the prefix/trailing space:
* While Importing a DMN model from file Upload
* -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
For your consideration, thanks.
> [DMN Designer] Automatically correct node prefix/trailing space on import
> -------------------------------------------------------------------------
>
> Key: DROOLS-5062
> URL: https://issues.redhat.com/browse/DROOLS-5062
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * While Importing a DMN model from file Upload
> * -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
> For your consideration, thanks.
> See [comment|https://issues.redhat.com/browse/DROOLS-5060?focusedCommentId=139...] on DROOLS-5060:-
> {quote}
> I'd like to move the other request ("While Importing a DMN model from file Upload") to a new JIRA for the following reason:
> * It is an automated correction/cleanse
> * We already have one automated correction (when layout information is missing or insufficient)
> * We may, in the future, want to support other automated corrections
> * I'd therefore like to consolidate the approach to how automated corrections are detected, ran and reported to the User. My initial opinion is that when opening (or importing or some other trigger to be determined) a DMN file we collect (probably via CDI discovery) all implementations of "Automated Fixers" (one of which if layout another is trim leading/trailing space etc). We then show the list of possible fixes to the User, they can select whatever they like and then we run them and save the file. Anyway, IMO, it's out of scope of this JIRA as it'd need some UX involvement.
> {quote}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5062) [DMN Designer] Automatically correct node prefix/trailing space on import
by Michael Anstis (Jira)
[ https://issues.redhat.com/browse/DROOLS-5062?page=com.atlassian.jira.plug... ]
Michael Anstis updated DROOLS-5062:
-----------------------------------
Description:
I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
But, imho, an UX point is not being considered, where is necessary instead.
By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
Further, I consider is just the Analyst which slipped a space.
In my perspective, the editor should just strip away the prefix/trailing space:
* While Importing a DMN model from file Upload
* -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
For your consideration, thanks.
was:
I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
But, imho, an UX point is not being considered, where is necessary instead.
By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
Further, I consider is just the Analyst which slipped a space.
In my perspective, the editor should just strip away the prefix/trailing space:
* while Importing a DMN model from file Upload
* while editing a DRGElement and hitting OK to save its name
For your consideration, thanks.
> [DMN Designer] Automatically correct node prefix/trailing space on import
> -------------------------------------------------------------------------
>
> Key: DROOLS-5062
> URL: https://issues.redhat.com/browse/DROOLS-5062
> Project: Drools
> Issue Type: Bug
> Components: DMN Editor
> Reporter: Matteo Mortari
> Assignee: Michael Anstis
> Priority: Major
>
> I understand [DROOLS-5017] has been re-purposed to allow Info and Warn level messages be displayed on Stunner Validation dialog. That is fine.
> But, imho, an UX point is not being considered, where is necessary instead.
> By the DMN spec, a node should not have a prefix/trailing space, as space insensitivity would mandate 1 trailing or 2 trailing spaces are simply ignored etc.
> The engine is lenient to avoid this crashing the evaluation, but still is a bad designed model to persist the node name (DRGElement name and its corresponding variable name) with those extra spaces IMHO.
> Further, I consider is just the Analyst which slipped a space.
> In my perspective, the editor should just strip away the prefix/trailing space:
> * While Importing a DMN model from file Upload
> * -While editing a DRGElement and hitting OK to save its name- (See [DROOLS-5060|https://issues.redhat.com/browse/DROOLS-5060])
> For your consideration, thanks.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months