March 2020 - jboss-jira - Jboss List Archives

[JBoss JIRA] (JGRP-2435) ClientGmsImpl ignores newer view during join

by Bela Ban (Jira)

[ https://issues.redhat.com/browse/JGRP-2435?page=com.atlassian.jira.plugin... ] Bela Ban commented on JGRP-2435: -------------------------------- The logic to become client, coord or participant was moved into the synchronized scope of {{GMS.installView()}}. This fixes the failing unit test > ClientGmsImpl ignores newer view during join > -------------------------------------------- > > Key: JGRP-2435 > URL: https://issues.redhat.com/browse/JGRP-2435 > Project: JGroups > Issue Type: Bug > Affects Versions: 4.1.9 > Reporter: Dan Berindei > Assignee: Bela Ban > Priority: Major > Fix For: 5.0, 4.2.1 > > > We have random failures in a test that starts 4 nodes in parallel ({{org.infinispan.InitialClusterSizeTest.testInitialClusterSize}}). I get at least one failure if I add {{@Test(invocationCount=100)}}, but I did not get any failure when I did the same with {{org.jgroups.tests.ConcurrentStartupTest.testConcurrentJoinWithLOCAL_PING()}}, maybe because the Infinispan test sends some additional messages and sometimes changes how messages are processed. > The problem seems to be that after receiving a {{JOIN_RSP}} and installing the first view, the GMS implementation is still {{ClientGmsImpl}} when receiving the second view, and the view is ignored. Because this second view already has all 4 members, there is no other {{VIEW}} message and the test just times out. > I added some logs in TP and GMS for debugging, and this is what I see: > {noformat} > 10:37:42,896 TRACE (ucast-receiver-2,Test-NodeC:[]) [UDP] Received oob=false internal=true message GMS: GmsHeader[JOIN_RSP], UNICAST3: DATA, seqno=1, first, TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,898 TRACE (mcast-receiver-3,Test-NodeC:[]) [UDP] Received oob=false internal=false message GMS: GmsHeader[VIEW], NAKACK2: [MSG, seqno=1], TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,906 TRACE (jgroups-4,Test-NodeC:[]) [UDP] Test-NodeC: received [Test-NodeB to Test-NodeC, 61 bytes, flags=INTERNAL], headers are GMS: GmsHeader[JOIN_RSP], UNICAST3: DATA, seqno=1, first, TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,906 TRACE (jgroups-4,Test-NodeC:[]) [GMS] Handling message GMS: GmsHeader[JOIN_RSP], UNICAST3: DATA, seqno=1, first, TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,907 DEBUG (ForkThread-1,InitialClusterSizeTest:[]) [GMS] Test-NodeC: installing view [Test-NodeB|1] (2) [Test-NodeB, Test-NodeC] > 10:37:42,947 TRACE (mcast-receiver-3,Test-NodeC:[]) [UDP] Received oob=false internal=false message GMS: GmsHeader[VIEW], NAKACK2: [MSG, seqno=2], TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,948 TRACE (jgroups-5,Test-NodeC:[]) [UDP] Test-NodeC: received message batch of from Test-NodeB: dest=null, sender=Test-NodeB > 1: > #1: GMS: GmsHeader[VIEW], NAKACK2: [MSG, seqno=1], TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,948 TRACE (jgroups-5,Test-NodeC:[]) [GMS] Handling message GMS: GmsHeader[VIEW], NAKACK2: [MSG, seqno=1], TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,948 TRACE (jgroups-5,Test-NodeC:[]) [UDP] Test-NodeC: received message batch of from Test-NodeB: dest=null, sender=Test-NodeB > 1: > #1: GMS: GmsHeader[VIEW], NAKACK2: [MSG, seqno=2], TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:42,948 TRACE (jgroups-5,Test-NodeC:[]) [GMS] Handling message GMS: GmsHeader[VIEW], NAKACK2: [MSG, seqno=2], TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > ### GmsImpl.handleViewChange() {} > 10:37:42,948 TRACE (jgroups-5,Test-NodeC:[]) [GMS] GmsImpl ignoring view update [Test-NodeB|2] (4) [Test-NodeB, Test-NodeC, Test-NodeA, Test-NodeD] > 10:37:42,950 TRACE (jgroups-5,Test-NodeC:[]) [UDP] Test-NodeC: sending msg to Test-NodeB, src=Test-NodeC, headers are GMS: GmsHeader[VIEW_ACK], UNICAST3: DATA, seqno=3, TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > ### The ack for the JOIN_RSP is only sent here > 10:37:43,034 TRACE (ForkThread-1,InitialClusterSizeTest:[]) [UDP] Test-NodeC: sending msg to Test-NodeB, src=Test-NodeC, headers are GMS: GmsHeader[VIEW_ACK], UNICAST3: DATA, seqno=4, TP: [cluster=org.infinispan.remoting.transport.InitialClusterSizeTest] > 10:37:43,034 DEBUG (ForkThread-1,InitialClusterSizeTest:[]) [JGroupsTransport] Waiting for 4 nodes, current view has 2 > {noformat} > To help debugging, {{TP.passBatchUp}} should really log the headers of the messages in the batch, and {{GMS}} and the {{GmsImpl}} subclasses should log at least a DEBUG message every time they ignore a view (even when {{log_view_warnings==false}}). I also suggest removing the default implementations from {{GmsImpl}} and updating the {{ClientGmsImpl}} javadoc, because it talks about handling {{ViewChange}} instead of {{JoinResponse}}. -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-4872) (7.3.z) Upgrade WildFly Elytron from 1.10.5.Final-redhat-00001 to 1.10.6.Final

by Lin Gao (Jira)

[ https://issues.redhat.com/browse/WFCORE-4872?page=com.atlassian.jira.plug... ] Lin Gao reassigned WFCORE-4872: ------------------------------- Assignee: Lin Gao (was: Farah Juma) > (7.3.z) Upgrade WildFly Elytron from 1.10.5.Final-redhat-00001 to 1.10.6.Final > ------------------------------------------------------------------------------ > > Key: WFCORE-4872 > URL: https://issues.redhat.com/browse/WFCORE-4872 > Project: WildFly Core > Issue Type: Component Upgrade > Components: Security > Reporter: Lin Gao > Assignee: Lin Gao > Priority: Major > Labels: downstream_dependency > > https://github.com/wildfly-security/wildfly-elytron/compare/1.11.2.Final.... -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-4872) (7.3.z) Upgrade WildFly Elytron from 1.10.5.Final-redhat-00001 to 1.10.6.Final

by Lin Gao (Jira)

Lin Gao created WFCORE-4872: ------------------------------- Summary: (7.3.z) Upgrade WildFly Elytron from 1.10.5.Final-redhat-00001 to 1.10.6.Final Key: WFCORE-4872 URL: https://issues.redhat.com/browse/WFCORE-4872 Project: WildFly Core Issue Type: Component Upgrade Components: Security Reporter: Lin Gao Assignee: Farah Juma https://github.com/wildfly-security/wildfly-elytron/compare/1.11.2.Final.... -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13231) Upgrade WildFly Core from 11.0.0.Final to 11.0.1.Final

by Lin Gao (Jira)

[ https://issues.redhat.com/browse/WFLY-13231?page=com.atlassian.jira.plugi... ] Lin Gao updated WFLY-13231: --------------------------- Description: https://github.com/wildfly/wildfly-core/compare/11.0.0.Final...master > Upgrade WildFly Core from 11.0.0.Final to 11.0.1.Final > ------------------------------------------------------ > > Key: WFLY-13231 > URL: https://issues.redhat.com/browse/WFLY-13231 > Project: WildFly > Issue Type: Component Upgrade > Components: Management > Reporter: Lin Gao > Assignee: Jeff Mesnil > Priority: Major > Labels: downstream_dependency > > https://github.com/wildfly/wildfly-core/compare/11.0.0.Final...master -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-13231) Upgrade WildFly Core from 11.0.0.Final to 11.0.1.Final

by Lin Gao (Jira)

Lin Gao created WFLY-13231: ------------------------------ Summary: Upgrade WildFly Core from 11.0.0.Final to 11.0.1.Final Key: WFLY-13231 URL: https://issues.redhat.com/browse/WFLY-13231 Project: WildFly Issue Type: Component Upgrade Components: Management Reporter: Lin Gao Assignee: Jeff Mesnil -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ELY-1940) Elytron LDAP Squashes Authentication Exception

by Lin Gao (Jira)

[ https://issues.redhat.com/browse/ELY-1940?page=com.atlassian.jira.plugin.... ] Lin Gao updated ELY-1940: ------------------------- Labels: downstream_dependency elytron ldap logging (was: elytron ldap logging) > Elytron LDAP Squashes Authentication Exception > ---------------------------------------------- > > Key: ELY-1940 > URL: https://issues.redhat.com/browse/ELY-1940 > Project: WildFly Elytron > Issue Type: Bug > Components: Authentication Mechanisms > Reporter: Lin Gao > Assignee: Lin Gao > Priority: Major > Labels: downstream_dependency, elytron, ldap, logging > > Trace logging shows: > {code} > 2020-03-10 13:51:38,549 DEBUG [org.wildfly.security] (management task-1) Found entry [uid=dguthrie,ou=users,dc=example,dc=com]. > 2020-03-10 13:51:38,550 DEBUG [org.wildfly.security] (management task-1) Identity for principal [dguthrie] found at [uid=dguthrie,ou=users,dc=example,dc=com]. > 2020-03-10 13:51:38,581 DEBUG [org.wildfly.security] (management task-1) Credential direct evidence verification failed. DN: [uid=dguthrie,ou=users,dc=example,dc=com] > 2020-03-10 13:51:38,581 DEBUG [org.wildfly.security] (management task-1) Context [javax.naming.ldap.InitialLdapContext@25061db2] was closed. Connection closed or just returned to the pool. > 2020-03-10 13:51:38,581 TRACE [org.wildfly.security] (management task-1) Handling AuthenticationCompleteCallback: fail > 2020-03-10 13:51:38,582 TRACE [org.jboss.remoting.remote.server] (management task-1) Server sending authentication rejected: javax.security.sasl.SaslException: ELY05013: Authentication mechanism password not verified > {code} > > Where "Credential direct evidence verification failed. DN [uid=dguthrie,ou=users,dc=example,dc=com]" is missing the exception or even a reason. > In DirectEvidenceVerifier.java around line 102 in the Exception handler it has > {code} > log.debugf("Credential direct evidence verification failed. DN: [%s]", distinguishedName,e); > {code} > In this case, the "e" is the exception, but that parameter position is for the string formatting for which there is no token in the formatter. I believe what they meant to write was: > {code} > log.debugf(e, "Credential direct evidence verification failed. DN: [%s]", distinguishedName); > {code} > See [GitHub|https://github.com/jbossas/wildfly-elytron/blob/96c2273dc0503a23d1...] > where the first parameter is the exception. A customer is migrating from legacy to elytron, and they have been using the LDAP error codes in the log for their internal IT to help figure out why people failed login. It's also invaluable for support. -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-4871) Upgrade WildFly Elytron to 1.11.3.Final

by Lin Gao (Jira)

Lin Gao created WFCORE-4871: ------------------------------- Summary: Upgrade WildFly Elytron to 1.11.3.Final Key: WFCORE-4871 URL: https://issues.redhat.com/browse/WFCORE-4871 Project: WildFly Core Issue Type: Component Upgrade Components: Security Reporter: Lin Gao Assignee: Farah Juma https://github.com/wildfly-security/wildfly-elytron/compare/1.11.2.Final.... -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFCORE-4871) Upgrade WildFly Elytron to 1.11.3.Final

by Lin Gao (Jira)

[ https://issues.redhat.com/browse/WFCORE-4871?page=com.atlassian.jira.plug... ] Lin Gao updated WFCORE-4871: ---------------------------- Labels: downstream_dependency (was: ) > Upgrade WildFly Elytron to 1.11.3.Final > --------------------------------------- > > Key: WFCORE-4871 > URL: https://issues.redhat.com/browse/WFCORE-4871 > Project: WildFly Core > Issue Type: Component Upgrade > Components: Security > Reporter: Lin Gao > Assignee: Farah Juma > Priority: Major > Labels: downstream_dependency > > https://github.com/wildfly-security/wildfly-elytron/compare/1.11.2.Final.... -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (SWSQE-1091) Update jenkins job descriptions

by Filip Brychta (Jira)

Filip Brychta created SWSQE-1091: ------------------------------------ Summary: Update jenkins job descriptions Key: SWSQE-1091 URL: https://issues.redhat.com/browse/SWSQE-1091 Project: Kiali QE Issue Type: QE Task Reporter: Filip Brychta Assignee: Filip Brychta Some job descriptions are bad and some are missing. We need to update it. -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ELY-1940) Elytron LDAP Squashes Authentication Exception

by Lin Gao (Jira)

[ https://issues.redhat.com/browse/ELY-1940?page=com.atlassian.jira.plugin.... ] Lin Gao moved JBEAP-18928 to ELY-1940: -------------------------------------- Project: WildFly Elytron (was: JBoss Enterprise Application Platform) Key: ELY-1940 (was: JBEAP-18928) Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1) Component/s: Authentication Mechanisms (was: Security) Affects Version/s: (was: 7.3.0.CD18) (was: 7.2.6.GA) Fix Version/s: (was: 7.2.9.GA) > Elytron LDAP Squashes Authentication Exception > ---------------------------------------------- > > Key: ELY-1940 > URL: https://issues.redhat.com/browse/ELY-1940 > Project: WildFly Elytron > Issue Type: Bug > Components: Authentication Mechanisms > Reporter: Lin Gao > Assignee: Lin Gao > Priority: Major > Labels: elytron, ldap, logging > > Trace logging shows: > {code} > 2020-03-10 13:51:38,549 DEBUG [org.wildfly.security] (management task-1) Found entry [uid=dguthrie,ou=users,dc=example,dc=com]. > 2020-03-10 13:51:38,550 DEBUG [org.wildfly.security] (management task-1) Identity for principal [dguthrie] found at [uid=dguthrie,ou=users,dc=example,dc=com]. > 2020-03-10 13:51:38,581 DEBUG [org.wildfly.security] (management task-1) Credential direct evidence verification failed. DN: [uid=dguthrie,ou=users,dc=example,dc=com] > 2020-03-10 13:51:38,581 DEBUG [org.wildfly.security] (management task-1) Context [javax.naming.ldap.InitialLdapContext@25061db2] was closed. Connection closed or just returned to the pool. > 2020-03-10 13:51:38,581 TRACE [org.wildfly.security] (management task-1) Handling AuthenticationCompleteCallback: fail > 2020-03-10 13:51:38,582 TRACE [org.jboss.remoting.remote.server] (management task-1) Server sending authentication rejected: javax.security.sasl.SaslException: ELY05013: Authentication mechanism password not verified > {code} > > Where "Credential direct evidence verification failed. DN [uid=dguthrie,ou=users,dc=example,dc=com]" is missing the exception or even a reason. > In DirectEvidenceVerifier.java around line 102 in the Exception handler it has > {code} > log.debugf("Credential direct evidence verification failed. DN: [%s]", distinguishedName,e); > {code} > In this case, the "e" is the exception, but that parameter position is for the string formatting for which there is no token in the formatter. I believe what they meant to write was: > {code} > log.debugf(e, "Credential direct evidence verification failed. DN: [%s]", distinguishedName); > {code} > See [GitHub|https://github.com/jbossas/wildfly-elytron/blob/96c2273dc0503a23d1...] > where the first parameter is the exception. A customer is migrating from legacy to elytron, and they have been using the LDAP error codes in the log for their internal IT to help figure out why people failed login. It's also invaluable for support. -- This message was sent by Atlassian Jira (v7.13.8#713008)

6 years, 4 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira March 2020