[JBoss JIRA] (JGRP-2406) MERGE3 not working with TCP using ForkJoinPool
by Olivier Peyrusse (Jira)
[ https://issues.redhat.com/browse/JGRP-2406?page=com.atlassian.jira.plugin... ]
Olivier Peyrusse commented on JGRP-2406:
----------------------------------------
Hello Bela Ban,
although I am not familiar yet with the internal machinery of JGroups, that was also my interpretation of the problem. I saw that your tasks were blocked on a Conditional, which is not supported by the FJP. You could always detect the use of a FJP, try using {{ManagedBlocker}}, etc, but it is cumbersome.
I agree with your opinion that a FJP may not be useful to JGroups, at least for this part. In the project I submitted, it was enabled by one of my colleagues and I think the reason for this choice is that our own product heavily relies on FJPs. So seeing the option must have triggered an habit and then it was enabled.
As I said, I reverted that change and the application was working like a charm.
Thanks for the investigation.
> MERGE3 not working with TCP using ForkJoinPool
> ----------------------------------------------
>
> Key: JGRP-2406
> URL: https://issues.redhat.com/browse/JGRP-2406
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.1.8
> Reporter: Olivier Peyrusse
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 4.2.1
>
> Attachments: logs.tgz, project.zip, timeline.txt
>
>
> With JDK11, using the TCP protocol with the ForkJoinPool is causing constant failures of MERGE3.
> I consistently observed the following, from the point of view of a member M
> - M asks for other coordinator views. It contacts A and B
> - A and B send their views
> - M waits and timeouts for receiving views and abort the merge
> - immediately after aborting the merge, M process messages containing the views of A and B.
> In [^timeline.txt], you will see the extracts for logs from the various members at play.
> After many experiments, the one parameter causing this issue is in the TCP protocol.
> {code:xml}
> <TCP
> ...
> thread_pool.use_fork_join_pool="true" />
> {code}
> Setting {{thread_pool.use_fork_join_pool}} to true repeatedly produces the problem, while using {{thread_pool.use_fork_join_pool}} with false works fine.
> Project details:
> - as tested within Kubernetes, this project uses KUBE_PING as its discovery protocol
> - to understand the reason for the failed merges, I created the protocol MERGE4, that is MERGE3 with additional logs.
> - [^logs.tgz] contains all logs from the various members involved in the test.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (DROOLS-4916) Investigate modify parsing bug in executable model
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-4916?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi reassigned DROOLS-4916:
-----------------------------------------
Assignee: Toshiya Kobayashi (was: Luca Molteni)
> Investigate modify parsing bug in executable model
> --------------------------------------------------
>
> Key: DROOLS-4916
> URL: https://issues.redhat.com/browse/DROOLS-4916
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Reporter: Luca Molteni
> Assignee: Toshiya Kobayashi
> Priority: Major
> Labels: good-first-issue
>
> declare Application
> categories : Set = new HashSet()
> Then I had a modify statement scattered about:
> modify ($a) {
> $a.getCategories().add("hello");
> }
> The ExecutableModel did not seem to like any of those. I changed it to:
> $a.getCategories().add("hello");
> update($a);
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (WFLY-13059) org.apache.ws.security exports Jasypt
by Jim Ma (Jira)
[ https://issues.redhat.com/browse/WFLY-13059?page=com.atlassian.jira.plugi... ]
Jim Ma edited comment on WFLY-13059 at 3/16/20 3:16 AM:
--------------------------------------------------------
[~pmm] Sorry for the long delay. Did you try to provide a jboss-deployment-structure.xml to exclude org.apache.ws.security module and add all the jars you need in application ?
> org.apache.ws.security exports Jasypt
> -------------------------------------
>
> Key: WFLY-13059
> URL: https://issues.redhat.com/browse/WFLY-13059
> Project: WildFly
> Issue Type: Bug
> Components: Web Services
> Reporter: Philippe Marschall
> Assignee: Jim Ma
> Priority: Major
>
> The {{org.apache.ws.security}} module contains the Jasypt JAR and exports it. Jasypt is only used internally by {{org.apache.wss4j.common.crypto.JasyptPasswordEncryptor}} and not used externally.
> Our application has a dependency on {{org.jboss.ws.cxf.jbossws-cxf-client}} which has an exported dependency on {{org.apache.ws.security}} which exports Jasypt. As a consequence the Jasypt from the {{org.apache.ws.security}} module is used instead of the Jasypt from our application.
> We would be willing to work on a patch. We see two possible options:
> # Introduce a dedicated Jasypt module and make {{org.apache.ws.security}} depend on it without exporting it
> # Add a resource filter to the {{org.apache.ws.security}} module like this {code}
> <exports>
> <exclude path="org/jasypt/**"/>
> </exports>
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (DROOLS-5028) Support incremental update for function with executable model
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5028?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi updated DROOLS-5028:
--------------------------------------
Sprint: 2020 Week 10-12 (from Mar 2)
> Support incremental update for function with executable model
> -------------------------------------------------------------
>
> Key: DROOLS-5028
> URL: https://issues.redhat.com/browse/DROOLS-5028
> Project: Drools
> Issue Type: Task
> Components: executable model
> Affects Versions: 7.32.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
> Labels: good-first-issue
>
> When you do incremental compilation with executable model, if a function is updated, you will get this error.
> {noformat}
> [ERROR] testKJarUpgradeWithChangedFunction[PATTERN_DSL](org.drools.modelcompiler.IncrementalCompilationTest) Time elapsed: 2.682 s <<< ERROR!
> java.lang.IllegalArgumentException: Unsupported change type: function!
> at org.drools.modelcompiler.builder.CanonicalKieBaseUpdater.run(CanonicalKieBaseUpdater.java:148)
> at org.drools.core.impl.KnowledgeBaseImpl.enqueueModification(KnowledgeBaseImpl.java:745)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:266)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:236)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.updateToVersion(KieContainerImpl.java:194)
> at org.drools.modelcompiler.IncrementalCompilationTest.testKJarUpgradeWithChangedFunction(IncrementalCompilationTest.java:359)
> ...
> {noformat}
> This is an explicit limitation at the moment but I filed this JIRA to support a function update.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months
[JBoss JIRA] (DROOLS-5028) Support incremental update for function with executable model
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5028?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi reassigned DROOLS-5028:
-----------------------------------------
Assignee: Toshiya Kobayashi (was: Luca Molteni)
> Support incremental update for function with executable model
> -------------------------------------------------------------
>
> Key: DROOLS-5028
> URL: https://issues.redhat.com/browse/DROOLS-5028
> Project: Drools
> Issue Type: Task
> Components: executable model
> Affects Versions: 7.32.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
> Labels: good-first-issue
>
> When you do incremental compilation with executable model, if a function is updated, you will get this error.
> {noformat}
> [ERROR] testKJarUpgradeWithChangedFunction[PATTERN_DSL](org.drools.modelcompiler.IncrementalCompilationTest) Time elapsed: 2.682 s <<< ERROR!
> java.lang.IllegalArgumentException: Unsupported change type: function!
> at org.drools.modelcompiler.builder.CanonicalKieBaseUpdater.run(CanonicalKieBaseUpdater.java:148)
> at org.drools.core.impl.KnowledgeBaseImpl.enqueueModification(KnowledgeBaseImpl.java:745)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:266)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.update(KieContainerImpl.java:236)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.updateToVersion(KieContainerImpl.java:194)
> at org.drools.modelcompiler.IncrementalCompilationTest.testKJarUpgradeWithChangedFunction(IncrementalCompilationTest.java:359)
> ...
> {noformat}
> This is an explicit limitation at the moment but I filed this JIRA to support a function update.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 3 months