[JBoss JIRA] (WFCORE-4905) Provide common capability for Remoting connectors
by Richard Achmatowicz (Jira)
[ https://issues.redhat.com/browse/WFCORE-4905?page=com.atlassian.jira.plug... ]
Richard Achmatowicz updated WFCORE-4905:
----------------------------------------
Git Pull Request: https://github.com/wildfly/wildfly-core/pull/4132 (was: https://github.com/wildfly/wildfly-core/pull/4099)
> Provide common capability for Remoting connectors
> -------------------------------------------------
>
> Key: WFCORE-4905
> URL: https://issues.redhat.com/browse/WFCORE-4905
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 11.0.0.Final
> Reporter: Richard Achmatowicz
> Assignee: Richard Achmatowicz
> Priority: Major
> Fix For: 11.0.1.Final
>
>
> The EJB3 subsystem has an element <remote/> which performs a few different functions relating to external clients accessing EJBs on the server:
> * sets up a Remoting connector service so that external clients may connect to the server using EJB / Remoting or EJB / HTTP Upgrade / Remoting
> * sets up client mappings entries for those remote clients which are used in topology updates to allow the client to find the server's connectors
> The Remoting subsystem has two connector types which may be supplied to the <remote connector-ref/> attribute. <connector name="remoting-connector"/> represents a Remoting endpoint and <http-connector name="http-connector"/> represents an Undertow listener which may be used with HTTP Upgrade.
> At present, in the Remoting subsystem, these connectors have two separately defined capabilities:
> // for <connector/>
> private static final String CONNECTOR_CAPABILITY_NAME ="org.wildfly.remoting.connector";
> static final RuntimeCapability<Void> CONNECTOR_CAPABILITY = RuntimeCapability.Builder.of(CONNECTOR_CAPABILITY_NAME, true).build();
> // for <http-connector/>
> private static final String HTTP_CONNECTOR_CAPABILITY_NAME = "org.wildfly.remoting.http-connector";
> static final RuntimeCapability<Void> HTTP_CONNECTOR_CAPABILITY = RuntimeCapability.Builder.of(HTTP_CONNECTOR_CAPABILITY_NAME, true).build();
> The proposal here is to allow referencing both connectors using a single capability base name, "org.wildfly.remoting.connector" to simplify specification of the capabilities which the <remote/> element needs (i.e. it may depend on one or the other). These are both dynamically named capabilities, so their names will vary based on the name of the management resource instance they represent. Because capability names are considered public API, the existing capability name for org.wildfly.remoting.http-connector cannot be removed to further simplify.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (WFCORE-4905) Provide common capability for Remoting connectors
by Richard Achmatowicz (Jira)
[ https://issues.redhat.com/browse/WFCORE-4905?page=com.atlassian.jira.plug... ]
Richard Achmatowicz updated WFCORE-4905:
----------------------------------------
Fix Version/s: 11.0.1.Final
(was: 12.0.0.Beta1)
> Provide common capability for Remoting connectors
> -------------------------------------------------
>
> Key: WFCORE-4905
> URL: https://issues.redhat.com/browse/WFCORE-4905
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 11.0.0.Final
> Reporter: Richard Achmatowicz
> Assignee: Richard Achmatowicz
> Priority: Major
> Fix For: 11.0.1.Final
>
>
> The EJB3 subsystem has an element <remote/> which performs a few different functions relating to external clients accessing EJBs on the server:
> * sets up a Remoting connector service so that external clients may connect to the server using EJB / Remoting or EJB / HTTP Upgrade / Remoting
> * sets up client mappings entries for those remote clients which are used in topology updates to allow the client to find the server's connectors
> The Remoting subsystem has two connector types which may be supplied to the <remote connector-ref/> attribute. <connector name="remoting-connector"/> represents a Remoting endpoint and <http-connector name="http-connector"/> represents an Undertow listener which may be used with HTTP Upgrade.
> At present, in the Remoting subsystem, these connectors have two separately defined capabilities:
> // for <connector/>
> private static final String CONNECTOR_CAPABILITY_NAME ="org.wildfly.remoting.connector";
> static final RuntimeCapability<Void> CONNECTOR_CAPABILITY = RuntimeCapability.Builder.of(CONNECTOR_CAPABILITY_NAME, true).build();
> // for <http-connector/>
> private static final String HTTP_CONNECTOR_CAPABILITY_NAME = "org.wildfly.remoting.http-connector";
> static final RuntimeCapability<Void> HTTP_CONNECTOR_CAPABILITY = RuntimeCapability.Builder.of(HTTP_CONNECTOR_CAPABILITY_NAME, true).build();
> The proposal here is to allow referencing both connectors using a single capability base name, "org.wildfly.remoting.connector" to simplify specification of the capabilities which the <remote/> element needs (i.e. it may depend on one or the other). These are both dynamically named capabilities, so their names will vary based on the name of the management resource instance they represent. Because capability names are considered public API, the existing capability name for org.wildfly.remoting.http-connector cannot be removed to further simplify.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (WFCORE-4905) Provide common capability for Remoting connectors
by Richard Achmatowicz (Jira)
Richard Achmatowicz created WFCORE-4905:
-------------------------------------------
Summary: Provide common capability for Remoting connectors
Key: WFCORE-4905
URL: https://issues.redhat.com/browse/WFCORE-4905
Project: WildFly Core
Issue Type: Bug
Components: Remoting
Affects Versions: 11.0.0.Final
Reporter: Richard Achmatowicz
Assignee: Richard Achmatowicz
Fix For: 12.0.0.Beta1
The EJB3 subsystem has an element <remote/> which performs a few different functions relating to external clients accessing EJBs on the server:
* sets up a Remoting connector service so that external clients may connect to the server using EJB / Remoting or EJB / HTTP Upgrade / Remoting
* sets up client mappings entries for those remote clients which are used in topology updates to allow the client to find the server's connectors
The Remoting subsystem has two connector types which may be supplied to the <remote connector-ref/> attribute. <connector name="remoting-connector"/> represents a Remoting endpoint and <http-connector name="http-connector"/> represents an Undertow listener which may be used with HTTP Upgrade.
At present, in the Remoting subsystem, these connectors have two separately defined capabilities:
// for <connector/>
private static final String CONNECTOR_CAPABILITY_NAME ="org.wildfly.remoting.connector";
static final RuntimeCapability<Void> CONNECTOR_CAPABILITY = RuntimeCapability.Builder.of(CONNECTOR_CAPABILITY_NAME, true).build();
// for <http-connector/>
private static final String HTTP_CONNECTOR_CAPABILITY_NAME = "org.wildfly.remoting.http-connector";
static final RuntimeCapability<Void> HTTP_CONNECTOR_CAPABILITY = RuntimeCapability.Builder.of(HTTP_CONNECTOR_CAPABILITY_NAME, true).build();
The proposal here is to allow referencing both connectors using a single capability base name, "org.wildfly.remoting.connector" to simplify specification of the capabilities which the <remote/> element needs (i.e. it may depend on one or the other). These are both dynamically named capabilities, so their names will vary based on the name of the management resource instance they represent. Because capability names are considered public API, the existing capability name for org.wildfly.remoting.http-connector cannot be removed to further simplify.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-4919) Long running query at kie-server startup
by Danny Rucker (Jira)
[ https://issues.redhat.com/browse/DROOLS-4919?page=com.atlassian.jira.plug... ]
Danny Rucker commented on DROOLS-4919:
--------------------------------------
Hi,
This is an issue that is still affecting us during our deployments. So I wanted to see what help could I provide on providing a fix for it, but I see you may have already fixed it. Can help me determine what settings are needed, and where they are so I can set it up properly?
Thanks,
Danny
> Long running query at kie-server startup
> ----------------------------------------
>
> Key: DROOLS-4919
> URL: https://issues.redhat.com/browse/DROOLS-4919
> Project: Drools
> Issue Type: Bug
> Components: kie server
> Affects Versions: 7.28.0.Final
> Reporter: Danny Rucker
> Assignee: Maciej Swiderski
> Priority: Major
>
> The following query is executed at start up of kie-server
> ```
> select vil.processInstanceId, vil.processId, vil.id, vil.variableId, vil.value from VariableInstanceLog vil where vil.id in (select MAX(v.id) from VariableInstanceLog v group by v.variableId, v.processInstanceId)
> ```
> This is causing some issues with getting kie-server to start up.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (WFLY-11905) Move module org.apache.xml-resolver from WildFly Core to WildFly
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-11905?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFLY-11905:
-----------------------------------------
[~parsharma] If there isn't one already, please file a WFCORE JIRA to track the removal of this from WildFly Core. And please link any WFCORE JIRA to this one.
> Move module org.apache.xml-resolver from WildFly Core to WildFly
> ----------------------------------------------------------------
>
> Key: WFLY-11905
> URL: https://issues.redhat.com/browse/WFLY-11905
> Project: WildFly
> Issue Type: Task
> Components: Web Services
> Reporter: Brian Stansberry
> Assignee: Parul Sharma
> Priority: Minor
>
> The org.apache.xml-resolver module is not used by WildFly Core. Only use is in full:
> {code}
> $ git grep xml-resolver | grep module.x
> feature-pack/src/main/resources/modules/system/layers/base/org/apache/cxf/impl/main/module.xml: <module name="org.apache.xml-resolver" />
> feature-pack/src/main/resources/modules/system/layers/base/org/apache/cxf/main/module.xml: <module name="org.apache.xml-resolver" />
> feature-pack/src/main/resources/modules/system/layers/base/org/apache/cxf/services-sts/main/module.xml: <module name="org.apache.xml-resolver" />
> feature-pack/src/main/resources/modules/system/layers/base/org/apache/cxf/ws-security/main/module.xml: <module name="org.apache.xml-resolver" />
> {code}
> Moving it will tidy things up some and perhaps avoid any special handling for it as Galleon layers work continues.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-5217) Executable model compilation fails when binding a list from double square bracket
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-5217?page=com.atlassian.jira.plug... ]
Mario Fusco resolved DROOLS-5217.
---------------------------------
Resolution: Done
Fixed by https://github.com/kiegroup/drools/commit/a433c628b9a0c4853d9ea0b7e69fa9e...
> Executable model compilation fails when binding a list from double square bracket
> ---------------------------------------------------------------------------------
>
> Key: DROOLS-5217
> URL: https://issues.redhat.com/browse/DROOLS-5217
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.35.0.Final
> Reporter: Matteo Casalino
> Assignee: Mario Fusco
> Priority: Major
> Attachments: binding-list-from-double-square-bracket.zip
>
>
> Executable model rule compilation fails when trying to bind a _List_ from a double square bracket
> Example of DRL that fails to compile:
> {noformat}
> rule "binding field indexed with square brackets"
> when $boundList: java.util.List() from [[1,2,3]]
> Pojo($boundList.containsAll(integerList))
> then
> end
> {noformat}
> Error:
> {noformat}
> com.github.javaparser.ParseProblemException: Encountered unexpected token: "[" "["
> at line 1, column 1.
>
> Was expecting one of:
>
> "!"
> "("
> "+"
> "++"
> ...
> {noformat}
> The example works fine when compiling without executable model.
> We acknowledge that there are better and more efficient ways to achieve the same result as the above example, but there are perhaps other use-cases for the double square bracket mvel expression. As it is supported in DRL, should it be supported with executable model too?
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-5225) Constraint grouping fails with executable model
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-5225?page=com.atlassian.jira.plug... ]
Mario Fusco updated DROOLS-5225:
--------------------------------
Sprint: 2020 Week 13-15 (from Mar 23)
> Constraint grouping fails with executable model
> -----------------------------------------------
>
> Key: DROOLS-5225
> URL: https://issues.redhat.com/browse/DROOLS-5225
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.35.0.Final
> Reporter: Matteo Casalino
> Assignee: Mario Fusco
> Priority: Major
> Attachments: constraints-grouping.zip
>
>
> Executable model rule compilation fails when trying to build a pattern using constraint grouping.
> Example of DRL that fails to compile:
> {noformat}
> rule "TestBusiness"
> when $p : Pojo(departuretimedayofweek (== 1 || == 2 || == 7) )
> then
> end
> {noformat}
> Error:
> {noformat}
> java.lang.StackOverflowError
> at java.base/java.util.LinkedList.unlink(LinkedList.java:215)
> at java.base/java.util.LinkedList.remove(LinkedList.java:530)
> at com.github.javaparser.ast.Node.setParentNode(Node.java:389)
> at com.github.javaparser.ast.Node.setAsParentNodeOf(Node.java:403)
> at com.github.javaparser.ast.expr.BinaryExpr.setLeft(BinaryExpr.java:174)
> at com.github.javaparser.ast.expr.BinaryExpr.<init>(BinaryExpr.java:131)
> at com.github.javaparser.ast.expr.BinaryExpr.<init>(BinaryExpr.java:122)
> at org.drools.modelcompiler.builder.generator.DrlxParseUtil.trasformHalfBinaryToBinary(DrlxParseUtil.java:347)
> at org.drools.modelcompiler.builder.generator.expressiontyper.ExpressionTyper.toTypedExpressionRec(ExpressionTyper.java:194)
> at org.drools.modelcompiler.builder.generator.expressiontyper.ExpressionTyper.toTypedExpressionRec(ExpressionTyper.java:185)
> at org.drools.modelcompiler.builder.generator.expressiontyper.ExpressionTyper.toTypedExpressionRec(ExpressionTyper.java:195)
> at org.drools.modelcompiler.builder.generator.expressiontyper.ExpressionTyper.toTypedExpressionRec(ExpressionTyper.java:185)
> ...
> {noformat}
> The example works fine when compiling without executable model.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months
[JBoss JIRA] (DROOLS-5224) KieBase build fails with forall patterns containing "not equal" constraints on Dates
by Mario Fusco (Jira)
[ https://issues.redhat.com/browse/DROOLS-5224?page=com.atlassian.jira.plug... ]
Mario Fusco updated DROOLS-5224:
--------------------------------
Sprint: 2020 Week 13-15 (from Mar 23)
> KieBase build fails with forall patterns containing "not equal" constraints on Dates
> ------------------------------------------------------------------------------------
>
> Key: DROOLS-5224
> URL: https://issues.redhat.com/browse/DROOLS-5224
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Affects Versions: 7.33.0.Final, 7.34.0.Final, 7.35.0.Final
> Reporter: Matteo Casalino
> Assignee: Mario Fusco
> Priority: Major
> Attachments: forall-not-equal-constraint-on-dates.zip
>
>
> This is the same issue as https://issues.redhat.com/browse/DROOLS-5100, but on Dates.
> As of Drools 7.33.0.Final, forall patterns with "not equal" (!=) constraints on Dates will break when building the KieBase.
> For example the following DRL:
> {noformat}
> rule "forall with not equal"
> when forall(java.util.Date(this != "29-Dec-2019"))
> then
> end
> {noformat}
>
> generates the following error:
> {noformat}
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
>
> at java.lang.String.substring(String.java:1967)
> at org.drools.core.rule.constraint.MvelConstraint.getLeftInExpression(MvelConstraint.java:608)
> at org.drools.core.rule.constraint.MvelConstraint.hashCode(MvelConstraint.java:602)
> at org.drools.core.reteoo.AlphaNode.calculateHashCode(AlphaNode.java:189)
> at org.drools.core.reteoo.AlphaNode.<init>(AlphaNode.java:89)
> at org.drools.core.reteoo.builder.PhreakNodeFactory.buildAlphaNode(PhreakNodeFactory.java:88)
> at org.drools.core.reteoo.builder.PatternBuilder.buildAlphaNodeChain(PatternBuilder.java:360)
> at org.drools.core.reteoo.builder.PatternBuilder.attachAlphaNodes(PatternBuilder.java:346)
> at org.drools.core.reteoo.builder.PatternBuilder.attachPattern(PatternBuilder.java:136)
> at org.drools.core.reteoo.builder.PatternBuilder.build(PatternBuilder.java:84)
> at org.drools.core.reteoo.builder.GroupElementBuilder$NotBuilder.build(GroupElementBuilder.java:220)
> at org.drools.core.reteoo.builder.GroupElementBuilder.build(GroupElementBuilder.java:68)
> at org.drools.core.reteoo.builder.GroupElementBuilder$AndBuilder.build(GroupElementBuilder.java:108)
> at org.drools.core.reteoo.builder.GroupElementBuilder.build(GroupElementBuilder.java:68)
> at org.drools.core.reteoo.builder.ReteooRuleBuilder.addSubRule(ReteooRuleBuilder.java:167)
> at org.drools.core.reteoo.builder.ReteooRuleBuilder.addRule(ReteooRuleBuilder.java:139)
> at org.drools.core.reteoo.ReteooBuilder.addRule(ReteooBuilder.java:110)
> at org.drools.core.impl.KnowledgeBaseImpl.internalAddRule(KnowledgeBaseImpl.java:1525)
> at org.drools.core.impl.KnowledgeBaseImpl.internalAddPackages(KnowledgeBaseImpl.java:926)
> at org.drools.core.impl.KnowledgeBaseImpl.lambda$addPackages$2(KnowledgeBaseImpl.java:728)
> at org.drools.core.impl.KnowledgeBaseImpl.enqueueModification(KnowledgeBaseImpl.java:745)
> at org.drools.core.impl.KnowledgeBaseImpl.addPackages(KnowledgeBaseImpl.java:728)
> at org.drools.compiler.kie.builder.impl.AbstractKieModule.createKieBase(AbstractKieModule.java:226)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.createKieBase(KieContainerImpl.java:407)
> at org.drools.compiler.kie.builder.impl.KieContainerImpl.getKieBase(KieContainerImpl.java:375)
> {noformat}
> This is working fine when using Drools <= 7.32.0.Final.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 6 months