[JBoss JIRA] (WFWIP-312) [EAP7-1386] servletContext and servletConfig in config provider names are always null
by Petr Kremensky (Jira)
[ https://issues.redhat.com/browse/WFWIP-312?page=com.atlassian.jira.plugin... ]
Petr Kremensky resolved WFWIP-312.
----------------------------------
Resolution: Done
[~ron_sigal] Thanks again for a test coverage!
Verifying the issue:
{code}
3.12_2406 85f48041e [ronsigal/3.12_2406] Merge branch '3.12' into 3.12_2406
{code}
I've removed the reproducer, which was not reproducing the issue at all :) (one can use the test cases Ron authored to reproduce the issue)
> [EAP7-1386] servletContext and servletConfig in config provider names are always null
> -------------------------------------------------------------------------------------
>
> Key: WFWIP-312
> URL: https://issues.redhat.com/browse/WFWIP-312
> Project: WildFly WIP
> Issue Type: Quality Risk
> Reporter: Petr Kremensky
> Assignee: Ronald Sigal
> Priority: Major
>
> I've noticed that names of additional config sources provided by EAP7-1386 are always:
> {noformat}
> null:null:ServletConfigSource
> null:null:FilterConfigSource
> null:ServletContextConfigSource
> {noformat}
> I've tried to enhance the https://www.geeksforgeeks.org/difference-between-servletconfig-and-servle... example with MP config, to get the different names
> Servlet additions:
> {code:java}
> System.out.println("-------------------------------------");
> System.out.println("Servlet context name: " + getServletContext().getServletContextName());
> System.out.println("Servlet virtual server name: " + getServletContext().getVirtualServerName());
> System.out.println("Servlet name from servlet config: " + getServletConfig().getServletName());
> System.out.println("Servlet name: " + getServletName());
> System.out.println("Servlet info: " + getServletInfo());
> ConfigProvider.getConfig().getConfigSources().forEach(configSource -> {
> System.out.println("=================================");
> System.out.println(configSource.getName());
> System.out.println(configSource.getOrdinal());
> System.out.println("Property names: " + configSource.getPropertyNames().stream().collect(Collectors.joining(", ")));
> });
> System.out.println("-------------------------------------");
> {code}
> web.xml addition
> {code:xml}
> <web-app>
> + <display-name>test</display-name>
> ...
> {code}
> server output:
> {noformat}
> -------------------------------------
> Servlet context name: test
> Servlet virtual server name: default-host
> Servlet name from servlet config: recruiter
> Servlet name: recruiter
> Servlet info:
> =================================
> SysPropConfigSource
> 400
> Property names: [Standalone], awt.toolkit, java.specification.version ...
> =================================
> EnvConfigSource
> 300
> Property names: PATH, ...
> =================================
> null:null:ServletConfigSource
> 60
> Property names:
> =================================
> null:null:FilterConfigSource
> 50
> Property names:
> =================================
> null:ServletContextConfigSource
> 40
> Property names:
> -------------------------------------
> {noformat}
> Looking into sources https://github.com/resteasy/Resteasy/pull/2250/files#diff-c4301c90ec39134...
> {code:java}
> @Override
> public String getName() {
> if (name == null) {
> synchronized(this) {
> if (name == null) {
> ServletContext servletContext = ResteasyProviderFactory.getContextData(ServletContext.class);
> ServletConfig servletConfig = ResteasyProviderFactory.getContextData(ServletConfig.class);
> StringBuilder sb = new StringBuilder();
> name = sb.append(servletContext != null ? servletContext.getServletContextName() : null).append(":")
> .append(servletConfig != null ? servletConfig.getServletName() : null)
> .append(":ServletConfigSource").toString();
> }
> }
> }
> return name;
> }
> {code}
> My simple-minded expectation would be that the config sources name will use the fields provided in web.xml.
> *Reproduce:*
> * start standalone server
> * deploy [^source-names.war]
> * curl http://localhost:8080/source-names/servlet1
> * see server logs
> See [^source-names.zip] for sources.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5314) [DMN Designer] validation of included BKM invocation
by Jozef Marko (Jira)
Jozef Marko created DROOLS-5314:
-----------------------------------
Summary: [DMN Designer] validation of included BKM invocation
Key: DROOLS-5314
URL: https://issues.redhat.com/browse/DROOLS-5314
Project: Drools
Issue Type: Bug
Components: DMN Editor
Affects Versions: 7.37.0.Final
Reporter: Jozef Marko
Assignee: Guilherme Gomes
Attachments: MySpace_Traffic_Violation.zip
Issue found during DROOLS-5229 review however it is present also in master.
The issue is if user tries to invoke a BKM/function from included DMN model and alias of this model contain dots. In such case validation fails.
The attached Traffic Violation sample was artificially amended to demonstrate the issue. There were added two context entries (Comparison and Comparison-2) in the Should be the driver suspended. Both logically equal.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5313) Upgrading Drools Version from 6.2.0.Final to 7.31.0.Final
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5313?page=com.atlassian.jira.plug... ]
Kris Verlaenen updated DROOLS-5313:
-----------------------------------
Component/s: core engine
(was: build)
> Upgrading Drools Version from 6.2.0.Final to 7.31.0.Final
> ---------------------------------------------------------
>
> Key: DROOLS-5313
> URL: https://issues.redhat.com/browse/DROOLS-5313
> Project: Drools
> Issue Type: Quality Risk
> Components: core engine
> Reporter: Anuj Khare
> Assignee: Mario Fusco
> Priority: Blocker
>
> I am trying to upgrade below jars from 6.2.0.Final to 7.31.0.Final. Below are the issues am facing: 1. With 6.2.0.Final it takes 8 mins to compile all the rules, where as with 7.31.0.Final it takes nearly 40 mins 2. Some of the rules give wrong results when compiled with 7.31.0.Final
> Can some one help if and what needs to be taken care while upgrading drools jars. Jars am trying to upgrade are:
> org.drools.drools-compiler
> org.kie.kie-api
> org.jbpm.jbpm-flow
> org.jbpm.jbmpm-bpmn2
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5313) Upgrading Drools Version from 6.2.0.Final to 7.31.0.Final
by Kris Verlaenen (Jira)
[ https://issues.redhat.com/browse/DROOLS-5313?page=com.atlassian.jira.plug... ]
Kris Verlaenen reassigned DROOLS-5313:
--------------------------------------
Assignee: Mario Fusco (was: Kris Verlaenen)
> Upgrading Drools Version from 6.2.0.Final to 7.31.0.Final
> ---------------------------------------------------------
>
> Key: DROOLS-5313
> URL: https://issues.redhat.com/browse/DROOLS-5313
> Project: Drools
> Issue Type: Quality Risk
> Components: build
> Reporter: Anuj Khare
> Assignee: Mario Fusco
> Priority: Blocker
>
> I am trying to upgrade below jars from 6.2.0.Final to 7.31.0.Final. Below are the issues am facing: 1. With 6.2.0.Final it takes 8 mins to compile all the rules, where as with 7.31.0.Final it takes nearly 40 mins 2. Some of the rules give wrong results when compiled with 7.31.0.Final
> Can some one help if and what needs to be taken care while upgrading drools jars. Jars am trying to upgrade are:
> org.drools.drools-compiler
> org.kie.kie-api
> org.jbpm.jbpm-flow
> org.jbpm.jbmpm-bpmn2
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-312) [EAP7-1386] servletContext and servletConfig in config provider names are always null
by Petr Kremensky (Jira)
[ https://issues.redhat.com/browse/WFWIP-312?page=com.atlassian.jira.plugin... ]
Petr Kremensky updated WFWIP-312:
---------------------------------
Attachment: (was: source-names.zip)
> [EAP7-1386] servletContext and servletConfig in config provider names are always null
> -------------------------------------------------------------------------------------
>
> Key: WFWIP-312
> URL: https://issues.redhat.com/browse/WFWIP-312
> Project: WildFly WIP
> Issue Type: Quality Risk
> Reporter: Petr Kremensky
> Assignee: Ronald Sigal
> Priority: Major
>
> I've noticed that names of additional config sources provided by EAP7-1386 are always:
> {noformat}
> null:null:ServletConfigSource
> null:null:FilterConfigSource
> null:ServletContextConfigSource
> {noformat}
> I've tried to enhance the https://www.geeksforgeeks.org/difference-between-servletconfig-and-servle... example with MP config, to get the different names
> Servlet additions:
> {code:java}
> System.out.println("-------------------------------------");
> System.out.println("Servlet context name: " + getServletContext().getServletContextName());
> System.out.println("Servlet virtual server name: " + getServletContext().getVirtualServerName());
> System.out.println("Servlet name from servlet config: " + getServletConfig().getServletName());
> System.out.println("Servlet name: " + getServletName());
> System.out.println("Servlet info: " + getServletInfo());
> ConfigProvider.getConfig().getConfigSources().forEach(configSource -> {
> System.out.println("=================================");
> System.out.println(configSource.getName());
> System.out.println(configSource.getOrdinal());
> System.out.println("Property names: " + configSource.getPropertyNames().stream().collect(Collectors.joining(", ")));
> });
> System.out.println("-------------------------------------");
> {code}
> web.xml addition
> {code:xml}
> <web-app>
> + <display-name>test</display-name>
> ...
> {code}
> server output:
> {noformat}
> -------------------------------------
> Servlet context name: test
> Servlet virtual server name: default-host
> Servlet name from servlet config: recruiter
> Servlet name: recruiter
> Servlet info:
> =================================
> SysPropConfigSource
> 400
> Property names: [Standalone], awt.toolkit, java.specification.version ...
> =================================
> EnvConfigSource
> 300
> Property names: PATH, ...
> =================================
> null:null:ServletConfigSource
> 60
> Property names:
> =================================
> null:null:FilterConfigSource
> 50
> Property names:
> =================================
> null:ServletContextConfigSource
> 40
> Property names:
> -------------------------------------
> {noformat}
> Looking into sources https://github.com/resteasy/Resteasy/pull/2250/files#diff-c4301c90ec39134...
> {code:java}
> @Override
> public String getName() {
> if (name == null) {
> synchronized(this) {
> if (name == null) {
> ServletContext servletContext = ResteasyProviderFactory.getContextData(ServletContext.class);
> ServletConfig servletConfig = ResteasyProviderFactory.getContextData(ServletConfig.class);
> StringBuilder sb = new StringBuilder();
> name = sb.append(servletContext != null ? servletContext.getServletContextName() : null).append(":")
> .append(servletConfig != null ? servletConfig.getServletName() : null)
> .append(":ServletConfigSource").toString();
> }
> }
> }
> return name;
> }
> {code}
> My simple-minded expectation would be that the config sources name will use the fields provided in web.xml.
> *Reproduce:*
> * start standalone server
> * deploy [^source-names.war]
> * curl http://localhost:8080/source-names/servlet1
> * see server logs
> See [^source-names.zip] for sources.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-312) [EAP7-1386] servletContext and servletConfig in config provider names are always null
by Petr Kremensky (Jira)
[ https://issues.redhat.com/browse/WFWIP-312?page=com.atlassian.jira.plugin... ]
Petr Kremensky updated WFWIP-312:
---------------------------------
Attachment: (was: source-names.war)
> [EAP7-1386] servletContext and servletConfig in config provider names are always null
> -------------------------------------------------------------------------------------
>
> Key: WFWIP-312
> URL: https://issues.redhat.com/browse/WFWIP-312
> Project: WildFly WIP
> Issue Type: Quality Risk
> Reporter: Petr Kremensky
> Assignee: Ronald Sigal
> Priority: Major
>
> I've noticed that names of additional config sources provided by EAP7-1386 are always:
> {noformat}
> null:null:ServletConfigSource
> null:null:FilterConfigSource
> null:ServletContextConfigSource
> {noformat}
> I've tried to enhance the https://www.geeksforgeeks.org/difference-between-servletconfig-and-servle... example with MP config, to get the different names
> Servlet additions:
> {code:java}
> System.out.println("-------------------------------------");
> System.out.println("Servlet context name: " + getServletContext().getServletContextName());
> System.out.println("Servlet virtual server name: " + getServletContext().getVirtualServerName());
> System.out.println("Servlet name from servlet config: " + getServletConfig().getServletName());
> System.out.println("Servlet name: " + getServletName());
> System.out.println("Servlet info: " + getServletInfo());
> ConfigProvider.getConfig().getConfigSources().forEach(configSource -> {
> System.out.println("=================================");
> System.out.println(configSource.getName());
> System.out.println(configSource.getOrdinal());
> System.out.println("Property names: " + configSource.getPropertyNames().stream().collect(Collectors.joining(", ")));
> });
> System.out.println("-------------------------------------");
> {code}
> web.xml addition
> {code:xml}
> <web-app>
> + <display-name>test</display-name>
> ...
> {code}
> server output:
> {noformat}
> -------------------------------------
> Servlet context name: test
> Servlet virtual server name: default-host
> Servlet name from servlet config: recruiter
> Servlet name: recruiter
> Servlet info:
> =================================
> SysPropConfigSource
> 400
> Property names: [Standalone], awt.toolkit, java.specification.version ...
> =================================
> EnvConfigSource
> 300
> Property names: PATH, ...
> =================================
> null:null:ServletConfigSource
> 60
> Property names:
> =================================
> null:null:FilterConfigSource
> 50
> Property names:
> =================================
> null:ServletContextConfigSource
> 40
> Property names:
> -------------------------------------
> {noformat}
> Looking into sources https://github.com/resteasy/Resteasy/pull/2250/files#diff-c4301c90ec39134...
> {code:java}
> @Override
> public String getName() {
> if (name == null) {
> synchronized(this) {
> if (name == null) {
> ServletContext servletContext = ResteasyProviderFactory.getContextData(ServletContext.class);
> ServletConfig servletConfig = ResteasyProviderFactory.getContextData(ServletConfig.class);
> StringBuilder sb = new StringBuilder();
> name = sb.append(servletContext != null ? servletContext.getServletContextName() : null).append(":")
> .append(servletConfig != null ? servletConfig.getServletName() : null)
> .append(":ServletConfigSource").toString();
> }
> }
> }
> return name;
> }
> {code}
> My simple-minded expectation would be that the config sources name will use the fields provided in web.xml.
> *Reproduce:*
> * start standalone server
> * deploy [^source-names.war]
> * curl http://localhost:8080/source-names/servlet1
> * see server logs
> See [^source-names.zip] for sources.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (DROOLS-5313) Upgrading Drools Version from 6.2.0.Final to 7.31.0.Final
by Ant Stephenson (Jira)
[ https://issues.redhat.com/browse/DROOLS-5313?page=com.atlassian.jira.plug... ]
Ant Stephenson reassigned DROOLS-5313:
--------------------------------------
Assignee: Kris Verlaenen (was: Ant Stephenson)
> Upgrading Drools Version from 6.2.0.Final to 7.31.0.Final
> ---------------------------------------------------------
>
> Key: DROOLS-5313
> URL: https://issues.redhat.com/browse/DROOLS-5313
> Project: Drools
> Issue Type: Quality Risk
> Components: build
> Reporter: Anuj Khare
> Assignee: Kris Verlaenen
> Priority: Blocker
>
> I am trying to upgrade below jars from 6.2.0.Final to 7.31.0.Final. Below are the issues am facing: 1. With 6.2.0.Final it takes 8 mins to compile all the rules, where as with 7.31.0.Final it takes nearly 40 mins 2. Some of the rules give wrong results when compiled with 7.31.0.Final
> Can some one help if and what needs to be taken care while upgrading drools jars. Jars am trying to upgrade are:
> org.drools.drools-compiler
> org.kie.kie-api
> org.jbpm.jbpm-flow
> org.jbpm.jbmpm-bpmn2
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months