[JBoss JIRA] (DROOLS-5290) Executable model compiled throws exception in accumulate pattern matching
by Luca Molteni (Jira)
[ https://issues.redhat.com/browse/DROOLS-5290?page=com.atlassian.jira.plug... ]
Luca Molteni updated DROOLS-5290:
---------------------------------
Sprint: 2020 Week 22-24 (from May 25)
> Executable model compiled throws exception in accumulate pattern matching
> -------------------------------------------------------------------------
>
> Key: DROOLS-5290
> URL: https://issues.redhat.com/browse/DROOLS-5290
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Reporter: Luca Molteni
> Assignee: Luca Molteni
> Priority: Major
>
> Customer is encountering below issue while rule execution if they use executable model.
> {code:java}
> Exception in thread "main" java.lang.RuntimeException: java.lang.ClassCastException: org.drools.core.reteoo.SubnetworkTuple
> cannot be cast to java.lang.Long
> at org.drools.core.rule.SingleAccumulate.accumulate(SingleAccumulate.java:105)
> at org.drools.core.phreak.PhreakAccumulateNode.addMatch(PhreakAccumulateNode.java:714)
> at org.drools.core.phreak.PhreakAccumulateNode.doLeftInserts(PhreakAccumulateNode.java:168)
> at org.drools.core.phreak.PhreakAccumulateNode.doNode(PhreakAccumulateNode.java:89)
> at org.drools.core.phreak.RuleNetworkEvaluator.switchOnDoBetaNode(RuleNetworkEvaluator.java:581)
> at org.drools.core.phreak.RuleNetworkEvaluator.evalBetaNode(RuleNetworkEvaluator.java:552)
> at org.drools.core.phreak.RuleNetworkEvaluator.evalNode(RuleNetworkEvaluator.java:379)
> at org.drools.core.phreak.RuleNetworkEvaluator.innerEval(RuleNetworkEvaluator.java:339)
> at org.drools.core.phreak.RuleNetworkEvaluator.evalStackEntry(RuleNetworkEvaluator.java:237)
> at org.drools.core.phreak.RuleNetworkEvaluator.outerEval(RuleNetworkEvaluator.java:180)
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ELY-1971) Bad designed wildlfy-elytron jar, shaded jar with dependencies
by Marek Novotny (Jira)
[ https://issues.redhat.com/browse/ELY-1971?page=com.atlassian.jira.plugin.... ]
Marek Novotny commented on ELY-1971:
------------------------------------
ok, thanks [~dlofthouse] for explanation. Is there already a BOM or possible dependency chain to use instead of wildfly-elytron?
> Bad designed wildlfy-elytron jar, shaded jar with dependencies
> --------------------------------------------------------------
>
> Key: ELY-1971
> URL: https://issues.redhat.com/browse/ELY-1971
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Marek Novotny
> Priority: Minor
>
> Wildfly-elytron jar is shaded with all wildfly elytron modules + jboss-logging, but it keeps the shaded classes in jar in its dependency chain which makes duplicated classes in dependency tree when using the wildfly-elytron in maven project.
> Avoiding duplicates would effectively need to add exclusion dependency to wildfly-elytron like:
> {noformat}
> <dependency>
> <groupId>org.wildlfy.security</groupId>
> <artifactId>wildfly-elytron</artifactId>
> <version>some-version</version>
> <exclusions>
> <exclusion>
> <groupId>*</groupId>
> <artifactId>*</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (ELY-1971) Bad designed wildlfy-elytron jar, shaded jar with dependencies
by Marek Novotny (Jira)
[ https://issues.redhat.com/browse/ELY-1971?page=com.atlassian.jira.plugin.... ]
Marek Novotny edited comment on ELY-1971 at 5/25/20 4:11 AM:
-------------------------------------------------------------
ok, thanks [~dlofthouse] for explanation. Is there already a BOM or possible dependency chain to use instead of wildfly-elytron?
Documentation ref link would help too if you have it ;)
was (Author: manarh):
ok, thanks [~dlofthouse] for explanation. Is there already a BOM or possible dependency chain to use instead of wildfly-elytron?
> Bad designed wildlfy-elytron jar, shaded jar with dependencies
> --------------------------------------------------------------
>
> Key: ELY-1971
> URL: https://issues.redhat.com/browse/ELY-1971
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Marek Novotny
> Priority: Minor
>
> Wildfly-elytron jar is shaded with all wildfly elytron modules + jboss-logging, but it keeps the shaded classes in jar in its dependency chain which makes duplicated classes in dependency tree when using the wildfly-elytron in maven project.
> Avoiding duplicates would effectively need to add exclusion dependency to wildfly-elytron like:
> {noformat}
> <dependency>
> <groupId>org.wildlfy.security</groupId>
> <artifactId>wildfly-elytron</artifactId>
> <version>some-version</version>
> <exclusions>
> <exclusion>
> <groupId>*</groupId>
> <artifactId>*</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
> {noformat}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (WFLY-13422) Make org.jboss.as.remoting optional from naming extension module; others too if possible
by Yeray Borges Santana (Jira)
[ https://issues.redhat.com/browse/WFLY-13422?page=com.atlassian.jira.plugi... ]
Yeray Borges Santana commented on WFLY-13422:
---------------------------------------------
{{org.wildfly.http-client.naming}} is required not only by {{RemoteNamingServerService}} but also by {{org.jboss.as.naming.InitialContext}}, which is created by {{InitialContextFactory}}, which is indeed a public class with a public method. I would say taht removes the possibility to make it optional.
> Make org.jboss.as.remoting optional from naming extension module; others too if possible
> ----------------------------------------------------------------------------------------
>
> Key: WFLY-13422
> URL: https://issues.redhat.com/browse/WFLY-13422
> Project: WildFly
> Issue Type: Enhancement
> Components: Naming
> Reporter: Brian Stansberry
> Assignee: Yeray Borges Santana
> Priority: Major
>
> The org.jboss.as.naming module's dependency on org.jboss.as.remoting is only needed if the "service=remote-naming" child resource is used. So it should be made optional with RemoteNamingResourceDefinition registering an additional package.
> This is part of an overall effort to eliminate non-optional dependencies on the org.jboss.as.remoting module. Both because depending on extension modules has a code smell but specifically because org.jboss.as.remoting module brings in fairly large dependency tree.
> I believe there may be other module dependencies that could be made optional as part of this same work, e.g. org.jboss.remoting and org.wildfly.http-client.naming. Maybe others.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (DROOLS-5360) Replace KiePMMLModel with modelname in PMMLModelExecutor.evaluate
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5360?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-5360:
-------------------------------------
Labels: TrustyAI (was: )
> Replace KiePMMLModel with modelname in PMMLModelExecutor.evaluate
> ------------------------------------------------------------------
>
> Key: DROOLS-5360
> URL: https://issues.redhat.com/browse/DROOLS-5360
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: TrustyAI
>
> Change PMMLModelExecutor public API so that user should not retrieve the KiePMMLModel to invoke the "evaluate" method
> {code:java}
> PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)
> {code}
> ->
> {code:java}
> PMML4Result evaluate(final KieBase knowledgeBase, String modelName, PMMLContext context);
> {code}
> Create AbstractPMMLModelExecutor that implement the above interface and declare an abstract method
> {code:java}
> PMML4Result evaluate(final KieBase knowledgeBase, KiePMMLModel model, PMMLContext context)
> {code}
> AbstractPMMLModelExecutor should then use KnoweledgeBaseUtils to retrieve the KiePMMLModel and invoke/delegate to actual implementations
> Actual implementations should then extend AbstractPMMLModelExecutor
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month
[JBoss JIRA] (DROOLS-5367) Manage missing model name during kiepmmlmodel generation/instantiation
by Gabriele Cardosi (Jira)
Gabriele Cardosi created DROOLS-5367:
----------------------------------------
Summary: Manage missing model name during kiepmmlmodel generation/instantiation
Key: DROOLS-5367
URL: https://issues.redhat.com/browse/DROOLS-5367
Project: Drools
Issue Type: Task
Reporter: Gabriele Cardosi
Assignee: Gabriele Cardosi
Current code is written with the assumption that model name is provided by all model definitions.
That is not enforced by the specification itself, so we need to provide a way to generate a predictable model name.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 1 month