[JBoss JIRA] (WFCORE-4674) Custom handlers, formatters and filters cause the server to crash if the log manager is on the boot class path
by Francisco De Melo Junior (Jira)
[ https://issues.redhat.com/browse/WFCORE-4674?page=com.atlassian.jira.plug... ]
Francisco De Melo Junior edited comment on WFCORE-4674 at 8/11/20 10:22 AM:
----------------------------------------------------------------------------
Hey guys, was this tested/QA? I couldn't find it here. If that's the case is it in Wildfly 18 or 21?
was (Author: francisco.melojr):
Hey guys, was this tested/QA? I couldn't find it here. If that's the case is it in EAP 7.3?
> Custom handlers, formatters and filters cause the server to crash if the log manager is on the boot class path
> --------------------------------------------------------------------------------------------------------------
>
> Key: WFCORE-4674
> URL: https://issues.redhat.com/browse/WFCORE-4674
> Project: WildFly Core
> Issue Type: Bug
> Components: Logging
> Reporter: James Perkins
> Assignee: James Perkins
> Priority: Critical
> Labels: OpenShift, jdk11
> Fix For: 13.0.0.Beta1
>
>
> If the log manager is on the boot class path with Java 11, {{-Xbootclasspath/a:jboss-logmanager.jar}}, and a custom handler, formatter or filter is used the server will fail to boot as the log manager can't see the types in jboss-modules. This seems due to the fact that the log manager is on the boot class path and jboss-modules is on the system class path.
> Example exception:
> {code}
> Failed to read or configure the org.jboss.logmanager.LogManager
> java.lang.IllegalArgumentException: Failed to load module "org.jboss.logmanager" for formatter "JSON"
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:65)
> at org.jboss.logmanager.config.FormatterConfigurationImpl.<init>(FormatterConfigurationImpl.java:30)
> at org.jboss.logmanager.config.LogContextConfigurationImpl.addFormatterConfiguration(LogContextConfigurationImpl.java:172)
> at org.jboss.logmanager.PropertyConfigurator.configureFormatter(PropertyConfigurator.java:631)
> at org.jboss.logmanager.PropertyConfigurator.configureHandler(PropertyConfigurator.java:701)
> at org.jboss.logmanager.PropertyConfigurator.configureLogger(PropertyConfigurator.java:583)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:521)
> at org.jboss.logmanager.PropertyConfigurator.configure(PropertyConfigurator.java:97)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:170)
> at org.jboss.logmanager.LogManager.readConfiguration(LogManager.java:132)
> at java.util.logging.LogManager$3.run(LogManager.java:399)
> at java.util.logging.LogManager$3.run(LogManager.java:396)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.readPrimordialConfiguration(LogManager.java:396)
> at java.util.logging.LogManager.access$800(LogManager.java:145)
> at java.util.logging.LogManager$2.run(LogManager.java:345)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.util.logging.LogManager.ensureLogManagerInitialized(LogManager.java:338)
> at java.util.logging.LogManager.getLogManager(LogManager.java:378)
> at org.jboss.modules.Main.main(Main.java:523)
> Caused by: java.lang.NoClassDefFoundError: org/jboss/modules/ModuleLoader
> at org.jboss.logmanager.config.AbstractPropertyConfiguration$ModuleFinder.getClassLoader(AbstractPropertyConfiguration.java:556)
> at org.jboss.logmanager.config.AbstractPropertyConfiguration.<init>(AbstractPropertyConfiguration.java:63)
> ... 19 more
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (ELY-1745) The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
by Martin Mazánek (Jira)
[ https://issues.redhat.com/browse/ELY-1745?page=com.atlassian.jira.plugin.... ]
Martin Mazánek reassigned ELY-1745:
-----------------------------------
Assignee: Martin Mazánek
> The AvailableRealmsCallback should not result in a NPE if there is no mechanism configuration.
> ----------------------------------------------------------------------------------------------
>
> Key: ELY-1745
> URL: https://issues.redhat.com/browse/ELY-1745
> Project: WildFly Elytron
> Issue Type: Bug
> Components: API / SPI
> Reporter: Darran Lofthouse
> Assignee: Martin Mazánek
> Priority: Major
> Fix For: 1.13.0.CR4
>
>
> The NPE is due to the following code: -
> {noformat}
> } else if (callback instanceof AvailableRealmsCallback) {
> Collection<String> names = stateRef.get().getMechanismConfiguration().getMechanismRealmNames();
> if (log.isTraceEnabled()) {
> log.tracef("Handling AvailableRealmsCallback: realms = [%s]", String.join(", ", names));
> }
> if (! names.isEmpty()) {
> ((AvailableRealmsCallback) callback).setRealmNames(names.toArray(new String[names.size()]));
> }
> handleOne(callbacks, idx + 1);
> {noformat}
> If mechanism configuration is mandatory this should report an appropriate error, if not it should fallback to specifying an empty list.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (JGRP-2470) JBDC_PING can face a split-brain issue when restarting a coordinator node
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2470?page=com.atlassian.jira.plugin... ]
Bela Ban commented on JGRP-2470:
--------------------------------
OK, so {{removeAll()}} is only called when {{is_coord}} is true. So I suggest instead to set {{is_coord}} to false in {{super.stop()}} ({{Discovery}}). This is in line with setting {{is_server}} to false in {{Discovery}}.
Testing...
> JBDC_PING can face a split-brain issue when restarting a coordinator node
> -------------------------------------------------------------------------
>
> Key: JGRP-2470
> URL: https://issues.redhat.com/browse/JGRP-2470
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 4.1.9, 4.0.22
> Reporter: Masafumi Miura
> Assignee: Radoslav Husar
> Priority: Major
> Fix For: 4.2.5
>
>
> After [the change|https://github.com/belaban/JGroups/commit/215cdb6] for JGRP-2199, JDBC_PING deletes all entries from the table during the shutdown of the coordinator node.
> This behavior has a possibility to cause a split-brain when restarting a coordinator node. Because, as all entries are lost in the following scenario, the restarting node can not find any information about existing nodes from the table and does not form a cluster.
> 0. node1 and node2 form a cluster. The node1 is a coordinator.
> 1. Trigger a restart of the node1
> 2. The node1 removes their node information from the table
> 3. The node2 becomes a new coordinator
> 4. The node2 updates their node information in the table
> 5. The node1 clears all entries from the table
> 6. The node1 starts again
> 7. The node1 does not join the existing cluster because there's no node information in the table
> Note: If step 5 happens before step 4, the split-brain issue does not happen. However, as step 4 and step 5 happen on different nodes, these steps can happen in parallel. So, the order is undefined. So, for example, if the shutdown of node1 takes a long time, there's a high possibility to face this issue.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months
[JBoss JIRA] (DROOLS-5571) Change KiePmmlModel name generation
by Gabriele Cardosi (Jira)
Gabriele Cardosi created DROOLS-5571:
----------------------------------------
Summary: Change KiePmmlModel name generation
Key: DROOLS-5571
URL: https://issues.redhat.com/browse/DROOLS-5571
Project: Drools
Issue Type: Task
Reporter: Gabriele Cardosi
Assignee: Gabriele Cardosi
Currently, name of generated classes depends on KiePMMLModel name that, in turns, depends on (original) Model name.
This name may be missing (it is auto-generated) but it seems the same model name could be used inside different models in the same PMML file, at least inside nested Segments of MiningModel.
This lead to class clashes at evaluation time.
The current workaround is to ensure no models share the same model name (but this is not needed in jpmml).
To allow unique name generation, KiePMMLModel name must be created out of original file name and a different identifier strategy (index ?).
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 11 months