January 2021 - jboss-jira - Jboss List Archives

[Red Hat JIRA] (WFCORE-5253) Incorrect use of 'operation' instead of Resource in the remoting subsystem

by Brian Stansberry (Jira)

[ https://issues.redhat.com/browse/WFCORE-5253?page=com.atlassian.jira.plug... ] Brian Stansberry updated WFCORE-5253: ------------------------------------- Description: Some of the OperationStepHandler impls in the remoting subsystem are reading the data they provide to runtime services from the current operation instead of reading from the current configuration model. As part of cleaning this up I'll do some conversion of reads of the current address from extracting it from the 'operation' model node to the modern idiom of using OperationContext.getCurrentAddress[Value](). I'll also convert to AttributeDefinition.resolveModelAttribute in a couple places where not-incorrect but non-standard idioms are used. was: Some of the OperationStepHandler impls in the remoting subsystem are reading the data the provide to runtime services from the current operation instead of reading from the current configuration model. As part of cleaning this up I'll do some conversion of reads of the current address from extracting it from the 'operation' model node to the modern idiom of using OperationContext.getCurrentAddress[Value](). I'll also convert to AttributeDefinition.resolveModelAttribute in a couple places where not-incorrect but non-standard idioms are used. > Incorrect use of 'operation' instead of Resource in the remoting subsystem > -------------------------------------------------------------------------- > > Key: WFCORE-5253 > URL: https://issues.redhat.com/browse/WFCORE-5253 > Project: WildFly Core > Issue Type: Bug > Components: Remoting > Reporter: Brian Stansberry > Assignee: Brian Stansberry > Priority: Major > > Some of the OperationStepHandler impls in the remoting subsystem are reading the data they provide to runtime services from the current operation instead of reading from the current configuration model. > As part of cleaning this up I'll do some conversion of reads of the current address from extracting it from the 'operation' model node to the modern idiom of using OperationContext.getCurrentAddress[Value](). > I'll also convert to AttributeDefinition.resolveModelAttribute in a couple places where not-incorrect but non-standard idioms are used. -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFCORE-5253) Incorrect use of 'operation' instead of Resource in the remoting subsystem

by Brian Stansberry (Jira)

Brian Stansberry created WFCORE-5253: ---------------------------------------- Summary: Incorrect use of 'operation' instead of Resource in the remoting subsystem Key: WFCORE-5253 URL: https://issues.redhat.com/browse/WFCORE-5253 Project: WildFly Core Issue Type: Bug Components: Remoting Reporter: Brian Stansberry Assignee: Brian Stansberry Some of the OperationStepHandler impls in the remoting subsystem are reading the data the provide to runtime services from the current operation instead of reading from the current configuration model. As part of cleaning this up I'll do some conversion of reads of the current address from extracting it from the 'operation' model node to the modern idiom of using OperationContext.getCurrentAddress[Value](). I'll also convert to AttributeDefinition.resolveModelAttribute in a couple places where not-incorrect but non-standard idioms are used. -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14351) Use resolveModelAttribute when reading the XTSSubsystemDefinition.DEFAULT_CONTEXT_PROPAGATION value for runtime use

by Brian Stansberry (Jira)

Brian Stansberry created WFLY-14351: --------------------------------------- Summary: Use resolveModelAttribute when reading the XTSSubsystemDefinition.DEFAULT_CONTEXT_PROPAGATION value for runtime use Key: WFLY-14351 URL: https://issues.redhat.com/browse/WFLY-14351 Project: WildFly Issue Type: Sub-task Reporter: Brian Stansberry Assignee: Brian Stansberry Small code style thing. XTSSubsystemAdd.performBoottime is not using AttributeDefinition.resolveModelAttribute when reading the model for XTSSubsystemDefinition.DEFAULT_CONTEXT_PROPAGATION. This does no harm, as the attribute neither supports expression nor has a default value (see parent issue.) But it's better if we follow the KISS principle and apply the standard idiom without exception. -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14350) XTSSubsystemDefinition.DEFAULT_CONTEXT_PROPAGATION should allow expressions and have default value

by Brian Stansberry (Jira)

Brian Stansberry created WFLY-14350: --------------------------------------- Summary: XTSSubsystemDefinition.DEFAULT_CONTEXT_PROPAGATION should allow expressions and have default value Key: WFLY-14350 URL: https://issues.redhat.com/browse/WFLY-14350 Project: WildFly Issue Type: Bug Components: XTS Reporter: Brian Stansberry Assignee: Ondrej Chaloupka The XTS subsystem is deprecated so this is optional; I'm just recording it in case a decision is made to keep it for the long term. XTSSubsystemDefinition.DEFAULT_CONTEXT_PROPAGATION is a basic boolean attribute so there is no reason it should not support expressions. If it has no value the runtime service integration uses 'false' so that means false is the default value. The AttributeDefinition should reflect this so the read-resource-description output does. -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14296) Reenable ignored metrics tests

by Brian Stansberry (Jira)

[ https://issues.redhat.com/browse/WFLY-14296?page=com.atlassian.jira.plugi... ] Brian Stansberry reassigned WFLY-14296: --------------------------------------- Assignee: Jason Lee (was: Brian Stansberry) > Reenable ignored metrics tests > ------------------------------ > > Key: WFLY-14296 > URL: https://issues.redhat.com/browse/WFLY-14296 > Project: WildFly > Issue Type: Task > Components: MP Metrics > Reporter: Kabir Khan > Assignee: Jason Lee > Priority: Blocker > Fix For: 23.0.0.Beta1 > > > https://issues.redhat.com/browse/WFLY-14206 / https://github.com/wildfly/wildfly/pull/13883 ignores a test. We need to reenable this before WF23 -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14349) Enhance the datasource documentation to better cover basic DS addition

by Brian Stansberry (Jira)

Brian Stansberry created WFLY-14349: --------------------------------------- Summary: Enhance the datasource documentation to better cover basic DS addition Key: WFLY-14349 URL: https://issues.redhat.com/browse/WFLY-14349 Project: WildFly Issue Type: Enhancement Components: JCA Reporter: Brian Stansberry Assignee: Tomasz Adamski The https://docs.wildfly.org/22/Admin_Guide.html#DataSource doc could use some improvement. The biggest thing is it should walk through a complete example of adding a datasource. Right now it notes the 'data-source' CLI command and tells you you can use --help. That's good to know but there should be an example of using 'datasource add'. Other inputs in no particular order of importance: 1) 'Any JDBC 4-compliant driver will automatically be recognized and installed into the system by name and version. A JDBC JAR is identified using the Java service provider mechanism. Such JARs will contain a text a file named META-INF/services/java.sql.Driver, which contains the name of the class(es) of the Drivers which exist in that JAR. If your JDBC driver JAR is not JDBC 4-compliant, it can be made deployable in one of a few ways.' -- The last sentence should be a separate paragraph as it's the beginning of a separate subtopic, one that is a distraction for many readers. 2) The 'For a detailed explanation how to deploy JDBC 4 compliant driver jar, please refer to the chapter "Application Deployment"' text in the driver section should be moved before the discussion of non-JDBC4 compliant jars. It's more important info for a typical non-expert user. Also, I suggest a bit more words. 'A JDBC 4 compliant driver jar can be deployed using the CLI, the HAL management console or by copying the jar to the standalone/deployments directory. For a detailed explanation how to deploy a driver jar, please refer to the chapter "Application Deployment".' 3) The 'Datasource Definitions' section includes CLI output of the installed-drivers-list operation. That should be in the previous section, and the example output should include a driver installed as a deployment, not just h2. (Which implies the previous section should include an example CLI command deploying a driver.) 4) Add an actual example of using 'data-source add' -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14348) Unhelpful failure message 'WFLYJCA0032: Unable to start the ds because it generated more than one cf'

by Brian Stansberry (Jira)

Brian Stansberry created WFLY-14348: --------------------------------------- Summary: Unhelpful failure message 'WFLYJCA0032: Unable to start the ds because it generated more than one cf' Key: WFLY-14348 URL: https://issues.redhat.com/browse/WFLY-14348 Project: WildFly Issue Type: Bug Components: JCA Reporter: Brian Stansberry Assignee: Tomasz Adamski Playing with driver and DS installation I ended up with this in the server log: {code} 10:54:11,424 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 1) WFLYCTL0013: Operation ("add") failed - address: ([ ("subsystem" => "datasources"), ("data-source" => "Postgres") ]) - failure description: {"WFLYCTL0080: Failed services" => {"org.wildfly.data-source.Postgres" => "WFLYJCA0033: Error during the deployment of Postgres Caused by: org.jboss.msc.service.StartException in anonymous service: WFLYJCA0032: Unable to start the ds because it generated more than one cf"}} {code} That was quite cryptic. 1) The 'ds' and 'cf' abbreviations should be replaced with full words. To me this is the minimum resolution of this issue. 2) If it is possible to make a reasonably likely guess at what would lead to this situation and provide that info in the message, that would be nice. Context: I tried deploying a JDBC driver and then adding a datasource using a CLI command: {code} data-source add --name=Postgres --driver-name=postgresql-42.2.18.jar --jndi-name=java:jboss/datasources/Postgres {code} The 3 params are the required ones. I wasn't surprised that wasn't sufficient and I understand that what's required beyond that can vary from driver to driver. But those are the required ones, so users experimenting with WildFly are liable to do what I did. (If any other params *should be* required, someone please file a separate issue.) Adding a connection-url param allowed the command to work. If that param shouldn't be required, but not providing it is a likely cause of this problem, perhaps the WFLYJCA0032 message should note that as a hint? -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14347) Allow to configure module for custom validation classes

by Tomasz Adamski (Jira)

Tomasz Adamski created WFLY-14347: ------------------------------------- Summary: Allow to configure module for custom validation classes Key: WFLY-14347 URL: https://issues.redhat.com/browse/WFLY-14347 Project: WildFly Issue Type: Feature Request Components: JCA Reporter: Tomasz Adamski Assignee: Tomasz Adamski -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14346) IIOPSubsystemAdd processes a non-existent 'configuration' model node

by Brian Stansberry (Jira)

Brian Stansberry created WFLY-14346: --------------------------------------- Summary: IIOPSubsystemAdd processes a non-existent 'configuration' model node Key: WFLY-14346 URL: https://issues.redhat.com/browse/WFLY-14346 Project: WildFly Issue Type: Bug Components: IIOP Reporter: Brian Stansberry Assignee: Tomasz Adamski https://github.com/wildfly/wildfly/blob/master/iiop-openjdk/src/main/java... This code processes a 'configuration' attribute in the subsystem's root resource, but there is no such attribute, nor is there any child resource with that name. JacORBSubsystemAdd extends IIOPSubsystemAdd, but the Jacorb subsystem doesn't have such an attribute or child either. -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

[Red Hat JIRA] (WFLY-14343) Webservices subsystem PropertyAdd may invalidly store 'undefined' as the property value

by Brian Stansberry (Jira)

[ https://issues.redhat.com/browse/WFLY-14343?page=com.atlassian.jira.plugi... ] Brian Stansberry updated WFLY-14343: ------------------------------------ Priority: Minor (was: Major) > Webservices subsystem PropertyAdd may invalidly store 'undefined' as the property value > --------------------------------------------------------------------------------------- > > Key: WFLY-14343 > URL: https://issues.redhat.com/browse/WFLY-14343 > Project: WildFly > Issue Type: Bug > Components: Web Services > Reporter: Brian Stansberry > Assignee: Jim Ma > Priority: Minor > > If an operation has the 'value' param but does not have a defined value, PropertyAdd will pass the string 'undefined' into the runtime service. It should pass null. -- This message was sent by Atlassian Jira (v8.13.1#813001)

5 years, 2 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira January 2021