[Red Hat JIRA] (ELY-2020) Revisit code style for tool / CredentialStoreCommand
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/ELY-2020?page=com.atlassian.jira.plugin.... ]
Darran Lofthouse resolved ELY-2020.
-----------------------------------
Resolution: Duplicate Issue
> Revisit code style for tool / CredentialStoreCommand
> ----------------------------------------------------
>
> Key: ELY-2020
> URL: https://issues.redhat.com/browse/ELY-2020
> Project: WildFly Elytron
> Issue Type: Task
> Components: Command-Line Tool
> Affects Versions: 1.13.0.CR4
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Priority: Major
>
> This should probably wait until after ELY-1842 as refactoring before will cause more problems.
> Working on ELY-1842 another engineer has also worked on an RFE for different reasons to adjust the credential store, the current code has a long method building up with the options for the command line - if multiple engineers work on this code it leads to conflicts easily but is also hard to unravel to correct the conflicts.
> As the scope of CredentialStoreCommand has expanded since it's original implementation which was very tightly constrained we probably need to break this up into more logical chunks, also many variables just have a very short name which keeps the code concise but if you have not bee in the code for a while it is hard to see the purpose of each variable to we should expand the variable names to be more meaningful.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-5193) Implement Listener mechanism to trace execution
by Gabriele Cardosi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5193?page=com.atlassian.jira.plug... ]
Gabriele Cardosi updated DROOLS-5193:
-------------------------------------
Sprint: 2020 Week 13-15 (from Mar 23), 2020 Week 16-18 (from Apr 13), 2020 Week 19-21 (from May 4), 2020 Week 22-24 (from May 25), 2020 Week 25-27 (from Jun 15), 2020 Week 28-30 (from Jul 6), 2020 Week 31-33 (from Jul 27), 2020 Week 34-36 (from Aug 17), 2020 Week 37-39 (from Sep 7), 2020 Week 40-42 (from Sep 28), 2020 Week 43-45 (from Okt 19), 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21) (was: 2020 Week 13-15 (from Mar 23), 2020 Week 16-18 (from Apr 13), 2020 Week 19-21 (from May 4), 2020 Week 22-24 (from May 25), 2020 Week 25-27 (from Jun 15), 2020 Week 28-30 (from Jul 6), 2020 Week 31-33 (from Jul 27), 2020 Week 34-36 (from Aug 17), 2020 Week 37-39 (from Sep 7), 2020 Week 40-42 (from Sep 28), 2020 Week 43-45 (from Okt 19), 2020 Week 46-48 (from Nov 9), 2020 Week 49-51 (from Nov 30), 2020 Week 52-03 (from Dec 21), 2021 Week 04-06 (from Jan 25))
> Implement Listener mechanism to trace execution
> -----------------------------------------------
>
> Key: DROOLS-5193
> URL: https://issues.redhat.com/browse/DROOLS-5193
> Project: Drools
> Issue Type: Task
> Reporter: Gabriele Cardosi
> Assignee: Gabriele Cardosi
> Priority: Major
> Labels: TrustyAI
>
> Implement Listener architecture so that model-implementation may "publish" execution step detail to be read by "listening" code.
> Implementation should not be mandatory, i.e. model should not be forced to implement it.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (WFCORE-4970) Changing the JVM settings at host level does not put the servers in restart-required
by Yeray Borges Santana (Jira)
[ https://issues.redhat.com/browse/WFCORE-4970?page=com.atlassian.jira.plug... ]
Yeray Borges Santana commented on WFCORE-4970:
----------------------------------------------
Hello [~parsharma], thanks for looking at this.
{quote}RESTART_JVM neither the CI test is failing.
{quote}
I understand you have changed all the JvmAttributes and verified that there are no CI errors, can you confirm whether I am understanding it correctly? If so, it would be great to have a CI job link.
In general, yes the fix should be that one, adding that flag to those attributes. However, as Brian pointed out before, it is very important to have pretty clear where those attributes are being used because they could be used by different management operations on different resources. Before proceeding with these changes we need to have pretty clear which operations are using these attributes, and then we need to verify that the execution of those operations requires a restart of the JVM that is being administered.
To continue progressing on this, we could have here, in this Jira as a commentary, a list of all the resources where we can be using these JvmAttributes in management operations. Sadly, I thought this issue was easier, but as we have discovered, it will require an amount of concise work analyzing the code and documenting its uses first.
> Changing the JVM settings at host level does not put the servers in restart-required
> ------------------------------------------------------------------------------------
>
> Key: WFCORE-4970
> URL: https://issues.redhat.com/browse/WFCORE-4970
> Project: WildFly Core
> Issue Type: Bug
> Components: Management
> Affects Versions: 12.0.0.Beta2
> Reporter: Yeray Borges Santana
> Assignee: Parul Sharma
> Priority: Major
>
> Operations like the following one should put the servers in restart required to indicate the user changes will be applied after restarting the servers:
> {noformat}
> [domain@localhost:9990 /] /host=master/jvm=default:write-attribute(name=heap-size, value=256m)
> {
> "outcome" => "success",
> "result" => undefined,
> "server-groups" => undefined
> }
> {noformat}
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-5826) executable-model test failure in test-compiler-integration PropertySpecificTest
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5826?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi updated DROOLS-5826:
--------------------------------------
Description:
*Probably the same issue as DROOLS-5818* (I'll revisit later)
org.drools.mvel.integrationtests.PropertySpecificTest in test-compiler-integration fails with some tests when executable-model is enabled. See TODO comment in the test class. Once fixed (or the test failure is justified), we can remove the TODO comment and let the test run with executable-model.
Currently, executable-model is disabled:
{code:java}
// TODO: ....
return TestParametersUtil.getKieBaseCloudConfigurations(false);
{code}
If the test failure contains multiple bugs, we may split this JIRA into multiple JIRAs.
was:
*Probably the same issue as DROOLS-5818*
org.drools.mvel.integrationtests.PropertySpecificTest in test-compiler-integration fails with some tests when executable-model is enabled. See TODO comment in the test class. Once fixed (or the test failure is justified), we can remove the TODO comment and let the test run with executable-model.
Currently, executable-model is disabled:
{code:java}
// TODO: ....
return TestParametersUtil.getKieBaseCloudConfigurations(false);
{code}
If the test failure contains multiple bugs, we may split this JIRA into multiple JIRAs.
> executable-model test failure in test-compiler-integration PropertySpecificTest
> -------------------------------------------------------------------------------
>
> Key: DROOLS-5826
> URL: https://issues.redhat.com/browse/DROOLS-5826
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.46.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
>
> *Probably the same issue as DROOLS-5818* (I'll revisit later)
> org.drools.mvel.integrationtests.PropertySpecificTest in test-compiler-integration fails with some tests when executable-model is enabled. See TODO comment in the test class. Once fixed (or the test failure is justified), we can remove the TODO comment and let the test run with executable-model.
> Currently, executable-model is disabled:
> {code:java}
> // TODO: ....
> return TestParametersUtil.getKieBaseCloudConfigurations(false);
> {code}
> If the test failure contains multiple bugs, we may split this JIRA into multiple JIRAs.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months
[Red Hat JIRA] (DROOLS-5826) executable-model test failure in test-compiler-integration PropertySpecificTest
by Toshiya Kobayashi (Jira)
[ https://issues.redhat.com/browse/DROOLS-5826?page=com.atlassian.jira.plug... ]
Toshiya Kobayashi updated DROOLS-5826:
--------------------------------------
Description:
*Probably the same issue as DROOLS-5818*
org.drools.mvel.integrationtests.PropertySpecificTest in test-compiler-integration fails with some tests when executable-model is enabled. See TODO comment in the test class. Once fixed (or the test failure is justified), we can remove the TODO comment and let the test run with executable-model.
Currently, executable-model is disabled:
{code:java}
// TODO: ....
return TestParametersUtil.getKieBaseCloudConfigurations(false);
{code}
If the test failure contains multiple bugs, we may split this JIRA into multiple JIRAs.
was:
org.drools.mvel.integrationtests.PropertySpecificTest in test-compiler-integration fails with some tests when executable-model is enabled. See TODO comment in the test class. Once fixed (or the test failure is justified), we can remove the TODO comment and let the test run with executable-model.
Currently, executable-model is disabled:
{code:java}
// TODO: ....
return TestParametersUtil.getKieBaseCloudConfigurations(false);
{code}
If the test failure contains multiple bugs, we may split this JIRA into multiple JIRAs.
> executable-model test failure in test-compiler-integration PropertySpecificTest
> -------------------------------------------------------------------------------
>
> Key: DROOLS-5826
> URL: https://issues.redhat.com/browse/DROOLS-5826
> Project: Drools
> Issue Type: Bug
> Components: executable model
> Affects Versions: 7.46.0.Final
> Reporter: Toshiya Kobayashi
> Assignee: Toshiya Kobayashi
> Priority: Major
>
> *Probably the same issue as DROOLS-5818*
> org.drools.mvel.integrationtests.PropertySpecificTest in test-compiler-integration fails with some tests when executable-model is enabled. See TODO comment in the test class. Once fixed (or the test failure is justified), we can remove the TODO comment and let the test run with executable-model.
> Currently, executable-model is disabled:
> {code:java}
> // TODO: ....
> return TestParametersUtil.getKieBaseCloudConfigurations(false);
> {code}
> If the test failure contains multiple bugs, we may split this JIRA into multiple JIRAs.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)
5 years, 2 months