[jboss-jira] [JBoss JIRA] (JGRP-2150) More efficient message adding and draining

[ https://issues.jboss.org/browse/JGRP-2150?page=com.atlassian.jira.plugin.... ] Bela Ban edited comment on JGRP-2150 at 1/5/17 11:36 AM: --------------------------------------------------------- Better algorithm for a bounded MessageBatch: {code:java} protected final MessageBatch batch=new MessageBatch(BATCH_SIZE); protected final AtomicInteger counter=new AtomicInteger(0); protected void add(MessageBatch mb) { int size=add(mb); // adds mb to this.batch if(size > 0) drain(size); } protected void drain(int num) { if(counter.getAndAdd(num) == 0) { final MessageBatch delivery_batch=new MessageBatch(num); do { delivery_batch.reset(); removed_msgs=_transfer(delivery_batch); cnt++; // deliver delivery_batch } while(counter.addAndGet(-removed_msgs) != 0); } } {code} Note that counter can temporarily get negative, e.g. * T1 adds 5 messages * T2 adds 5 messages * T1 increments counter from 0 -> 5, enters do-while loop * T1 removes 10 messages, delivers the batch of 10 * T1 decrements counter by 10: -5 * T1 loops and removes 0 messages * T2 increments counter from -5 to 0: terminates as prev_value was -5 * T1 hits the while clause which evaluates to true (counter == 0) and terminates was (Author: belaban): Better algorithm for a bounded MessageBatch: {code:java} protected final MessageBatch batch=new MessageBatch(BATCH_SIZE); protected final AtomicInteger counter=new AtomicInteger(0); protected void add(MessageBatch mb) { int size=add(mb); // adds mb to this.batch if(size > 0) drain(size); } protected void drain(int num) { if(counter.getAndAdd(num) == 0) { final MessageBatch delivery_batch=new MessageBatch(num); do { delivery_batch.reset(); removed_msgs=_transfer(delivery_batch); cnt++; // deliver delivery_batch } while(counter.addAndGet(-removed_msgs) != 0); } } {code} Note that counter can get nagative temporarily, e.g. * T1 adds 5 messages * T2 adds 5 messages * T1 increments counter from 0 -> 5, enters do-while loop * T1 removes 10 messages, delivers the batch of 10 * T1 decrements counter by 10: -5 * T1 loops and removes 0 messages * T2 increments counter from -5 to 0: terminates as prev_value was -5 * T1 hits the while clause which evaluates to true (counter == 0) and terminates -- This message was sent by Atlassian JIRA (v7.2.3#72005)