[jboss-jira] [JBoss JIRA] Closed: (JBREM-810) coyote.RequestMap not storing all request properties in the Map.Entry set
[ http://jira.jboss.com/jira/browse/JBREM-810?page=all ]
Ron Sigal closed JBREM-810.
---------------------------
Resolution: Out of Date
This problem no longer seems to occur. While it's true that
org.jboss.remoting.transport.coyote.RequestMap.get() treats keys "MethodType",
"Path", and "HttpVersion" differently by retrieving the value directly
from the backing org.apache.coyote.Request, it's also true that
org.jboss.remoting.transport.coyote.CoyoteInvoker.populateRequestMetadata() puts values
for these parameters in the RequestMap.internalMap:
metadata.put(HTTPMetadataConstants.METHODTYPE, req.method().getString());
metadata.put(HTTPMetadataConstants.PATH, req.requestURI().getString());
metadata.put(HTTPMetadataConstants.HTTPVERSION, req.protocol().getString());
It follows that iterating over RequestMap.entrySet(), which returns
RequestMap.internalMap.entrySet(), will return values for these parameters.
Advice from Remy Maucherat: "I'd recommend making sure you are fixing bugs.
Otherwise there's not much incentive to change things, right ?"
coyote.RequestMap not storing all request properties in the Map.Entry
set
-------------------------------------------------------------------------
Key: JBREM-810
URL: http://jira.jboss.com/jira/browse/JBREM-810
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: transport
Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.1.GA, 2.2.2.SP1
Reporter: Tom Fennelly
Assigned To: Ron Sigal
Priority: Minor
Fix For: 2.4.0.CR1 (Pinto)
Small thing, but the RequestMap overrides the get method for some of the request
properties e.g. "Path" and "HttpVersion". This is fine if the code
using the request Map (from InvocationRequest) accesses the properties via the get method.
However, if it iterates over the Map.Entry set, these values will come back as null
because they're not actually stored in the map entry set.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira