[ http://jira.jboss.com/jira/browse/JBAS-5035?page=all ] Luc Boudreau updated JBAS-5035: ------------------------------- Affects Version/s: JBossAS-5.0.0.Beta3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5035?page=all ] Adrian Brock updated JBAS-5035: ------------------------------- Issue Type: Feature Request (was: Bug) Assignee: (was: Weston Price) Priority: Minor (was: Major) I don't see how this is a bug. There are many checkers for many different drivers/databases. This one was contributed by somebody that used a specific MySQL driver. In fact, they got MySQL to implement the feature so they could write the checker in the first place. Write your own checker for the other driver and contribute it back. If you want to contribute one that uses java.sql.Connection.isValid() (Java6 only) that would be nice as well. Leaving this open as a feature request for somebody that does want to contribute. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5035?page=comments#action_12390491 ] Adrian Brock commented on JBAS-5035: ------------------------------------ First, can you add a header that says you license it under the LGPL. Thanks. ;-) You can just use the standard one which says it is copyrighted according to the @authors tag. I see you copied the same bug from the original checker. The class says it is serializable but java.lang.reflect.Method is not serializable so serialization is broken. ;-) Otherwise it looks ok. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5035?page=all ] Adrian Brock updated JBAS-5035: ------------------------------- Attachment: (was: MySQLValidReplicationConnectionChecker.java) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5035?page=comments#action_12390500 ] Adrian Brock commented on JBAS-5035: ------------------------------------ It looks the same, did you attach the correct one? :-) I've deleted both the attachments can you try again. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5035?page=comments#action_12390511 ] Adrian Brock commented on JBAS-5035: ------------------------------------ Ah! Ok I see the problem. You should read this: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html#SEC4 i.e. You need to include all the verbage like at the top of the original checker: " /* * JBoss, Home of Professional Open Source. * Copyright 2006, Red Hat Middleware LLC, and individual contributors * as indicated by the @author tags. See the copyright.txt file in the * distribution for a full listing of individual contributors. * * This is free software; you can redistribute it and/or modify it * under the terms of the GNU Lesser General Public License as * published by the Free Software Foundation; either version 2.1 of * the License, or (at your option) any later version. * * This software is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this software; if not, write to the Free * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA * 02110-1301 USA, or see the FSF site: http://www.fsf.org. */ package org.jboss.resource.adapter.jdbc.vendor; " -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5035?page=all ] Adrian Brock updated JBAS-5035: ------------------------------- Attachment: (was: MySQLValidReplicationConnectionChecker.java) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5035?page=all ] Adrian Brock closed JBAS-5035. ------------------------------ Fix Version/s: JBossAS-5.0.0.Beta3 JBossAS-4.2.3.GA Resolution: Done Much better thanks. I've added you to our copyright.txt :-) I changed the name to MySQLReplicationValidConnectionChecker since that makes more sense. I also raised a subtask to fix the other checkers that are caching Methods. When I fix those, I'll also optimize yours so it does cache the Method but as a transient field and re-initializes the reference in a readObject() method. Getting the method on every invocation can be slow. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira