]
Dan Berindei commented on JGRP-2172:
------------------------------------
+1 for Radim's proposal.
The synchronization currently used in {{Credit}} also maintains a queue of waiting threads
internally, so this shouldn't impact performance for applications that don't use
{{NB_FC}}.
Non-blocking flow control
-------------------------
Key: JGRP-2172
URL:
https://issues.jboss.org/browse/JGRP-2172
Project: JGroups
Issue Type: Feature Request
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 4.0.4
Sending a message through FlowControl (UFC, MFC) should not block if
{{Message.Flag.NB_FC}} (non-blocking flow control) is set.
Instead, the message should be added to a queue (bounded if {{max_size}} > 0, else
unbounded). The max queue size is given in bytes, so we can estimate what the memory
penalty for reaching that size would be (if bounded).
The queued messages are sent when credits arrive. TBD: when credits arrive, should
blocked threads or queued messages be released first?
Non-blocking flow control can be used by both external and internal threads.
If the queue is unbounded, then it is the responsibility of the application (e.g.
Infinispan) to make sure the queue doesn't grow to an untenable size.