[ https://issues.jboss.org/browse/AS7-2096?page=com.atlassian.jira.plugin.s... ] Remy Maucherat commented on AS7-2096: ------------------------------------- I won't add it in the domain model. If this setting is "key" then it means the configuration used for the testing is inappropriate. I will add a system property, but you shouldn't use it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2096?page=com.atlassian.jira.plugin.s... ] Jason Greene updated AS7-2096: ------------------------------ Moving all non-critical issues to the CR. If you finish it before we release beta please correct the fix-for version. Thanks -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2096?page=com.atlassian.jira.plugin.s... ] Andrig Miller commented on AS7-2096: ------------------------------------ Okay, that, in my opinion is a workaround that I can use, but it still needs to be a real attribute, so I can use the console to set it, like anything else I'm setting. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2096?page=com.atlassian.jira.plugin.s... ] Andrig Miller commented on AS7-2096: ------------------------------------ Remy, sometimes I think that you assume that everyone is just stupid! I'm not trying to disable keep alive. The default, unless its changed, is that for every 100 requests the server will close the connection, regardless of the fact that the client is using keep alive. I want to set this value to unlimited (-1), because it gives the best throughput on benchmarks, because it never closes the connection on the server, forcing the load driver to have to reconnect. In a benchmarking situation, you don't want that. In a real-life application scenario, closing the connection after 100 requests may actually make a lot of sense, but a load driver client is going to do a lot more than 100 requests. So, yes, exposing it as an attribute does allow people to disable keep alive, which is bad, but the default doesn't work for benchmarking. Also, I document this in the performance tuning guide for EAP, so for customers we have good documentation that would tell them not to disable i! t. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2096?page=com.atlassian.jira.plugin.s... ] Andrig Miller commented on AS7-2096: ------------------------------------ Changing it unlimited gives me about a 2% improvement in performance on my benchmark testing. When you consider my typical benchmarks will do 4 million or more requests to the server, the default of 100 requests on each client, actually forces the load driver to reconnect a lot! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-2096?page=com.atlassian.jira.plugin.s... ] Andrig Miller commented on AS7-2096: ------------------------------------ That is fine with me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira