[
http://jira.jboss.com/jira/browse/JBRULES-1063?page=all ]
Philippe Ombredanne reassigned JBRULES-1063:
--------------------------------------------
Assignee: Kris Verlaenen (was: Edson Tirelli)
Kris:
Could you review this?
I just would like you to review the two test quickly (the FAILING ones are the original
ones) :
http://fisheye.jboss.com/browse/JBossRules/trunk/drools-eclipse/drools-ec...
and here :
http://fisheye.jboss.com/browse/JBossRules/trunk/drools-eclipse/drools-ec...
Th is about a change in whitespace handling that was introduced in eth paers.
I am not sure what are the implications for that.
I copied the 2 tests that failed, and made them pass (not whitespace at the end of the
line) and kept the ones that failed prefixed with FAILING
Failing location determination tests
------------------------------------
Key: JBRULES-1063
URL:
http://jira.jboss.com/jira/browse/JBRULES-1063
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Eclipse IDE, Drl Parser/Builder
Affects Versions: 4.0.1
Reporter: Philippe Ombredanne
Assigned To: Kris Verlaenen
Priority: Minor
Fix For: 4.0.1
We have four failing tests in that code :
org.drools.eclipse.editors.completion.CompletionContextTest (
http://fisheye.jboss.com/browse/JBossRules/trunk/drools-eclipse/drools-ec...
) that I isolated in separate test methods, and prefixed so they would not make the build
fail.
Their name is prefixed with FAILING
I am not sure why they started to fail (I know why, but I do not understand exactly the
rationale for the tests being made) , but possibly some changes in the DrlParser handling
of trailing white spaces could have triggered that.
The white space issue could be coming from that rev :
http://fisheye.jboss.com/changelog/JBossRules/trunk/drools-compiler/src/m...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira