[
http://jira.jboss.com/jira/browse/JBCOMMON-55?page=all ]
Dimitris Andreadis closed JBCOMMON-55.
--------------------------------------
Assignee: Dimitris Andreadis (was: Scott M Stark)
The test needed fixing:
// the last-modified header is expected to strip the milliseconds to
// comply with the (dd MMM yyyy HH:mm:ss) format, so the following assertions
// is invalid on windows that provide millisecond accuracy to File.lastModified()
// see,
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4504473
// assertEquals(lastModified, lastModifiedHdr);
I also removed the initialization of the 'file' protocol from
URLStreamHandlerFactory.
The main jboss testsuite will need small changes, too.
Revert back to JDK's FileURLConnection implementation
-----------------------------------------------------
Key: JBCOMMON-55
URL:
http://jira.jboss.com/jira/browse/JBCOMMON-55
Project: JBoss Common
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Components: common-core (2.x)
Reporter: Galder Zamarreno
Assigned To: Dimitris Andreadis
Fix For: 2.2.6.GA
Our FileURLConnection implementation not behaving the same as the Sun
implementation which can cause issues if client code depends on Sun's
implementation.
This was created to get around a bug that was fixed in JDK 5:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4504473
We should be able to remove it now if we are sure there is no longer a bug
in any of the JDKs. This probably requires adding a test to the testsuite that
validates whether the FileUrlConnection.lastModified() returns the same
result as File.lastModified()?
That way we know whether to include the workaround for the tested JDK.
The workaround class could be in a seperate jar created by the
common-core project.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira