[ https://issues.jboss.org/browse/AS7-5010?page=com.atlassian.jira.plugin.s... ] Thomas Diesler reassigned AS7-5010: ----------------------------------- Assignee: David Bosschaert (was: Brian Stansberry) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5010?page=com.atlassian.jira.plugin.s... ] Brian Stansberry commented on AS7-5010: --------------------------------------- The fix to avoid the recursion is the overloaded method that takes the RollbackHandler. :-) An operation consists of a list of steps, each with an OperationStepHandler. Calling completeStep() triggers invocation of the next step in the chain, with the return value reflecting the result of the *entire* list of steps. If the final result is rollback, the OSH may need to deal with executing that rollback. If it doesn't get the final result from the stack (the no-arg variant) it needs to get it via the handler callback. I added AS7-5059 to deprecate the no-arg variant; I'll probably do that in 7.3 and remove the method in AS 8. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-5010?page=com.atlassian.jira.plugin.s... ] David Bosschaert edited comment on AS7-5010 at 6/25/12 6:39 AM: ---------------------------------------------------------------- Just to make sure that I'm doing this correctly. Let's say I have the following code that was using completeStep(): {code:java}public void execute(OperationContext context, ModelNode operation) throws OperationFailedException { Activation val = Activation.valueOf(operation.require(ModelDescriptionConstants.VALUE).asString().toUpperCase(Locale.ENGLISH)); ModelNode node = context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS).getModel(); node.get(ModelConstants.ACTIVATION).set(val.toString().toLowerCase(Locale.ENGLISH)); context.completeStep(); }{code} Is the following modification correct? {code:java}Activation val = Activation.valueOf(operation.require(ModelDescriptionConstants.VALUE).asString().toUpperCase(Locale.ENGLISH)); ModelNode node = context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS).getModel(); final String oldVal = node.get(ModelConstants.ACTIVATION).asString(); node.get(ModelConstants.ACTIVATION).set(val.toString().toLowerCase(Locale.ENGLISH)); context.completeStep(new OperationContext.RollbackHandler() { public void handleRollback(OperationContext context, ModelNode operation) { ModelNode node = context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS).getModel(); node.get(ModelConstants.ACTIVATION).set(oldVal); } });{code} was (Author: bosschaert): Just to make sure that I'm doing this correctly. Let's say I have the following code that was using completeStep(): {code:java}public void execute(OperationContext context, ModelNode operation) throws OperationFailedException { Activation val = Activation.valueOf(operation.require(ModelDescriptionConstants.VALUE).asString().toUpperCase(Locale.ENGLISH)); ModelNode node = context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS).getModel(); node.get(ModelConstants.ACTIVATION).set(val.toString().toLowerCase(Locale.ENGLISH)); context.completeStep(OperationContext.RollbackHandler.NOOP_ROLLBACK_HANDLER); }{code} Is the following modification correct? {code:java}Activation val = Activation.valueOf(operation.require(ModelDescriptionConstants.VALUE).asString().toUpperCase(Locale.ENGLISH)); ModelNode node = context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS).getModel(); final String oldVal = node.get(ModelConstants.ACTIVATION).asString(); node.get(ModelConstants.ACTIVATION).set(val.toString().toLowerCase(Locale.ENGLISH)); context.completeStep(new OperationContext.RollbackHandler() { public void handleRollback(OperationContext context, ModelNode operation) { ModelNode node = context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS).getModel(); node.get(ModelConstants.ACTIVATION).set(oldVal); } });{code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira