[
https://issues.jboss.org/browse/WFCORE-491?page=com.atlassian.jira.plugin...
]
Brian Stansberry commented on WFCORE-491:
-----------------------------------------
Thanks for this.
A quick note on the problem, in case this PR results in issues after I merge it. The
problem seems like quite an edge case. Contention on the lock means concurrent management
requests, not just a rapid succession of requests. So, lots and lots of clients or clients
that for some reason are making a lot concurrent requests.
Improve ManagedAuditLoggerImpl.log() performance when disabled
--------------------------------------------------------------
Key: WFCORE-491
URL:
https://issues.jboss.org/browse/WFCORE-491
Project: WildFly Core
Issue Type: Enhancement
Components: Domain Management
Affects Versions: 1.0.0.Alpha15
Reporter: James Livingston
Assignee: James Livingston
Priority: Minor
org.jboss.as.controller.audit.ManagedAuditLoggerImpl.log/logJmxMethodAccess() does some
work such as creating the log item which will just be thrown away if
getLoggerStatus()==DISABLED.
It may be worth checking if that is the case and skipping the work that will not be
needed. If it was not for the applyHandlerUpdates() call, I think an
"isDisabled" volatile flag could be used to avoid taking the lock at all there,
which can be expensive due to it being a fair lock.
This does not appear to show up as a issue unless you are performing a lot (thousands) of
management operations in quick succession.
--
This message was sent by Atlassian JIRA
(v6.3.11#6341)