ConfigurationPersister problems in successfulBoot() should not be able to abort boot ------------------------------------------------------------------------------------ Key: WFCORE-1721 URL: https://issues.jboss.org/browse/WFCORE-1721 Project: WildFly Core Issue Type: Bug Components: Domain Management Reporter: Brian Stansberry This error (reported in a testsuite run) should not have the effect: {code} 17:31:30,743 ERROR [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0055: Caught exception during boot: org.jboss.as.controller.persistence.ConfigurationPersistenceException: WFLYCTL0082: Failed to create backup copies of configuration file C:\BuildAgent\work\a31d203e70e89f90\testsuite\integration\basic\target\jbossas\standalone\configuration\standalone.xml at org.jboss.as.controller.persistence.ConfigurationFile.successfulBoot(ConfigurationFile.java:514) at org.jboss.as.controller.persistence.BackupXmlConfigurationPersister.successfulBoot(BackupXmlConfigurationPersister.java:94) at org.jboss.as.controller.AbstractControllerService.finishBoot(AbstractControllerService.java:455) at org.jboss.as.server.ServerService.boot(ServerService.java:366) at org.jboss.as.controller.AbstractControllerService$1.run(AbstractControllerService.java:302) at java.lang.Thread.run(Thread.java:745) Caused by: java.nio.file.FileSystemException: C:\BuildAgent\work\a31d203e70e89f90\testsuite\integration\basic\target\jbossas\standalone\configuration\standalone_xml_history\standalone.boot.xml: The process cannot access the file because it is being used by another process. at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97) at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102) at sun.nio.fs.WindowsFileCopy.copy(WindowsFileCopy.java:165) at sun.nio.fs.WindowsFileSystemProvider.copy(WindowsFileSystemProvider.java:278) at java.nio.file.Files.copy(Files.java:1274) at org.jboss.as.controller.persistence.FilePersistenceUtils.copyFile(FilePersistenceUtils.java:78) at org.jboss.as.controller.persistence.ConfigurationFile.successfulBoot(ConfigurationFile.java:512) ... 5 more 17:31:30,744 FATAL [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0056: Server boot has failed in an unrecoverable manner; exiting. See previous messages for details. {code} WFCORE-1501 dealt with a similar problem. This needs a bit of caution, to ensure that we still fail boot on failures that are more substantial than problems creating the history folder stuff. Think about stuff like read-only-config cases where we need to make sure that a reload op will be able to function properly. That caveat probably should have been applied to my WFCORE-1501 work as well.