[ https://issues.jboss.org/browse/DROOLS-2388?page=com.atlassian.jira.plugi... ] Tibor Zimányi edited comment on DROOLS-2388 at 3/20/18 12:11 PM: ----------------------------------------------------------------- Steps to reproduce: 1. Checkout branch from this PR [1] 2. Change getLocalPart() on this line to toString() [2] 3. Run test [3] 4. Run test [4] Test from point 3. fails on validation error, because the validation rule fired - the typeRef from the provided Definitions contains namespace. However test from point 4. pass, because unmarshalling used in the validate method that takes Reader as an input works differently and doesn't fill namespace in the typeref. This is inconsistent, because a user could expect that the validate methods behave the same when the same file is used (either for getting Definitions or providing it directly to the validate method). [1] https://github.com/kiegroup/drools/pull/1810 [2] https://github.com/baldimir/drools/blob/5a9cb6f09a52cdc46b7cafb52cf615f88... [3] https://github.com/baldimir/drools/blob/7a2c6374351d57011ae67d4fc28900ea8... [4] https://github.com/baldimir/drools/blob/7a2c6374351d57011ae67d4fc28900ea8... was (Author: tzimanyi): Steps to reproduce: 1. Checkout branch from this PR [1] 2. Change getLocalPart() on this line to toString() [2] 3. Run test [3] 4. Run test [4] Test from point 3. fails on validation error, because the validation rule fired - the typeRef from the provided Definitions contains namespace. However test from point 4. pass, because unmarshalling from the validate method that takes Reader as an input works differently and doesn't fill namespace in the typeref. This is inconsistent, because a user could expect that the validate methods behave the same when the same file is used (either for getting Definitions or providing it directly to the validate method). [1] https://github.com/kiegroup/drools/pull/1810 [2] https://github.com/baldimir/drools/blob/5a9cb6f09a52cdc46b7cafb52cf615f88... [3] https://github.com/baldimir/drools/blob/7a2c6374351d57011ae67d4fc28900ea8... [4] https://github.com/baldimir/drools/blob/7a2c6374351d57011ae67d4fc28900ea8... -- This message was sent by Atlassian JIRA (v7.5.0#75005)