8:30 a.m.
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Dominik Pospisil
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 a.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2954:
-----------------------------------
And when you're on it, you can fix this as well :)
{quote}
NFO] --- maven-checkstyle-plugin:2.5:checkstyle (check-style) @ jboss-as-testsuite-shared
---
[INFO] Starting audit...
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/ModelUtil.java:33:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/ModelUtil.java:39:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:47:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:49:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:51:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:55:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:63:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:65:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:67:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:70:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:73:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:77:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:79:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:88:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:91:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:94:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIOpResult.java:29:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIOpResult.java:60:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:85:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:89:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:169:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:191:
Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:195:
Line has trailing spaces.
Audit done.
{quote}
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Dominik Pospisil
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:29 a.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2954:
-----------------------------------
Also pls move things from base class to util class if possible, like in case of protected
final String getBaseURL(...)
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Dominik Pospisil
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:35 a.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Dominik Pospisil commented on AS7-2954:
---------------------------------------
Done:
https://github.com/dpospisil/jboss-as/commit/8af65ce3f21f87e2821df0ddfa49...
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Dominik Pospisil
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:23 p.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Jason Greene commented on AS7-2954:
-----------------------------------
Is there a reason why this is a bad idea? I mean all assert does is throw an exception?
Are you trying to limit the usage of junit to allow usage of testng?
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Dominik Pospisil
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:23 p.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Stuart Douglas commented on AS7-2954:
-------------------------------------
What is the reasoning behind this?
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Dominik Pospisil
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:57 p.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Dominik Pospisil reassigned AS7-2954:
-------------------------------------
Assignee: Ondrej Zizka (was: Dominik Pospisil)
That was my question as well :) Ondrej, could you explain this?
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:47 p.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Jason Greene resolved AS7-2954.
-------------------------------
Fix Version/s: 7.1.0.CR1
Resolution: Done
I'm resolving this since I merged the patch.
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
Fix For: 7.1.0.CR1
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:36 a.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2954:
-----------------------------------
The reasoning is:
1) JUnit would need to be compile-scope dependency which was claimed as undesirable in dev
list
2) Potential assert failure creates a stacktrace starting in different module than the
test is in, which makes it harder to examine / fix.
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
Fix For: 7.1.0.CR1
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:28 a.m.
[
https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka closed AS7-2954.
-----------------------------
TS: Mgmt test utils - move JUnit deps to tests.
-----------------------------------------------
Key: AS7-2954
URL: https://issues.jboss.org/browse/AS7-2954
Project: Application Server 7
Issue Type: Quality Risk
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
Fix For: 7.1.0.CR1
Calling JUnit's assert*() from a dependency is not a good idea.
Pls make it return boolean or throw an exception, and handle it in the test sources.
CLIWrapper.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5163
days inactive
5255
days old
9 comments
8 participants
participants (8)
-
Dominik Pospisil (Assigned) (JIRA) -
Dominik Pospisil (Commented) (JIRA)
-
Jason Greene (Commented) (JIRA)
-
Jason Greene (Resolved) (JIRA)
-
Ondrej Zizka (Commented) (JIRA)
-
Ondrej Zizka (Created) (JIRA)
-
Ondrej Zizka (JIRA)
-
Stuart Douglas (Commented) (JIRA)