[ http://jira.jboss.com/jira/browse/JGRP-678?page=all ] Bela Ban updated JGRP-678: -------------------------- Attachment: NAKACK.patch.txt -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JGRP-678?page=comments#action_12396808 ] Bela Ban commented on JGRP-678: ------------------------------- I don't think creating the entry for local_addr in xmit_table when not found is the right approach, for two reasons: 1. We should find out *why* local_addr was removed from xmit_table. local_addr is added on the first view and should never be removed ! I'll create a JIRA to investigate 2. Indiscriminately adding local_addr if not found may actually be dangerous: if we unilaterally removed local_addr (and I have to find out why), and others still have their entry for us (e.g. #25), then we will start at seqno #1 again, and our first 25 messages might get discarded ! I somewhat agree with the trace issue, but this information is really useful when such a situation occurs. I'll probably add another flag and trace when set (default=on). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JGRP-678?page=comments#action_12398251 ] Bela Ban commented on JGRP-678: ------------------------------- This needs to be reproduced (with WARN level set for all of JGroups). Then grep the logs for: - " from xmit_table (not member anymore)" - ") from xmit_table, received incorrect new membership of " - "digest does not contain local address (local_addr=" I changed the adjustReceivers() method such that local_addr is *never* removed from xmit_table, dito for setDigest() -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JGRP-678?page=comments#action_12398297 ] Bela Ban commented on JGRP-678: ------------------------------- I looked at the code which dumps the NakReceiverWindow, and it only prints the upper and lower boundaries (seqnos), plus the number of non-received messages for each sender. This should not take much space in the logs -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira