[ http://jira.jboss.com/jira/browse/JBWEB-67?page=comments#action_12340453 ] Remy Maucherat commented on JBWEB-67: ------------------------------------- Thanks for the fixes. I am not going to accept the fix for (3), though, but other than that, it looks good. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBWEB-67?page=all ] Rob Hughes reopened JBWEB-67: ----------------------------- I disagree about number 4. Mod_rewrite doesn't force a full match of the input to the pattern. Being familiar with mod_rewrite it took searching the source to find out why the following set wouldn't work with the rewrite valve but does with mod_rewrite. # input url http://someurl.com/page.html?name=about&test=param # change /page.html?name=page_name to /pages/page_name.html RewriteCond %{QUERY_STRING} name=([^&;]*) RewriteRule ^/page\.html /pages/%1.html? [L,R=301] Considering that the input and documentation are almost identical to the mod_rewrite stuff I would ask that you put number 4 in to maintain a consistent behavior between the two and to fall more inline with what users would expect. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBWEB-67?page=comments#action_12340765 ] Rob Hughes commented on JBWEB-67: --------------------------------- I am unsure where to have a discussion about this if you don't want the report reopened, so I won't reopen it but am adding this comment. I guess I have misstated what the problem is due to the fact that the example I provided had an issue with the RewriteCond and the query string and not the rule itself. With mod_rewrite and the rewrite valve the pattern is always matched against the full TestString. I am not disagreeing with that statement. What I am disagreeing with is by using Matcher.matches() you force the pattern to match the entire TestString. There is a subtle difference between matching the pattern to the entire string and forcing the pattern to match the entire string. Mod_rewrite does not do this, in the documentation it states that the URL or TestString is matched against the pattern. Nowhere does it state that the pattern must match the entire string and in actual usage you will find that it doesn't have to. For Example Given RewriteCond %{QUERY_STRING} name=([^&;]*) and Input name=about&test=param Mod_rewrite will process this condition as true while the current rewrite valve will process it as false. I would have to change the pattern to be .*name=([^&;]*).* to get it to match. If you are not aiming to provide a rewrite module that functions similar to mod_rewrite that this is a moot point and you can leave it as is, but it should be documented to state that the pattern must match the TestString in it's entirety. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira