[
https://issues.redhat.com/browse/WFLY-14402?page=com.atlassian.jira.plugi...
]
Brian Stansberry edited comment on WFLY-14402 at 2/4/21 5:35 PM:
-----------------------------------------------------------------
Context for this the 'metrics' subsystem has a runtime-only requirement for a
capability provided by microprofile-metrics-smallrye. And WFLY-14372 may add another.
As discussed in section 3.4.2 of
https://docs.wildfly.org/22/Extending_WildFly.html#using-capabilities, subsection
'Runtime-only requirements"
"The WildFly Core kernel will not register a requirement for the
"com.example.bar" capability, so if a configuration change occurs that means
that capability will no longer be present, that change will not be rolled back. Because of
this, runtime-only requirements can only be used with capabilities that declare in their
contract that they support such use."
A capability cannot 'support such use' if it can be removed without requiring a
reload.
was (Author: brian.stansberry):
Context for this the 'metrics' subsystem has a runtime-only requirement for a
capability provided by microprofile-metrics-smallrye. And WFLY-14372 may add another As
discussed in section 3.4.2 of
https://docs.wildfly.org/22/Extending_WildFly.html#using-capabilities, subsection
'Runtime-only requirements"
"The WildFly Core kernel will not register a requirement for the
"com.example.bar" capability, so if a configuration change occurs that means
that capability will no longer be present, that change will not be rolled back. Because of
this, runtime-only requirements can only be used with capabilities that declare in their
contract that they support such use."
A capability cannot 'support such use' if it can be removed without requiring a
reload.
MicroProfile Metrics subsystem installs DUPs but doesn't require
reload to remove
---------------------------------------------------------------------------------
Key: WFLY-14402
URL:
https://issues.redhat.com/browse/WFLY-14402
Project: WildFly
Issue Type: Bug
Components: MP Metrics
Reporter: Brian Stansberry
Assignee: Jeff Mesnil
Priority: Minor
I'm pretty sure this is wrong...
MicroProfileMetricsSubsystemAdd installs DUPs but the
MicroProfileMetricsSubsystemDefinition uses ServiceRemoveStepHandler as the remove
handler. But that handler doesn't (and can't) remove those DUPs.
This is minor because the description of the remove op is ok:
{code}
[standalone@localhost:9990 subsystem=microprofile-metrics-smallrye]
:read-operation-description(name=remove)
{
"outcome" => "success",
"result" => {
"operation-name" => "remove",
"description" => "Remove the subsystem",
"request-properties" => {},
"reply-properties" => {},
"read-only" => false,
"restart-required" => "all-services",
"runtime-only" => false
}
}
{code}
It says '"restart-required" => "all-services"', which
means this can be fixed with no change to the reported API.
I think this should use ReloadRequiredRemoveStepHandler.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)