[JBoss JIRA] Created: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
4:23 p.m.
Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters
jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to a
semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:39 p.m.
New subject: [JBoss JIRA] Updated: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Matthew Sandoz updated GPD-111:
-------------------------------
Attachment: solution.zip
includes some example classes under com.nexusbpm... that should not be added to the code
base. also the plugin.xml should not be used but acts as a guide for how to configure it
to use the new exsd. i hand copied the files for the zip so i hope i didnt put any in the
wrong place :)
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Attachments: solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:44 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12367270 ]
Koen Aers commented on GPD-111:
-------------------------------
Great Matthew, thanks a lot. I'll see how I can fit this in quickly.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Attachments: solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:12 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12369819 ]
Koen Aers commented on GPD-111:
-------------------------------
Matthew,
Did you sign the contributor's agreement? It would be better to do this to avoid later
trouble. Also, i can leave your name as the author of the contributed classes then ;-)
Cheers,
Koen
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Attachments: solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 a.m.
New subject: [JBoss JIRA] Updated: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Koen Aers updated GPD-111:
--------------------------
Fix Version/s: jBPM JPDL Designer 3.1.0.beta2
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.beta2
Attachments: solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12369857 ]
Matthew Sandoz commented on GPD-111:
------------------------------------
I just signed the agreement!
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.beta2
Attachments: solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:39 a.m.
New subject: [JBoss JIRA] Updated: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Koen Aers updated GPD-111:
--------------------------
Fix Version/s: jBPM JPDL Designer 3.1.0.CR
(was: jBPM JPDL Designer 3.1.0.beta2)
I will postpone the inclusion of this patch. I want to release beta2 this week and I
don't have enough time to include it anymore. If you can, please update the patch
because a fair number of refactorings took place in the meantime.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:10 p.m.
New subject: [JBoss JIRA] Updated: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Matthew Sandoz updated GPD-111:
-------------------------------
Attachment: solution.zip
I have updated the classes. as before dont use the com.nexubpm stuff - its just an
example. i have also removed the "required" attribute for the mapperClass in the
xmlMappings.exsd. this removes the need for any plugin.xml changes. The default mapper if
no other is found is the ConfiguredSemanticElementDomMapper.java.
to summarize, the important files are the xmlMappings.exsd,
ConfiguredSemanticElementDomMapper, SemanticElementDomMapper, XmlAdapter,
XmlAdapterFactory and XmlAdapterRegistry.
Let me know if you need anything else related to this. The changes have enabled us to make
lots of really fast progress on our extended version of the editor.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:41 a.m.
New subject: [JBoss JIRA] Updated: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Matthew Sandoz updated GPD-111:
-------------------------------
Attachment: solution.zip
Since I made the mapperClass attribute optional, the adapter registry needs to not log an
error when the class is not found. this update includes a small logging change to the
XmlAdapterRegistry code to accomplish that.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:34 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12370695 ]
Koen Aers commented on GPD-111:
-------------------------------
Hi Matthew,
I have worked on this today and I think the feature should be working now. I took the
liberty of changing your approach somewhat.
- I sticked to the changes in your extension point definition
- I changed the interface name to XmlElementMapper, this interface only has the
accept(Node) method
- The registry will register all the possible configuration elements for an xml element in
a set directly sorted according to the specified priority
- The xml adapter factory will iterate through the sorted set and once it finds a mapper
that accepts the dom node create the adapter found in the configuration element
With this approach, I was able to simplify the api (the interface has only one method), to
simplify and optimize the implementation of the adapter creation (sorting does only happen
once) and to get rid of the default implementation of the mapper.
The only thing I do not know is if this approach works for you, so could you please test
it for me? The changes are committed to HEAD
Regards,
Koen
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:54 p.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12370936 ]
Matthew Sandoz commented on GPD-111:
------------------------------------
Koen,
I started working with the updated code and am having issues with the priorities. i had
defined all of the priorities within my product to be the same - for example, all of my
nodes had a priority of -99 as i didnt expect to have to break ties within the product.
I'd prefer to allow two nodes to have the same priority. otherwise i have to generate
a different priority for each of my nodes - its possible but more work to maintain...
otherwise it is working well so far. i will do more testing over the next week.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:37 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12370982 ]
Koen Aers commented on GPD-111:
-------------------------------
I don't understand. What are the exact issues you have? Why do you have to give
different priorities to the nodes?
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:56 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371016 ]
Matthew Sandoz commented on GPD-111:
------------------------------------
i have several different node (semantic not xml) types and when i gave them the same
priority, they all used the same mapper. the other mappers dont look like theyre getting
called. when i change the priority it looks like they get called.
here are a couple of elements that interfere with each other:
<mapping
adapterClass="com.nexusbpm.editor.xml.EmailSenderNodeDomAdapter"
id="org.jbpm.gd.jpdl.emailSenderNode"
mapperClass="com.nexusbpm.editor.xml.EmailSenderNodeDomMapper"
mapperClassPriority="-98"
semanticElement="org.jbpm.gd.jpdl.emailSenderNode"
xmlElement="node"/>
<mapping
adapterClass="com.nexusbpm.editor.xml.RNodeDomAdapter"
id="org.jbpm.gd.jpdl.rNode"
mapperClass="com.nexusbpm.editor.xml.RNodeDomMapper"
mapperClassPriority="-97"
semanticElement="org.jbpm.gd.jpdl.rNode"
xmlElement="node"/>
if i put the two elements at the same priority only one gets identified.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:35 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371189 ]
Koen Aers commented on GPD-111:
-------------------------------
I made a mistake implementing the priority comparator. I think it should work now, can you
verify?
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:27 a.m.
New subject: [JBoss JIRA] Resolved: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Koen Aers resolved GPD-111.
---------------------------
Resolution: Done
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:58 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371301 ]
Matthias Hanisch commented on GPD-111:
--------------------------------------
Is it by intention, that the default priority is MAXINT, if you do not set a value for
"mapperClassPriority"?
Because of that, it is not possible to activate a mapping on an existing xml types, since
the existing semantic element is always first in the SortedSet.
So I have to set mapperClassPriority for this existing xml mapping.
Or am I missing something?
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371313 ]
Koen Aers commented on GPD-111:
-------------------------------
The value MAX_VALUE was originally chosen because this would be the lowest priority
(huh?).
The (second) mistake was that I assumed wrongly the wrong order within the sorted set.
I think it would indeed be best to do as you suggest and assume MIN_VALUE for the default
priority and let contributors specify higher priorities if they want their mapper to take
over. If I am not mistaken, the ordering should be from high to low now with the latest
commit. Can anyone verify?
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:20 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371314 ]
Matthias Hanisch commented on GPD-111:
--------------------------------------
I would choose 0 as default, because with extreme values you have easily an overflow in
the comparator calculation.
Your change had no impact in my use case. I have chose priority 1 for my mapping.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:26 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371315 ]
Matthias Hanisch commented on GPD-111:
--------------------------------------
Now it's clear.
Before your change it was: MAX -1 > 0
After your change it was MIN -1 > 0 because of overflow
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:57 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371317 ]
Koen Aers commented on GPD-111:
-------------------------------
Okay, this makes a lot of sense... 0 it will be ;-)
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:05 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371318 ]
Koen Aers commented on GPD-111:
-------------------------------
It is changed to 0 now. Please check again (but allow half an hour time for the public cvs
to synchronize)
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371321 ]
Matthias Hanisch commented on GPD-111:
--------------------------------------
I made exactly the same change locally and this worked :)
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:02 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371345 ]
Koen Aers commented on GPD-111:
-------------------------------
Matthew, can you have a check if this works for you and close the issue if it does?
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:18 p.m.
New subject: [JBoss JIRA] Closed: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Matthew Sandoz closed GPD-111.
------------------------------
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:18 p.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371395 ]
Matthew Sandoz commented on GPD-111:
------------------------------------
hi all - sorry ive been ill for a few days and it has delayed my verification of this.
everything looks to be working fine.
as far as my intentions with MAX_VALUE, i was thinking of the difference of a Priority 1
problem vs a Priority 2 problem. it may or may not make sense in that context but
certainly as i began working with using the priorities it became more and more obvious
that descending priorities was very counter-intuitive. i like the use of 0 as the default
much better!
thanks to everyone for the great discussion. i hope this helps make it easier for people
to make extensions!
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:59 p.m.
New subject: [JBoss JIRA] Reopened: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Matthew Sandoz reopened GPD-111:
--------------------------------
sorry to have to reopen this but there are several use cases and the one i overlooked
yesterday isnt working.
when i create a node from the palette, the createAdapterFromModel method of the
XmlAdapterFactory is called. At the end of this, the factory calls
createAdapterFromElementName. Unfortunately this doesnt allow the factory to create an
adapter specific to the SemanticElement, but rather the node name. The node name is shared
among many classes and so always returns the same adapter.
I was able to get around this as in my original code by adding the following into the
createAdapterFromModel method:
INodeNotifier element = (INodeNotifier)document.createElement(elementName);
XmlAdapter result;
try {
result = (XmlAdapter)
configurationElement.createExecutableExtension("adapterClass");
result.setNode((Node)element);
result.setFactory(this);
return result;
} catch (CoreException e) {
Logger.logError("Unable to create XML Adapter for " +
jpdlElement.getElementId(), e);
}
right before the final return.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:27 p.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371517 ]
Matthew Sandoz commented on GPD-111:
------------------------------------
i will attach a file with the changes as this solution doesnt seem to be perfect yet.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:19 p.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371540 ]
Matthew Sandoz commented on GPD-111:
------------------------------------
ok this appears to be working now - heres a patch from eclipse from the eclipse
"Create Patch" - is that the best way to provide these? if not i can attach the
entire file...
### Eclipse Workspace Patch 1.0
#P org.jbpm.gd.jpdl
Index: src/org/jbpm/gd/common/xml/XmlAdapterFactory.java
===================================================================
RCS file:
/cvsroot/jbpm/jbpm.3/designer/jpdl/org.jbpm.gd.jpdl/src/org/jbpm/gd/common/xml/XmlAdapterFactory.java,v
retrieving revision 1.8
diff -u -r1.8 XmlAdapterFactory.java
--- src/org/jbpm/gd/common/xml/XmlAdapterFactory.java 7 Aug 2007 13:02:45 -0000 1.8
+++ src/org/jbpm/gd/common/xml/XmlAdapterFactory.java 8 Aug 2007 20:16:40 -0000
@@ -99,6 +99,17 @@
Logger.logError("Neither xmlElement nor nameProvider are present on mapping
configuration element for " + jpdlElement.getElementId(), e);
}
}
+ } else {
+ try {
+ XmlAdapter adapter = (XmlAdapter)
configurationElement.createExecutableExtension("adapterClass");
+ INodeNotifier element = (INodeNotifier)document.createElement(elementName);
+ element.addAdapter(adapter);
+ adapter.setNode((Node)element);
+ adapter.setFactory(this);
+ return adapter;
+ } catch (CoreException e) {
+ Logger.logError("Unable to create XML Adapter for " +
jpdlElement.getElementId(), e);
+ }
}
return elementName == null ? null : createAdapterFromElementName(elementName);
}
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.CR
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:31 a.m.
New subject: [JBoss JIRA] Updated: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Koen Aers updated GPD-111:
--------------------------
Fix Version/s: jBPM JPDL Designer 3.1.0.GA
(was: jBPM JPDL Designer 3.1.0.CR)
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:20 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371826 ]
Koen Aers commented on GPD-111:
-------------------------------
Matthew,
This is not a good way of implementing it. The adapters *have* to be created in the
'createAdapter' method per the specification of the AbstractAdapterFactory class.
I will try to come up with an alternative solution.
Regards,
Koen
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371831 ]
Koen Aers commented on GPD-111:
-------------------------------
Hm, this looks indeed like a problem. Doing it before the createAdapter method is called
looks like the only solution. I have modified your fix slightly so that the createAdapter
method is nevertheless called again after the creation of the adapter. Let me know if it
works.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:35 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371844 ]
Matthias Hanisch commented on GPD-111:
--------------------------------------
Hi Koen,
by accident I stumbled over the same problem today.
Your patch does not work completey in my case because you do not set the factory before
you call adapt().
As a consequence XMLAdapter.isAdapterFor(type) fails, because the factory is null.
So probably you have to call setFactory() twice - once before and once after calling
adapt().
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:47 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371846 ]
Matthias Hanisch commented on GPD-111:
--------------------------------------
Ok, putting another setFactory() before adapt() call in XMLAdapterFactory.createAdapter()
makes my use case work.
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:13 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371851 ]
Koen Aers commented on GPD-111:
-------------------------------
Matthias, I have simply *moved* the setFactory() before adapt(). Does that work as well?
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371854 ]
Matthew Sandoz commented on GPD-111:
------------------------------------
Koen, sorry I just couldnt find any other way to make it work. Your update works just fine
for me now though. I am creating nodes as well as saving and loading them all correctly.
This supports the use cases I have so far and I am closing the issue. Thanks!
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 a.m.
New subject: [JBoss JIRA] Closed: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=all ]
Matthew Sandoz closed GPD-111.
------------------------------
Resolution: Done
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 a.m.
New subject: [JBoss JIRA] Commented: (GPD-111) Add ability to forward and reverse map Semantic Elements to/from Dom Node/Xml Adapters jpdl
[ http://jira.jboss.com/jira/browse/GPD-111?page=comments#action_12371855 ]
Matthias Hanisch commented on GPD-111:
--------------------------------------
Yes it works, because in my case the "result" object returned by adapt() is
identical to the one created before.
I just want to note, that - with this change - you expect that adapt() returns a well
configured adapter, which is probably correct.
To make it short, I am happy with this change :).
Add ability to forward and reverse map Semantic Elements to/from Dom
Node/Xml Adapters jpdl
-------------------------------------------------------------------------------------------
Key: GPD-111
URL: http://jira.jboss.com/jira/browse/GPD-111
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Environment: all? :)
Reporter: Matthew Sandoz
Assigned To: Koen Aers
Fix For: jBPM JPDL Designer 3.1.0.GA
Attachments: solution.zip, solution.zip, solution.zip
Addresses need to add new semantic elements without adding new xml types. Current mapping
forces 1-1 mapping between them.
this change allows one-to-many mapping between elements by introducing a mapping object
for each semantic element.
this mapping object's responsibility is to determine if a chunk of xml should map to
a semantic element and xml adapter or not.
the xml adapter registry holds a set of these mappers and loops through them all, giving
each a chance to accept the xml chunk. all accepting
mappers are then sorted by priority and the lowest priority number is selected. mappings
with no priority are given Integer.MAX priority. Mappings with
no mapperClass are given a default mapper class of ConfiguredSemanticElementDomMapper so
that existing plugin.xml should continue to function
normally.
The priority property allows the maintainer of the plugin.xml to change priorities for
different circumstances, giving different potentially conflicting mappers
a specific preference order.
Details of change:
Added two elements to xmlMappings.exsd: mapperClass and mapperClassPriority
Created interface SemanticElementDomMapper to determine if a given Dom Node can be
assigned to a semantic element
Created class ConfiguredSemanticElementDomMapper as a base implementation of the
SemanticElementDomMapper. This
default implementation checks the current configured xml node name against the node name
of the passed Dom Node. This should
duplicate the existing functionality for existing standard jpdl xml node types.
JythonNodeDomMapper is included as an example but should not be committed to the project
as it is for specialized use.
XmlAdapterRegistry constructs a HashMap of Mappers and has a new
getConfigurationElementByNode method.
XmlAdapter has 2 lines modified in the createSemanticElementFor method to use the new
registry method.
XmlAdapterFactory has modifications in createAdapter and createAdapterFromModel
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6914
days inactive
6960
days old
36 comments
3 participants
participants (3)
-
Koen Aers (JIRA) -
Matthew Sandoz (JIRA)
-
Matthias Hanisch (JIRA)