6:10 p.m.
Scott Stark created AS7-3758:
--------------------------------
Summary: ParsedInterfaceCriteria.parseCriteria is not maintaining
ExpressionValues
Key: AS7-3758
URL: https://issues.jboss.org/browse/AS7-3758
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.0.CR1b
Reporter: Scott Stark
Assignee: Scott Stark
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:42 a.m.
[
https://issues.jboss.org/browse/AS7-3758?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-3758:
---------------------------------------
I'm wondering how -b works?
The patch in the pull request is correct; I'm just concerned there's something
deeper I'm not understanding.
ParsedInterfaceCriteria.parseCriteria is not maintaining
ExpressionValues
-------------------------------------------------------------------------
Key: AS7-3758
URL: https://issues.jboss.org/browse/AS7-3758
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.0.CR1b
Reporter: Scott Stark
Assignee: Scott Stark
Labels: network
Original Estimate: 1 hour
Remaining Estimate: 1 hour
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:06 a.m.
[
https://issues.jboss.org/browse/AS7-3758?page=com.atlassian.jira.plugin.s...
]
Scott Stark commented on AS7-3758:
----------------------------------
It turns out that the current usage for INET_ADDRESS where the default configuration is
${jboss.bind.address.management:127.0.0.1}, sees an incoming Property with a ModelValue
type of ExpressionValue, so the current call to
createInetAddressCriteria(property.getValue()) is propagating an ExpressionValue. The call
to parsePossibleExpression(value) happens to be a noop that does not affect the outcome.
This is not the case for the LOOPBACK_ADDRESS test I had done.
ParsedInterfaceCriteria.parseCriteria is not maintaining
ExpressionValues
-------------------------------------------------------------------------
Key: AS7-3758
URL: https://issues.jboss.org/browse/AS7-3758
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.0.CR1b
Reporter: Scott Stark
Assignee: Scott Stark
Labels: network
Original Estimate: 1 hour
Remaining Estimate: 1 hour
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:16 a.m.
[
https://issues.jboss.org/browse/AS7-3758?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-3758:
---------------------------------------
OK, I understand now. For <inet-address> it works because the xml parser itself
(CommonXml.java) is creating the node as type EXPRESSION, but for <loopback-address>
it isn't. I'll fix that as well when I merge your patch, Scott.
ParsedInterfaceCriteria.parseCriteria is not maintaining
ExpressionValues
-------------------------------------------------------------------------
Key: AS7-3758
URL: https://issues.jboss.org/browse/AS7-3758
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.0.CR1b
Reporter: Scott Stark
Assignee: Scott Stark
Labels: network
Original Estimate: 1 hour
Remaining Estimate: 1 hour
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:18 a.m.
[
https://issues.jboss.org/browse/AS7-3758?page=com.atlassian.jira.plugin.s...
]
Scott Stark commented on AS7-3758:
----------------------------------
Right, the source of the difference is in parseSimpleInterfaceCriterion where the
INET_ADDRESS case is calling out to parsePossibleExpression while the LOOPBACK_ADDRESS
case is not.
protected void parseSimpleInterfaceCriterion(final XMLExtendedStreamReader reader,
final ModelNode subModel, boolean nested)
throws XMLStreamException {
final Element element = Element.forName(reader.getLocalName());
final String localName = element.getLocalName();
switch (element) {
case INET_ADDRESS: {
requireSingleAttribute(reader, Attribute.VALUE.getLocalName());
final String value = reader.getAttributeValue(0);
ModelNode valueNode = parsePossibleExpression(value);
requireNoContent(reader);
// todo: validate IP address
if(nested) {
subModel.get(localName).add(valueNode);
} else {
subModel.get(localName).set(valueNode);
}
break;
}
case LOOPBACK_ADDRESS: {
requireSingleAttribute(reader, Attribute.VALUE.getLocalName());
final String value = reader.getAttributeValue(0);
requireNoContent(reader);
// todo: validate IP address
subModel.get(localName).set(value);
break;
}
ParsedInterfaceCriteria.parseCriteria is not maintaining
ExpressionValues
-------------------------------------------------------------------------
Key: AS7-3758
URL: https://issues.jboss.org/browse/AS7-3758
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.0.CR1b
Reporter: Scott Stark
Assignee: Scott Stark
Labels: network
Original Estimate: 1 hour
Remaining Estimate: 1 hour
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:20 a.m.
[
https://issues.jboss.org/browse/AS7-3758?page=com.atlassian.jira.plugin.s...
]
Scott Stark edited comment on AS7-3758 at 2/15/12 11:19 AM:
------------------------------------------------------------
Right, the source of the difference is in parseSimpleInterfaceCriterion where the
INET_ADDRESS case is calling out to parsePossibleExpression while the LOOPBACK_ADDRESS
case is not.
{code:title=parseSimpleInterfaceCriterion}
protected void parseSimpleInterfaceCriterion(final XMLExtendedStreamReader reader,
final ModelNode subModel, boolean nested)
throws XMLStreamException {
final Element element = Element.forName(reader.getLocalName());
final String localName = element.getLocalName();
switch (element) {
case INET_ADDRESS: {
requireSingleAttribute(reader, Attribute.VALUE.getLocalName());
final String value = reader.getAttributeValue(0);
ModelNode valueNode = parsePossibleExpression(value);
requireNoContent(reader);
// todo: validate IP address
if(nested) {
subModel.get(localName).add(valueNode);
} else {
subModel.get(localName).set(valueNode);
}
break;
}
case LOOPBACK_ADDRESS: {
requireSingleAttribute(reader, Attribute.VALUE.getLocalName());
final String value = reader.getAttributeValue(0);
requireNoContent(reader);
// todo: validate IP address
subModel.get(localName).set(value);
break;
}
{code}
was (Author: starksm64):
Right, the source of the difference is in parseSimpleInterfaceCriterion where the
INET_ADDRESS case is calling out to parsePossibleExpression while the LOOPBACK_ADDRESS
case is not.
protected void parseSimpleInterfaceCriterion(final XMLExtendedStreamReader reader,
final ModelNode subModel, boolean nested)
throws XMLStreamException {
final Element element = Element.forName(reader.getLocalName());
final String localName = element.getLocalName();
switch (element) {
case INET_ADDRESS: {
requireSingleAttribute(reader, Attribute.VALUE.getLocalName());
final String value = reader.getAttributeValue(0);
ModelNode valueNode = parsePossibleExpression(value);
requireNoContent(reader);
// todo: validate IP address
if(nested) {
subModel.get(localName).add(valueNode);
} else {
subModel.get(localName).set(valueNode);
}
break;
}
case LOOPBACK_ADDRESS: {
requireSingleAttribute(reader, Attribute.VALUE.getLocalName());
final String value = reader.getAttributeValue(0);
requireNoContent(reader);
// todo: validate IP address
subModel.get(localName).set(value);
break;
}
ParsedInterfaceCriteria.parseCriteria is not maintaining
ExpressionValues
-------------------------------------------------------------------------
Key: AS7-3758
URL: https://issues.jboss.org/browse/AS7-3758
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.0.CR1b
Reporter: Scott Stark
Assignee: Scott Stark
Labels: network
Original Estimate: 1 hour
Remaining Estimate: 1 hour
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:24 a.m.
[
https://issues.jboss.org/browse/AS7-3758?page=com.atlassian.jira.plugin.s...
]
Scott Stark updated AS7-3758:
-----------------------------
Description:
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
{code:title=parseCriteria snippet}
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
{code}
was:
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
ParsedInterfaceCriteria.parseCriteria is not maintaining
ExpressionValues
-------------------------------------------------------------------------
Key: AS7-3758
URL: https://issues.jboss.org/browse/AS7-3758
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.0.CR1b
Reporter: Scott Stark
Assignee: Scott Stark
Labels: network
Original Estimate: 1 hour
Remaining Estimate: 1 hour
The parsing of interfaces is throwing away ExpressionValues that are created from
parsePossibleExpression since the resulting ExpressionValue is not passed onto the
For example, in this LOOPBACK_ADDRESS block, the input property.getValue() is passed to
the LoopbackAddressInterfaceCriteria ctor rather than the ExpressionValue that is created
by parsePossibleExpression:
{code:title=parseCriteria snippet}
case LOOPBACK_ADDRESS: {
ModelNode value = property.getValue();
value = parsePossibleExpression(value);
checkStringType(value, element.getLocalName(), true);
return new LoopbackAddressInterfaceCriteria(property.getValue());
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5267
days inactive
5267
days old
6 comments
2 participants
participants (2)
-
Brian Stansberry (JIRA) -
Scott Stark (JIRA)