[JBoss JIRA] Created: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
5:08 a.m.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:19 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Olexandr Demura commented on JBRULES-2346:
------------------------------------------
One more exception, this time about unsynchronized access to
EntryPointNode#objectTypeNodes:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at
org.drools.reteoo.ClassObjectTypeConf.getMatchingObjectTypes(ClassObjectTypeConf.java:171)
at
org.drools.reteoo.ClassObjectTypeConf.getObjectTypeNodes(ClassObjectTypeConf.java:163)
at org.drools.reteoo.EntryPointNode.assertObject(EntryPointNode.java:143)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:1046)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:1001)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
`insert` in both cases is called by reflection from mvel-compiled rule.
Several rules make insertion of all noticeable objects on object graph recursively.
Several threads share RuleAgent and RuleBase, but StatefullSession is recreated for each
thread (each request).
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:40 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Vince Adamo commented on JBRULES-2346:
--------------------------------------
I am participating in a development project where we are using Drools Expert 5.0.1 and I
have observed java.util.ConcurrentModificationException's with the same traceback
pattern as presented in this Jira's Description. And I have a use case where the
occurance is quite a bit more frequent than "very rare". I attempted to apply
the workaround provided in this Jira's Description but that did not solve the problem.
After further testing, though, I believe I may have developed a fix, but I would like to
get confirmation on the correctness of this solution from someone who is more familiar
with the code. i will attach the two files I modified, EntryPoint.java and
ObjectTypeConfigurationRegistry.java, and would ask for someone to review these changes.
Note that I measured rule evaluation throughput and execution time using my specific test
case and did not observe any negative performance impact by the synchronization blocks
that were added. Thanks.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:42 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Vince Adamo updated JBRULES-2346:
---------------------------------
Attachment: EntryPointNode.java
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: EntryPointNode.java, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:42 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Vince Adamo updated JBRULES-2346:
---------------------------------
Attachment: ObjectTypeConfigurationRegistry.java
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: EntryPointNode.java, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:40 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Vince Adamo commented on JBRULES-2346:
--------------------------------------
Upon further review and testing, a much more straightforward solution appears to be to use
the java.util.concurrent.ConcurrentHashMap as the type for
ObjectTypeConfigurationRegistry.typeConfMap, ie:
in ObjectTypeConfigurationRegistry.java:
public ObjectTypeConfigurationRegistry(InternalRuleBase ruleBase ) {
super();
this.ruleBase = ruleBase;
this.typeConfMap = new ConcurrentHashMap<Object, ObjectTypeConf>();
}
no other changes should be required.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: EntryPointNode.java, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:02 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Olexandr Demura commented on JBRULES-2346:
------------------------------------------
Vince is right.
Simple UT, which runs two thread for rule execution can find it.
Execution starts with one fact new Class1("class1")
and uses twenty rules like this:
rule "Insert-2"
no-loop true
when
$clazz : Class1(value == "class1")
then
insert(new Class2("class2"))
end
Similar exception with org.drools.reteoo.EntryPointNode#objectTypeNodes was found.
Vince's fix works well in this case too.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: EntryPointNode.java, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:02 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Kateryna Rudenko commented on JBRULES-2346:
-------------------------------------------
There is also ConcurrentModificationException in ClassFieldAccessorCache$CacheEntry. We
cannot reproduce it in UTs, but, most likely, attached fix works. ConcurrentHashMap is
used instead of HashMap.
Stack trace is:
ConcurrentModificationException: concurrent access to HashMap attempted by
Thread[http-0.0.0.0-25207-7,5,jboss]
at java.util.HashMap.onEntry(HashMap.java:214)
at java.util.HashMap.transfer(HashMap.java:686)
at java.util.HashMap.resize(HashMap.java:676)
at java.util.HashMap.addEntry(HashMap.java:1049)
at java.util.HashMap.put(HashMap.java:561)
at
org.drools.base.ClassFieldAccessorCache$CacheEntry.getClassObjectType(ClassFieldAccessorCache.java:351)
at
org.drools.base.ClassFieldAccessorCache.getClassObjectType(ClassFieldAccessorCache.java:195)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:70)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:59)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
at sun.reflect.GeneratedMethodAccessor499.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:618)
at
org.mvel2.optimizers.impl.refl.ReflectiveAccessorOptimizer.getMethod(ReflectiveAccessorOptimizer.java:931)
at
org.mvel2.optimizers.impl.refl.ReflectiveAccessorOptimizer.compileGetChain(ReflectiveAccessorOptimizer.java:316)
at
org.mvel2.optimizers.impl.refl.ReflectiveAccessorOptimizer.optimizeAccessor(ReflectiveAccessorOptimizer.java:138)
at org.mvel2.ast.ASTNode.getReducedValueAccelerated(ASTNode.java:133)
at org.mvel2.MVELRuntime.execute(MVELRuntime.java:85)
at org.mvel2.compiler.CompiledExpression.getValue(CompiledExpression.java:104)
at org.mvel2.MVEL.executeExpression(MVEL.java:978)
at org.drools.base.mvel.MVELConsequence.evaluate(MVELConsequence.java:87)
at org.drools.common.DefaultAgenda.fireActivation(DefaultAgenda.java:934)
at org.drools.common.DefaultAgenda.fireNextItem(DefaultAgenda.java:885)
at org.drools.common.DefaultAgenda.fireAllRules(DefaultAgenda.java:1086)
at
org.drools.common.AbstractWorkingMemory.fireAllRules(AbstractWorkingMemory.java:660)
at
org.drools.common.AbstractWorkingMemory.fireAllRules(AbstractWorkingMemory.java:637)
at com.softcomputer.rbs.RbsSession.execute(RbsSession.java:133)
at
com.softcomputer.softlab.rnv.rbs.RnvRbsService.fireAll_aroundBody4(RnvRbsService.java:170)
at
com.softcomputer.softlab.rnv.rbs.RnvRbsService.fireAll_aroundBody5$advice(RnvRbsService.java:50)
at com.softcomputer.softlab.rnv.rbs.RnvRbsService.fireAll(RnvRbsService.java:1)
at
com.softcomputer.softlab.rnv.rbs.RnvRbsService.processRules_aroundBody0(RnvRbsService.java:87)
at
com.softcomputer.softlab.rnv.rbs.RnvRbsService.processRules_aroundBody1$advice(RnvRbsService.java:50)
at com.softcomputer.softlab.rnv.rbs.RnvRbsService.processRules(RnvRbsService.java:1)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:618)
at org.jboss.aop.joinpoint.MethodInvocation.invokeNext(MethodInvocation.java:112)
at
org.jboss.ejb3.interceptor.InvocationContextImpl.proceed(InvocationContextImpl.java:166)
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: EntryPointNode.java, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Kateryna Rudenko updated JBRULES-2346:
--------------------------------------
Attachment: ClassFieldAccessorCache.java
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: ClassFieldAccessorCache.java, EntryPointNode.java,
ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:35 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Toshiya Kobayashi updated JBRULES-2346:
---------------------------------------
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: ClassFieldAccessorCache.java, EntryPointNode.java,
ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:49 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/jira/browse/JBRULES-2346?page=com.atlassian.jira.p...
]
Toshiya Kobayashi updated JBRULES-2346:
---------------------------------------
Attachment: JBRULES-2346.patch
Patch for 3 classes above.
Just replacing HashMap with ConcurrentHashMap.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/jira/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: ClassFieldAccessorCache.java, EntryPointNode.java,
JBRULES-2346.patch, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:10 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/browse/JBRULES-2346?page=com.atlassian.jira.plugin...
]
Andreas Kohn commented on JBRULES-2346:
---------------------------------------
We're seeing the same exceptions, and will fix them using the ConcurrentHashMaps. The
locking is very obviously broken here.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: ClassFieldAccessorCache.java, EntryPointNode.java,
JBRULES-2346.patch, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:32 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/browse/JBRULES-2346?page=com.atlassian.jira.plugin...
]
Andreas Kohn updated JBRULES-2346:
----------------------------------
Attachment: JBRULES-2346.diff
Using ConcurrentHashMap avoids the CME when iterating, but one still can get interesting
situations if the update of the maps races: two threads may create an object, and then put
it into the map. This could lead to the two threads each assuming that the next call will
return the object they got earlier, but in fact one thread may have won the race, and the
object put in by the first thread is lost.
For this reason I extended the patch from Toshiya Kobayashi a bit to use
ConcurrentMap's #putIfAbsent() if possible.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Mark Proctor
Attachments: ClassFieldAccessorCache.java, EntryPointNode.java,
JBRULES-2346.diff, JBRULES-2346.patch, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:59 a.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/browse/JBRULES-2346?page=com.atlassian.jira.plugin...
]
Edson Tirelli resolved JBRULES-2346.
------------------------------------
Assignee: Edson Tirelli (was: Mark Proctor)
Fix Version/s: 5.1.0.CR1
Resolution: Done
Fixed. Thanks for reporting and providing patches.
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Edson Tirelli
Fix For: 5.1.0.CR1
Attachments: ClassFieldAccessorCache.java, EntryPointNode.java,
JBRULES-2346.diff, JBRULES-2346.patch, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 a.m.
New subject: [JBoss JIRA] Closed: (JBRULES-2346) insert: ConcurrentModificationException on iterate of ObjectTypeConfigurationRegistry#typeConfMap.
[
https://jira.jboss.org/browse/JBRULES-2346?page=com.atlassian.jira.plugin...
]
Edson Tirelli closed JBRULES-2346.
----------------------------------
insert: ConcurrentModificationException on iterate of
ObjectTypeConfigurationRegistry#typeConfMap.
--------------------------------------------------------------------------------------------------
Key: JBRULES-2346
URL: https://jira.jboss.org/browse/JBRULES-2346
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-core
Affects Versions: 5.0.1.FINAL
Reporter: Olexandr Demura
Assignee: Edson Tirelli
Fix For: 5.1.0.CR1
Attachments: ClassFieldAccessorCache.java, EntryPointNode.java,
JBRULES-2346.diff, JBRULES-2346.patch, ObjectTypeConfigurationRegistry.java
Very rare exception occurs in multi-threaded environment, each thread processes series of
rule evaluations with recreation of StatefulSession after each:
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:1091)
at java.util.HashMap$ValueIterator.next(HashMap.java:1122)
at org.drools.reteoo.EntryPointNode.updateSink(EntryPointNode.java:285)
at org.drools.reteoo.ObjectTypeNode.attach(ObjectTypeNode.java:279)
at
org.drools.reteoo.builder.PatternBuilder.attachObjectTypeNode(PatternBuilder.java:234)
at org.drools.reteoo.ClassObjectTypeConf.<init>(ClassObjectTypeConf.java:93)
at
org.drools.common.ObjectTypeConfigurationRegistry.getObjectTypeConf(ObjectTypeConfigurationRegistry.java:58)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:849)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:114)
at org.drools.base.DefaultKnowledgeHelper.insert(DefaultKnowledgeHelper.java:108)
Problem is caused by cyclic dependency.
ObjectTypeConfigurationRegistry#getObjectTypeConf(EntryPoint, Object)
creates ClassObjectTypeConf to put into ObjectTypeConfigurationRegistry#typeConfMap,
creation code relies on EntryPointNode#updateSink(ObjectSink, PropagationContext,
InternalWorkingMemory),
which iterates on ObjectTypeConfigurationRegistry#typeConfMap.
I can't reproduce it on 5.1.0.M1 now, but because of rare reproduction.
Source looks like have this bug yet.
Used workaround for it:
EntryPointNode#updateSink(ObjectSink, PropagationContext, InternalWorkingMemory) iterates
on copy of ObjectTypeConfigurationRegistry#typeConfMap:
for ( ObjectTypeConf objectTypeConf :
wmEntryPoint.getObjectTypeConfigurationRegistry().values() ) {
->
for ( ObjectTypeConf objectTypeConf : new ArrayList<ObjectTypeConf>(
new wmEntryPoint.getObjectTypeConfigurationRegistry().values() )) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5858
days inactive
6074
days old
14 comments
6 participants
participants (6)
-
Andreas Kohn (JIRA) -
Edson Tirelli (JIRA)
-
Kateryna Rudenko (JIRA)
-
Olexandr Demura (JIRA)
-
Toshiya Kobayashi (JIRA)
-
Vince Adamo (JIRA)