[
https://issues.jboss.org/browse/WFLY-9955?page=com.atlassian.jira.plugin....
]
David Lloyd commented on WFLY-9955:
-----------------------------------
{quote}
if the value == 0;
TxControl.setDefaultTimeout(0); // the transaction will be never time out. So it is OK to
set zero here
ContextTransactionManager.setGlobalDefaultTransactionTimeout(0); // this is wrong, so it
has to be converted to the maximum timeout which might be Integer.MAX_VALUE
{quote}
Correct.
{quote}
[~dmlloyd], I do not understand the necessary to introduce a maximum timeout attribute. I
suppose to change the above codes to
{code}
int timeoutValue = resolvedValue.asInt();
TxControl.setDefaultTimeout(timeoutValue);
if (timeoutValue == 0) {
timeoutValue = Integer.MAX_VALUE;
}
ContextTransactionManager.setGlobalDefaultTransactionTimeout(timeoutValue);
{code}
{quote}
My understanding from talking with Tom and [~ochaloup] is that some resources may fail
with a timeout value of {{Integer.MAX_VALUE}} for various reasons, so a lower
"maximum" (such as one year) might be better. The purpose of the _suggestion_
of the maximum timeout attribute would be to make this value configurable (also in the
event where someone programmatically sets a timeout which might be problematic), but this
is just an idea, not a requirement.
Compatibility problem: allow a timeout value of "0" to be
set
-------------------------------------------------------------
Key: WFLY-9955
URL:
https://issues.jboss.org/browse/WFLY-9955
Project: WildFly
Issue Type: Bug
Components: Transactions
Reporter: David Lloyd
Assignee: Amos Feng
Previously we allowed a transaction timeout value of "0" to be set in the
transaction subsystem, meaning "no transaction timeout". After the WF 11
changes, we've stopped allowing that value to be set. This behavior should be
restored, with "0" translating into some "very large" value.
The transaction team has indicated that using {{Integer.MAX_VALUE}} has historically
exhibited problems, so a different, smaller-but-still-large value should be used in this
case.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)