6:46 p.m.
TS: Add module for shared util classes
--------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:46 p.m.
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka updated AS7-2102:
------------------------------
Description:
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
Perhaps also Apache Commons Util should be added as a dependency.
was:To prevent people coding their own impl of what was coded twenty-times in other
packages of TS.
TS: Add module for shared util classes
--------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:16 p.m.
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2102:
-----------------------------------
(02:11:23) ozizka: FYI, there's going to be some space for shared util classes, do you
have some candidates to put there?
(02:12:14) barreiro: well ... there are a few classes that come from security that I
believe that can be shared
(02:13:14) barreiro: there were also a couple of tests that used some mock EJBs, but these
ones were skipped ... but I may need those classes further down the road.
(02:15:20) barreiro: sometimes I ask myself if it's better to have these classes
shared or everyone has their own copy (once by module) ...
(02:15:56) barreiro: or else you never know where those classes are being used.
(02:17:47) ozizka: +1, but, with proper comments and someone watching/coordinating,
perhaps shared could be a benefit
TS: Add module for shared util classes
--------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:19 p.m.
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka edited comment on AS7-2102 at 10/13/11 8:18 PM:
-------------------------------------------------------------
(02:11:23) ozizka: FYI, there's going to be some space for shared util classes, do you
have some candidates to put there?
(02:12:14) barreiro: well ... there are a few classes that come from security that I
believe that can be shared
(02:13:14) barreiro: there were also a couple of tests that used some mock EJBs, but these
ones were skipped ... but I may need those classes further down the road.
(02:15:20) barreiro: sometimes I ask myself if it's better to have these classes
shared or everyone has their own copy (once by module) ...
(02:15:56) barreiro: or else you never know where those classes are being used.
(02:17:47) ozizka: +1, but, with proper comments and someone watching/coordinating,
perhaps shared could be a benefit
(02:21:47) barreiro: IMHO having a coordinator is a step forward. AS6 testsuite, although
not being too bad, is't too good either.
(02:23:27) ozizka: Such coordinator(s) would likely be author of original util class impl
- that one best knows what was the purpose and suggest/perform the right refactoring
was (Author: ozizka):
(02:11:23) ozizka: FYI, there's going to be some space for shared util classes, do
you have some candidates to put there?
(02:12:14) barreiro: well ... there are a few classes that come from security that I
believe that can be shared
(02:13:14) barreiro: there were also a couple of tests that used some mock EJBs, but these
ones were skipped ... but I may need those classes further down the road.
(02:15:20) barreiro: sometimes I ask myself if it's better to have these classes
shared or everyone has their own copy (once by module) ...
(02:15:56) barreiro: or else you never know where those classes are being used.
(02:17:47) ozizka: +1, but, with proper comments and someone watching/coordinating,
perhaps shared could be a benefit
TS: Add module for shared util classes
--------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:32 p.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka updated AS7-2102:
------------------------------
Summary: TS: Add a package (or a module?) for shared util classes (was: TS: Add
module for shared util classes)
Description:
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
was:
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
Perhaps also Apache Commons Util should be added as a dependency.
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:30 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondřej Chaloupka commented on AS7-2102:
---------------------------------------
I would need to get to shared module following smoke package:
org.jboss.as.test.smoke.modular.utils
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:34 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Dominik Pospisil commented on AS7-2102:
---------------------------------------
testsuite/integration/basic - package org.jboss.as.test.integration.management.util
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:34 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Dominik Pospisil commented on AS7-2102:
---------------------------------------
testsuite/integration/basic - class
org.jboss.as.test.integration.management.api.AbstractMgmtTestBase
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:38 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Dominik Pospisil commented on AS7-2102:
---------------------------------------
testsuite/integration/basic - class
org.jboss.as.test.integration.management.cli.AbstractCliTestBase
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:58 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2102:
-----------------------------------
Created a module in testsuite/shared, although it's a module of root pom.
Copied the deps from testsuite/pom.xml. Will probably need some cleanup &
optimization. Stuart will check.
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:19 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2102:
-----------------------------------
Removed:
* <artifactId>stilts-stomp-client</artifactId>
* <artifactId>stilts-stomplet-server-core</artifactId>
* <artifactId>jboss-annotations-api_1.1_spec</artifactId>
* <artifactId>jboss-as-arquillian-container-managed</artifactId>
* <artifactId>junit</artifactId>
I.e. reduced to just
{code}
<dependency>
<groupId>org.jboss.as</groupId>
<artifactId>jboss-as-build</artifactId>
<type>pom</type>
<exclusions>
<exclusion>
<groupId>org.apache.felix</groupId>
<artifactId>org.osgi.foundation</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.jboss.arquillian.junit</groupId>
<artifactId>arquillian-junit-container</artifactId>
<scope>test</scope>
</dependency>
{code}
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:33 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Peter Skopek commented on AS7-2102:
-----------------------------------
testsuite/integration/basic - class org.jboss.as.test.integration.ejb.security.Util
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:10 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondřej Chaloupka commented on AS7-2102:
---------------------------------------
I would need to add one more package from smoke tests to shared package.
It's org.jboss.as.test.smoke.embedded.demos.fakejndi.
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:57 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2102:
-----------------------------------
TBD - will be renamed to org.jboss.as.test.util.jndi.hack
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:12 p.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a package (or a module?) for shared util classes
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2102:
-----------------------------------
Done. BTW, fakejndi.sar's resources are duplicated - in basic and smoke. Could be
moved too.
TS: Add a package (or a module?) for shared util classes
--------------------------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:38 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a module for shared util classes.
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka updated AS7-2102:
------------------------------
Summary: TS: Add a module for shared util classes. (was: TS: Add a package
(or a module?) for shared util classes)
Git Pull Request: https://github.com/jbossas/jboss-as/pull/842 (was:
https://github.com/jbossas/jboss-as/pull/842)
TS: Add a module for shared util classes.
-----------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:37 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a module for shared util classes.
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka commented on AS7-2102:
-----------------------------------
Ondrej's request for FakeJndi was rejected by Brian, see
https://github.com/jbossas/jboss-as/pull/945 .
Peter's request for moving EJB security Util class is in
https://github.com/jbossas/jboss-as/pull/995 .
TS: Add a module for shared util classes.
-----------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:03 a.m.
New subject: [JBoss JIRA] (AS7-2102) TS: Add a module for shared util classes.
[
https://issues.jboss.org/browse/AS7-2102?page=com.atlassian.jira.plugin.s...
]
Ondrej Zizka closed AS7-2102.
-----------------------------
TS: Add a module for shared util classes.
-----------------------------------------
Key: AS7-2102
URL: https://issues.jboss.org/browse/AS7-2102
Project: Application Server 7
Issue Type: Sub-task
Components: Test Suite
Reporter: Ondrej Zizka
Assignee: Ondrej Zizka
To prevent people coding their own impl of what was coded twenty-times in other packages
of TS.
There's already a package: `org.jboss.as.test.integration.common`
It could be a module to keep it's dependencies separated.
Perhaps also Apache Commons Util should be added as a dependency.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5187
days inactive
5335
days old
17 comments
8 participants
participants (8)
-
Dominik Pospisil (Commented) (JIRA) -
Ondrej Zizka (Commented) (JIRA)
-
Ondrej Zizka (Created) (JIRA)
-
Ondrej Zizka (Issue Comment Edited) (JIRA)
-
Ondrej Zizka (JIRA)
-
Ondrej Zizka (Updated) (JIRA)
-
Ondřej Chaloupka (Commented) (JIRA)
-
Peter Skopek (Commented) (JIRA)