4:45 p.m.
COMPRESS corrupts some messages
-------------------------------
Key: JGRP-1000
URL: https://jira.jboss.org/jira/browse/JGRP-1000
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.5
Reporter: Dennis Reed
Assignee: Dennis Reed
COMPRESS.down() stores the compressed message in a temporary buffer the same size as the
original message.
If the compressed size of a message is larger than the original, then part of the message
is lost, with no errors reported.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:28 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1000) COMPRESS corrupts some messages
[
https://jira.jboss.org/jira/browse/JGRP-1000?page=com.atlassian.jira.plug...
]
Dennis Reed commented on JGRP-1000:
-----------------------------------
If I'm reading the RFCs and the compressed data correctly, the size of the compressed
message is:
ZLIB data: - 6 bytes (no DICTID)
Compressed data - worst case is original size plus 5 bytes per 32K block
So the maximum buffer size needed would be something like: length + ( 5 * ( length / 32768
) ) + 11
(the / is integer division)
References:
http://www.isi.edu/in-notes/rfc1950.txt
http://www.isi.edu/in-notes/rfc1951.txt
COMPRESS corrupts some messages
-------------------------------
Key: JGRP-1000
URL: https://jira.jboss.org/jira/browse/JGRP-1000
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.5
Reporter: Dennis Reed
Assignee: Dennis Reed
COMPRESS.down() stores the compressed message in a temporary buffer the same size as the
original message.
If the compressed size of a message is larger than the original, then part of the message
is lost, with no errors reported.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:53 p.m.
New subject: [JBoss JIRA] Updated: (JGRP-1000) COMPRESS corrupts some messages
[
https://jira.jboss.org/jira/browse/JGRP-1000?page=com.atlassian.jira.plug...
]
Bela Ban updated JGRP-1000:
---------------------------
Fix Version/s: 2.4.7
2.6.11
2.8
COMPRESS corrupts some messages
-------------------------------
Key: JGRP-1000
URL: https://jira.jboss.org/jira/browse/JGRP-1000
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.5
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.7, 2.6.11, 2.8
COMPRESS.down() stores the compressed message in a temporary buffer the same size as the
original message.
If the compressed size of a message is larger than the original, then part of the message
is lost, with no errors reported.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:58 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-1000) COMPRESS corrupts some messages
[
https://jira.jboss.org/jira/browse/JGRP-1000?page=com.atlassian.jira.plug...
]
Bela Ban commented on JGRP-1000:
--------------------------------
It sucks that a compressed payload would be *greater* than the uncompressed payload !
Therefore I suggest the following change:
- Allocate a buffer with the length computed as mentioned above
- If the compressed payload is >= the regular payload, we send the regular payload and
don't attach a CompressHeader
- Else we send the compressed payload (with a CompressHeader)
WDYT ?
COMPRESS corrupts some messages
-------------------------------
Key: JGRP-1000
URL: https://jira.jboss.org/jira/browse/JGRP-1000
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.5
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.7, 2.6.11, 2.8
COMPRESS.down() stores the compressed message in a temporary buffer the same size as the
original message.
If the compressed size of a message is larger than the original, then part of the message
is lost, with no errors reported.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-1000) COMPRESS corrupts some messages
[
https://jira.jboss.org/jira/browse/JGRP-1000?page=com.atlassian.jira.plug...
]
Dennis Reed commented on JGRP-1000:
-----------------------------------
That makes sense.
With your fix, the buffer size wouldn't have to change.
deflater.getTotalOut() returns the number of bytes written, so if the buffer was too
small, it's equal to the buffer size.
So it could be implemented with just:
+ if ( compressed_size < length ) {
byte[] new_payload=new byte[compressed_size];
System.arraycopy(compressed_payload, 0, new_payload, 0, compressed_size);
msg.setBuffer(new_payload);
msg.putHeader(name, new CompressHeader(length));
+ }
COMPRESS corrupts some messages
-------------------------------
Key: JGRP-1000
URL: https://jira.jboss.org/jira/browse/JGRP-1000
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.5
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.7, 2.6.11, 2.8
COMPRESS.down() stores the compressed message in a temporary buffer the same size as the
original message.
If the compressed size of a message is larger than the original, then part of the message
is lost, with no errors reported.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:39 p.m.
New subject: [JBoss JIRA] Resolved: (JGRP-1000) COMPRESS corrupts some messages
[
https://jira.jboss.org/jira/browse/JGRP-1000?page=com.atlassian.jira.plug...
]
Dennis Reed resolved JGRP-1000.
-------------------------------
Resolution: Done
Committed to Branch_JGroups_2_4, Branch_JGroups_2_6, and HEAD.
COMPRESS no longer replaces the original message if the compressed version is not
smaller.
COMPRESS corrupts some messages
-------------------------------
Key: JGRP-1000
URL: https://jira.jboss.org/jira/browse/JGRP-1000
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.5
Reporter: Dennis Reed
Assignee: Dennis Reed
Fix For: 2.4.7, 2.6.11, 2.8
COMPRESS.down() stores the compressed message in a temporary buffer the same size as the
original message.
If the compressed size of a message is larger than the original, then part of the message
is lost, with no errors reported.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5412
days inactive
5419
days old
5 comments
2 participants
participants (2)
-
Bela Ban (JIRA) -
Dennis Reed (JIRA)