[ https://issues.jboss.org/browse/AS7-6316?page=com.atlassian.jira.plugin.s... ] Darran Lofthouse updated AS7-6316: ---------------------------------- Summary: Review of AccessController and PrivilegedAction use across AS7 (was: Update all PrivilegedAction and PrivilegedExceptionAction that don't require arguments be singletons and ensure correct use of Void return type where appropriate.) Description: The following needs reviewing across AS7: - - On demand instantiation of PrivilegedActions where singletons would suffice (Consider frequency of calls, gc may be preferable). - Use of AccessController even though there is no SecurityManager set. - Code duplication, in every case I have seen so far the code is the same regardless of if PRIVILEGED or NON_PRIVILEGED - Utility methods with visibility too high. - In depth review of the other methods, i.e. if the first thing a public method does is set the class loader based on a parameter passed in it could be used badly - it may even be a justification for that method to NOT use a PrivilegedAction. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira