[ https://jira.jboss.org/browse/JBAS-8710?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz updated JBAS-8710: -------------------------------------- Description: The bean org.jboss.ha.singleton.PreferredMasterElectionPolicy has an attribute preferredMaster which identified a process in a cluster which should be the master node in a clustered partition. The preferred master attriubute is specified in the form host:port. This format works fine for IPv4 addresses, but breaks down for IPv6 addresses unless the host part is surrounded with square brackets, according to rfc2732. There are two places which above class may break: (i) in setting the preferred master attribute (ii) in comparing ClusterNode instances using PreferredMasterElectionPolicy.find() to check if a given preferred master is in the current cluster. was: org.jboss.test.cluster.defaultcfg.web.test.CleanShutdownTestCase checks the behaviour of HTTP requests to a server which in the process of shutting down. As part of its processing, it uses a method Cookie findCookie(int serverIndex, String name) to find a cookie with a given name on a given server (usually indexed by 0 or 1). Cookies are matched when they have the same domain and name. Cookie domains can be represented as hostnames, or IP address literals. Our version of HttpClient (which I hacked about one year ago) will always use enclosing brackets when presented with an IPv6 address literal. HttpClient 3.0.1 and 3.1 did not support IPv6 address literals at the time. I may have to reinvestigate what the correct standard is, but for the time being, the above test is failing because findCookie does not wrap IPv6 address literals in square brackets before trying to match. As a result, we get assertion failures in the test, even though we have the correct cookies being returned: Error Message null Stacktrace junit.framework.AssertionFailedError: null at org.jboss.test.cluster.defaultcfg.web.test.CleanShutdownTestCase.testShutdown(CleanShutdownTestCase.java:164) at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:23) at junit.extensions.TestSetup.run(TestSetup.java:27) Standard Output After initial request [fec0:0:a16:ffff::d] JSESSIONID /http-sr Eiq93h0lJFU7W6Y7YDNnXw__.cluster-udp-DIST-0 After request initiated prior to shutdown [fec0:0:a16:ffff::d] JSESSIONID /http-sr Eiq93h0lJFU7W6Y7YDNnXw__.cluster-udp-DIST-0 [fec0:0:a16:ffff::d] sleep /http-sr 0 findCookie(0, "0") is trying to match on the pair ("fec0:0:a16:ffff::d", "0") -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8710?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8710: ------------------------------------------- If they do not, i'll reassign back to you. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8710?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8710: ------------------------------------------- For the record, here is what is seen in the server logs: 12:09:08,381 INFO [org.jboss.deployment.MainDeployer] deploy, url=file:/tmp/JBoss-AS-6.0.x-ipv6/testsuite/output/lib/ha-singleton-election.sar 12:09:08,640 ERROR [org.jboss.kernel.plugins.dependency.AbstractKernelController] Error installing to Configured: name=PreferredMasterElectionPolicy_1 state=Instantiated: java.lang.RuntimeException: Error configuring property: preferredMaster for PreferredMasterElectionPolicy_1 at org.jboss.kernel.plugins.dependency.ConfigureAction.dispatchSetProperty(ConfigureAction.java:112) [jboss-kernel.jar:2.2.0.Alpha10] at org.jboss.kernel.plugins.dependency.ConfigureAction.setAttributes(ConfigureAction.java:85) [jboss-kernel.jar:2.2.0.Alpha10] at org.jboss.kernel.plugins.dependency.ConfigureAction.installActionInternal(ConfigureAction.java:44) [jboss-kernel.jar:2.2.0.Alpha10] at org.jboss.kernel.plugins.dependency.InstallsAwareAction.installAction(InstallsAwareAction.java:54) [jboss-kernel.jar:2.2.0.Alpha10] at org.jboss.kernel.plugins.dependency.InstallsAwareAction.installAction(InstallsAwareAction.java:42) [jboss-kernel.jar:2.2.0.Alpha10] at org.jboss.dependency.plugins.action.SimpleControllerContextAction.simpleInstallAction(SimpleControllerContextAction.java:62) [jboss-dependency.jar:2.2.0.Alpha10] [snip] Caused by: java.lang.IllegalArgumentException: Cannot extract host/address from 3ffe:ffff:0100:f101::1:1099 at org.jboss.ha.singleton.PreferredMasterElectionPolicy.setPreferredMaster(PreferredMasterElectionPolicy.java:71) [:6.0.0-SNAPSHOT] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [:1.6.0_22] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [:1.6.0_22] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [:1.6.0_22] at java.lang.reflect.Method.invoke(Method.java:597) [:1.6.0_22] -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8710?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz updated JBAS-8710: -------------------------------------- Affects: [Documentation (Ref Guide, User Guide, etc.)] The docs should probably be updated to not that if using IPv6 address literals for specifying a preferredMaster host:port combination, then rfc2732 should be followed. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8710?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8710: ------------------------------------------- NOTE: DRMTestCase was not failing due to this issue. It has now been corrected. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8710?page=com.atlassian.jira.plugin.sy... ] Richard Achmatowicz commented on JBAS-8710: ------------------------------------------- Not that I know of. For AS 6, all of the IPv6 related issues are being collected by JBAS-8446. Shelly? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira