annotations not found for non-generic implementations of generic interface methods ---------------------------------------------------------------------------------- Key: JBAOP-305 URL: http://jira.jboss.com/jira/browse/JBAOP-305 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Reporter: Havoc Pennington Attachments: GenericsBaseClass.java, GenericsSubClass.java, GenericsSubInterface.java, GenericsSuperInterface.java, SomethingOrOther.java I'm not sure if this is an AOP problem or a how-jboss-is-using-AOP-on-EJB3-session-beans problem, but I'll file it here to start. The original issue is TransactionAttribute(NEVER) being ignored on certain session bean methods, the test case / details on that are in this list post: http://groups.google.com/group/mugshot/browse_thread/thread/bc43e0dd34c8c... I made an AOP test case that either shows an AOP problem or shows a way jboss could easily misuse AOP. In the AOP test case, If there is an interface Foo<T> with method frobate(T t), then you look that up in AOP as resolveAnnotation("frobate", new Class[] { Object.class }) But if you implement that interface ("class FooImpl implements Foo<Double>") then you have to look that up in AOP as resolveAnnotation("frobate", new Class[] { Double.class }) - looking it up with the erasure (Object.class arg) will not work, it returns null for the annotation. So if someone were iterating over methods in the interface, looking each one up on the implementing class, they would not get the annotation for any generic methods in the interface implemented in the class. The case that's going wrong in EJB3 is a little bit more complicated, so maybe there is some attempt at handling this that isn't catching all the cases. It looks like further investigation requires messing with jboss TxInterceptor etc. itself, which is a little bit more than I think I can bite off, but hopefully this info is a helpful start. Thanks

annotations not found for non-generic implementations of generic interface methods ---------------------------------------------------------------------------------- Key: JBAOP-305 URL: http://jira.jboss.com/jira/browse/JBAOP-305 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Reporter: Havoc Pennington Attachments: aop-test.patch, GenericsBaseClass.java, GenericsSubClass.java, GenericsSubInterface.java, GenericsSuperInterface.java, SomethingOrOther.java I'm not sure if this is an AOP problem or a how-jboss-is-using-AOP-on-EJB3-session-beans problem, but I'll file it here to start. The original issue is TransactionAttribute(NEVER) being ignored on certain session bean methods, the test case / details on that are in this list post: http://groups.google.com/group/mugshot/browse_thread/thread/bc43e0dd34c8c... I made an AOP test case that either shows an AOP problem or shows a way jboss could easily misuse AOP. In the AOP test case, If there is an interface Foo<T> with method frobate(T t), then you look that up in AOP as resolveAnnotation("frobate", new Class[] { Object.class }) But if you implement that interface ("class FooImpl implements Foo<Double>") then you have to look that up in AOP as resolveAnnotation("frobate", new Class[] { Double.class }) - looking it up with the erasure (Object.class arg) will not work, it returns null for the annotation. So if someone were iterating over methods in the interface, looking each one up on the implementing class, they would not get the annotation for any generic methods in the interface implemented in the class. The case that's going wrong in EJB3 is a little bit more complicated, so maybe there is some attempt at handling this that isn't catching all the cases. It looks like further investigation requires messing with jboss TxInterceptor etc. itself, which is a little bit more than I think I can bite off, but hopefully this info is a helpful start. Thanks

annotations not found for non-generic implementations of generic interface methods ---------------------------------------------------------------------------------- Key: JBAOP-305 URL: http://jira.jboss.com/jira/browse/JBAOP-305 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 1.5.3.GA Reporter: Havoc Pennington Assigned To: Kabir Khan Fix For: 2.0.0.alpha3 Attachments: aop-test.patch, GenericsBaseClass.java, GenericsSubClass.java, GenericsSubInterface.java, GenericsSuperInterface.java, SomethingOrOther.java I'm not sure if this is an AOP problem or a how-jboss-is-using-AOP-on-EJB3-session-beans problem, but I'll file it here to start. The original issue is TransactionAttribute(NEVER) being ignored on certain session bean methods, the test case / details on that are in this list post: http://groups.google.com/group/mugshot/browse_thread/thread/bc43e0dd34c8c... I made an AOP test case that either shows an AOP problem or shows a way jboss could easily misuse AOP. In the AOP test case, If there is an interface Foo<T> with method frobate(T t), then you look that up in AOP as resolveAnnotation("frobate", new Class[] { Object.class }) But if you implement that interface ("class FooImpl implements Foo<Double>") then you have to look that up in AOP as resolveAnnotation("frobate", new Class[] { Double.class }) - looking it up with the erasure (Object.class arg) will not work, it returns null for the annotation. So if someone were iterating over methods in the interface, looking each one up on the implementing class, they would not get the annotation for any generic methods in the interface implemented in the class. The case that's going wrong in EJB3 is a little bit more complicated, so maybe there is some attempt at handling this that isn't catching all the cases. It looks like further investigation requires messing with jboss TxInterceptor etc. itself, which is a little bit more than I think I can bite off, but hopefully this info is a helpful start. Thanks

annotations not found for non-generic implementations of generic interface methods ---------------------------------------------------------------------------------- Key: JBAOP-305 URL: http://jira.jboss.com/jira/browse/JBAOP-305 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 1.5.3.GA Reporter: Havoc Pennington Assigned To: Kabir Khan Fix For: 2.0.0.alpha4 Attachments: aop-test.patch, GenericsBaseClass.java, GenericsSubClass.java, GenericsSubInterface.java, GenericsSuperInterface.java, SomethingOrOther.java I'm not sure if this is an AOP problem or a how-jboss-is-using-AOP-on-EJB3-session-beans problem, but I'll file it here to start. The original issue is TransactionAttribute(NEVER) being ignored on certain session bean methods, the test case / details on that are in this list post: http://groups.google.com/group/mugshot/browse_thread/thread/bc43e0dd34c8c... I made an AOP test case that either shows an AOP problem or shows a way jboss could easily misuse AOP. In the AOP test case, If there is an interface Foo<T> with method frobate(T t), then you look that up in AOP as resolveAnnotation("frobate", new Class[] { Object.class }) But if you implement that interface ("class FooImpl implements Foo<Double>") then you have to look that up in AOP as resolveAnnotation("frobate", new Class[] { Double.class }) - looking it up with the erasure (Object.class arg) will not work, it returns null for the annotation. So if someone were iterating over methods in the interface, looking each one up on the implementing class, they would not get the annotation for any generic methods in the interface implemented in the class. The case that's going wrong in EJB3 is a little bit more complicated, so maybe there is some attempt at handling this that isn't catching all the cases. It looks like further investigation requires messing with jboss TxInterceptor etc. itself, which is a little bit more than I think I can bite off, but hopefully this info is a helpful start. Thanks

annotations not found for non-generic implementations of generic interface methods ---------------------------------------------------------------------------------- Key: JBAOP-305 URL: http://jira.jboss.com/jira/browse/JBAOP-305 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 1.5.3.GA Reporter: Havoc Pennington Assigned To: Kabir Khan Fix For: 2.0.0.alpha6 Attachments: aop-test.patch, GenericsBaseClass.java, GenericsSubClass.java, GenericsSubInterface.java, GenericsSuperInterface.java, SomethingOrOther.java I'm not sure if this is an AOP problem or a how-jboss-is-using-AOP-on-EJB3-session-beans problem, but I'll file it here to start. The original issue is TransactionAttribute(NEVER) being ignored on certain session bean methods, the test case / details on that are in this list post: http://groups.google.com/group/mugshot/browse_thread/thread/bc43e0dd34c8c... I made an AOP test case that either shows an AOP problem or shows a way jboss could easily misuse AOP. In the AOP test case, If there is an interface Foo<T> with method frobate(T t), then you look that up in AOP as resolveAnnotation("frobate", new Class[] { Object.class }) But if you implement that interface ("class FooImpl implements Foo<Double>") then you have to look that up in AOP as resolveAnnotation("frobate", new Class[] { Double.class }) - looking it up with the erasure (Object.class arg) will not work, it returns null for the annotation. So if someone were iterating over methods in the interface, looking each one up on the implementing class, they would not get the annotation for any generic methods in the interface implemented in the class. The case that's going wrong in EJB3 is a little bit more complicated, so maybe there is some attempt at handling this that isn't catching all the cases. It looks like further investigation requires messing with jboss TxInterceptor etc. itself, which is a little bit more than I think I can bite off, but hopefully this info is a helpful start. Thanks

annotations not found for non-generic implementations of generic interface methods ---------------------------------------------------------------------------------- Key: JBAOP-305 URL: http://jira.jboss.com/jira/browse/JBAOP-305 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 1.5.3.GA Reporter: Havoc Pennington Assigned To: Stale Pedersen Fix For: 2.0.0.CR1 Attachments: aop-test.patch, GenericsBaseClass.java, GenericsSubClass.java, GenericsSubInterface.java, GenericsSuperInterface.java, SomethingOrOther.java I'm not sure if this is an AOP problem or a how-jboss-is-using-AOP-on-EJB3-session-beans problem, but I'll file it here to start. The original issue is TransactionAttribute(NEVER) being ignored on certain session bean methods, the test case / details on that are in this list post: http://groups.google.com/group/mugshot/browse_thread/thread/bc43e0dd34c8c... I made an AOP test case that either shows an AOP problem or shows a way jboss could easily misuse AOP. In the AOP test case, If there is an interface Foo<T> with method frobate(T t), then you look that up in AOP as resolveAnnotation("frobate", new Class[] { Object.class }) But if you implement that interface ("class FooImpl implements Foo<Double>") then you have to look that up in AOP as resolveAnnotation("frobate", new Class[] { Double.class }) - looking it up with the erasure (Object.class arg) will not work, it returns null for the annotation. So if someone were iterating over methods in the interface, looking each one up on the implementing class, they would not get the annotation for any generic methods in the interface implemented in the class. The case that's going wrong in EJB3 is a little bit more complicated, so maybe there is some attempt at handling this that isn't catching all the cases. It looks like further investigation requires messing with jboss TxInterceptor etc. itself, which is a little bit more than I think I can bite off, but hopefully this info is a helpful start. Thanks

annotations not found for non-generic implementations of generic interface methods ---------------------------------------------------------------------------------- Key: JBAOP-305 URL: http://jira.jboss.com/jira/browse/JBAOP-305 Project: JBoss AOP Issue Type: Bug Security Level: Public(Everyone can see) Affects Versions: 1.5.3.GA Reporter: Havoc Pennington Assigned To: Stale Pedersen Fix For: 2.0.0.CR1 Attachments: aop-test.patch, GenericsBaseClass.java, GenericsSubClass.java, GenericsSubInterface.java, GenericsSuperInterface.java, SomethingOrOther.java I'm not sure if this is an AOP problem or a how-jboss-is-using-AOP-on-EJB3-session-beans problem, but I'll file it here to start. The original issue is TransactionAttribute(NEVER) being ignored on certain session bean methods, the test case / details on that are in this list post: http://groups.google.com/group/mugshot/browse_thread/thread/bc43e0dd34c8c... I made an AOP test case that either shows an AOP problem or shows a way jboss could easily misuse AOP. In the AOP test case, If there is an interface Foo<T> with method frobate(T t), then you look that up in AOP as resolveAnnotation("frobate", new Class[] { Object.class }) But if you implement that interface ("class FooImpl implements Foo<Double>") then you have to look that up in AOP as resolveAnnotation("frobate", new Class[] { Double.class }) - looking it up with the erasure (Object.class arg) will not work, it returns null for the annotation. So if someone were iterating over methods in the interface, looking each one up on the implementing class, they would not get the annotation for any generic methods in the interface implemented in the class. The case that's going wrong in EJB3 is a little bit more complicated, so maybe there is some attempt at handling this that isn't catching all the cases. It looks like further investigation requires messing with jboss TxInterceptor etc. itself, which is a little bit more than I think I can bite off, but hopefully this info is a helpful start. Thanks