[
https://issues.jboss.org/browse/DROOLS-537?page=com.atlassian.jira.plugin...
]
Petr Široký commented on DROOLS-537:
------------------------------------
I measured the impact of the plugin execution on the overall build time for three of our
repos:
1) drools repo
- "mvn clean test-compile -DskipTests": without plugin=142s, with
plugin=161s; difference: 19s, which is ~13%
- "mvn clean install -DskipTests" : without plugin=185s, with
plugin=205s; difference: 20s, which is ~10%
2) optaplanner repo
- "mvn clean test-compile -DskipTests": without plugin=29s, with plugin=35s;
difference: 6s, which is ~ 21%
- "mvn clean install -DskipTests" : without plugin=45s, with
plugin=51s; difference: 6s, which is ~ 13%
2) kie-wb-common repo
- "mvn clean test-compile -DskipTests": without plugin=125s, with
plugin=175s; difference: 50s, which is ~ 40%
- "mvn clean install -DskipTests" : without plugin=141s, with
plugin=193s; difference: 52s, which is ~ 36%
The impact on build times is certainly there and in some cases it is quite large. Because
of that, I think it would best to
enable the plugin only for "full" builds (e.g. -Dfull). This way we could still
execute the plugin very frequently on Jenkins, but
it would not delay the "standard", non-full builds which most people are using
locally.
Use maven plugins (animal-sniffer?) to ensure that code and
dependencies conform to the supported minimum version
-----------------------------------------------------------------------------------------------------------------
Key: DROOLS-537
URL:
https://issues.jboss.org/browse/DROOLS-537
Project: Drools
Issue Type: Task
Affects Versions: 6.1.0.CR1
Reporter: Marco Rietveld
Assignee: Petr Široký
Every now and then, one of us uses syntax or a class from a higher version of Java than
what we use.
Or otherwise, one of us will use a dependency that's been compiled in Java X+1 while
the build is based on Java X.
Can we prevent discovering these mistakes too late by using the animal-sniffer plugin?
One of the more important points here is that using the animal-sniffer (or another plugin
that can be used for this) must *not* significantly delay or prolong the build!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)