6:54 a.m.
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.12
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends the
next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:56 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban updated JGRP-1251:
---------------------------
Fix Version/s: 2.10.2
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.12
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban commented on JGRP-1251:
--------------------------------
To reproduce:
- Take udp.xml and add <DISCARD use_uid="true"/> on top of UDP
- Run 2 Draw instances with -props /yourlocation/udp.xml -state
- Draw something in both instances
- Start a partition by clicking on "Start discarding messages" in 1 instance
- Once the cluster has fallen apart, clear both instances and draw something again
- The make the partition disappear by clicking on "Stop discarding messages"
- The 2 members will merge, but drawing in 1 of them causes that member not to receive any
updates
"probe.sh op=NAKACK.printDigestHistory" will show that the unresponsive member
asks itself for retransmission and it doesn't deliver its own messages
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.12
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:09 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban updated JGRP-1251:
---------------------------
Fix Version/s: 2.11.1
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:29 a.m.
New subject: [JBoss JIRA] Resolved: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban resolved JGRP-1251.
----------------------------
Resolution: Done
Fixed according to SOLUTION
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:17 a.m.
New subject: [JBoss JIRA] Reopened: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban reopened JGRP-1251:
----------------------------
There is a similar bug that occurs when we *don't* send any messages after a merge
& getState().
See the comment for details
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:17 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban updated JGRP-1251:
---------------------------
Attachment: GroupCommunication.java
ViewHandler.java
tmp.xml
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:22 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban commented on JGRP-1251:
--------------------------------
To reproduce:
- Run "java org.jgroups.tests.GroupCommunication A"
- Start a 2nd instance: B
- Click on "Start discarding" in both dialogs
- When the cluster has fallen into 2 singleton clusters, click on "Stop
discarding" in both dialogs
- The merge will happen, but the state transfer screws up the seqnos (probably related to
incorrect digests)
Error:
2327 [WARN] NAKACK: (requester=B, local_addr=A) message A::4 not found in retransmission
table of A:
[0 : 3 (3)]
2926 [WARN] NAKACK: (requester=B, local_addr=A) message A::4 not found in retransmission
table of A:
[0 : 3 (3)]
Note that, when we send another message (by typing something into the shell of A), the
retransmission message disappears, because the message #4 is now available.
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban updated JGRP-1251:
---------------------------
Attachment: GroupCommunication.java
ViewHandler.java
tmp.xml
Latest changes
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java,
ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban updated JGRP-1251:
---------------------------
Attachment: (was: GroupCommunication.java)
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java,
ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban updated JGRP-1251:
---------------------------
Attachment: (was: tmp.xml)
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java,
ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:36 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban updated JGRP-1251:
---------------------------
Attachment: (was: ViewHandler.java)
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:32 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban commented on JGRP-1251:
--------------------------------
The issue is caused by B installing an outdated digest sent from A (as part of the state
transfer) and trashing the NakReceiverWindow and creating a new one. Creating a new NRW
means that all existing messages sent by B (but not yet received by A) are lost and cannot
be retransmitted (that's why the error message is seen).
Example:
- B has digest B: 0 5 (5) // lowest stable seqno=0, highest delivered=5, highest
received=5
- B fetches the state from A
- A returns the state plus the digest B: 0 3 (3)
- This means messages B4 and B5 have not yet been seen by A, and are therefore *not yet*
part of the state. In other words, B4-5 have to be delivered *again* by B, even though B
already delivered them !!
- WHY ?
- B delivered B4-5, which caused some state changes
- Then B received and set the state, replacing the existing state
- B's new state (fetched from A) does *not* have messages B4-5 in it, so they need to
be received again by A and B, to come up with the same state !
SOLUTION:
- We *cannot* set B's seqno to 3, as this would have B send *new* (and *different* !)
messages 4 and 5 again !
- We therefore leave B's seqno
- We need to set highest_delivered in B's NRW to 3 though !!
- This causes B to re-deliver messages 4 and 5
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:01 a.m.
New subject: [JBoss JIRA] Resolved: (JGRP-1251) NAKACK: overwriteDigest() doesn't adjust sequence number
[
https://jira.jboss.org/browse/JGRP-1251?page=com.atlassian.jira.plugin.sy...
]
Bela Ban resolved JGRP-1251.
----------------------------
Resolution: Done
Fixed on 2.12, 2.11 and 2.10
NAKACK: overwriteDigest() doesn't adjust sequence number
--------------------------------------------------------
Key: JGRP-1251
URL: https://jira.jboss.org/browse/JGRP-1251
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.10.2, 2.11.1, 2.12
Attachments: GroupCommunication.java, tmp.xml, ViewHandler.java
NAKACK.overwriteDigest() is used by the 2 state transfer protocols (STATE_TRANSFER and
STREAMING_STATE_TRANSFER).
When A has a digest A:250,B:10,C:160, and gets the state (as a result of calling
JChannel.getState() with a digest of A:230,B:10,C:160, it'll set its own digest to
A:230 (from A:250).
However, A's sequence number (seqno) will remain at 250 ! This means, when A sends
the next message, it'll send A:251, but because we set the digest to A:230, A will ask
itself to retransmit messages A:230-250 !
SOLUTION: when receiving digest A:230, A should set its seqno to 230
WORKAROUND: use FLUSH, which doesn't ship digests on state transfer
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5747
days inactive
5754
days old
13 comments
1 participants
participants (1)
-
Bela Ban (JIRA)