]
Eduardo Martins updated WFLY-13467:
-----------------------------------
Git Pull Request:
Issues in readme for microprofile-opentracing QS
------------------------------------------------
Key: WFLY-13467
URL:
https://issues.redhat.com/browse/WFLY-13467
Project: WildFly
Issue Type: Bug
Components: Quickstarts
Affects Versions: 19.1.0.Final
Reporter: Martin Stefanko
Assignee: Martin Stefanko
Priority: Critical
Fix For: 20.0.0.Beta1
(1) The order of the steps at the beginning is confusing:
1. Solution section says to start EAP and deploy the QS
2. Start the JBoss EAP XP Standalone Server section says start EAP
(2) Consider adding standard sections - see other (non-MP - because these were not yet
tested)
* Use of the EAP_HOME and QUICKSTART_HOME Variables
* Run the Quickstart in Red Hat JBoss Developer Studio or Eclipse
(3) Consider adding some instructions (or link to later sections of the readme) to access
the app when deploying the complete example, it is only shown in the step-by-step
sections.
(4) pom.xml changes show WF BOM instead of EAP one:
{code}
<groupId>org.wildfly.bom</groupId>
<artifactId>wildfly-microprofile</artifactId>
<version>${version.server.bom}</version>
where ${version.server.bom} is the version of your JBoss EAP XP, in our case
"1.0".
{code}
Please notice there's no WF BOM of version 1.0.
(5) WildFly used instead of EAP in:
{code}
<!-- Import the CDI API, we use provided scope as the API is included in WildFly
-->
<!-- Import the Jakarta REST API, we use provided scope as the API is included in
WildFly -->
{code}
The same references are used in pom.xml as well.
(6) No spans are created in jaeger console as documented in sections {{Implicit tracing
of REST resources}} and later. In fact, jaeger console does not show the
{{microprofile-opentracing.war}} at all following the instructions in readme. This is due
to missing env vars settings when starting the EAP server.