[ https://issues.jboss.org/browse/DROOLS-2919?page=com.atlassian.jira.plugi... ] Michael Anstis updated DROOLS-2919: ----------------------------------- Description: During review of the PRs adding support to the different grids, both [~jomarko] and [~karreiro] found some re-occurring issues that need addressing. Rather than fix at the point of discovery, i.e. when my colleagues review the PR, I prefer to circle back and fix all together once the queue of pending PRs are merged. Current action items: * (/) https://github.com/kiegroup/kie-wb-common/pull/2055#discussion_r212084447 * (/) https://github.com/kiegroup/kie-wb-common/pull/2041#discussion_r212250221 * (/) https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9... and https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9... - check for other occurrences too. If we pass a parameter as to whether to update "Stunner" title or not we can remove these methods accessing the super implementation. * (/) Review whether _legacy_ {{BaseExpressionGrid.HeaderTextAreaFactory}} related methods are required when all grids support "in place" editing of name and data-type. Removing if possible. was: During review of the PRs adding support to the different grids, both [~jomarko] and [~karreiro] found some re-occurring issues that need addressing. Rather than fix at the point of discovery, i.e. when my colleagues review the PR, I prefer to circle back and fix all together once the queue of pending PRs are merged. Current action items: * (/) https://github.com/kiegroup/kie-wb-common/pull/2055#discussion_r212084447 * (x) https://github.com/kiegroup/kie-wb-common/pull/2041#discussion_r212250221 * (/) https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9... and https://github.com/kiegroup/kie-wb-common/pull/2075/files#diff-5192d74da9... - check for other occurrences too. If we pass a parameter as to whether to update "Stunner" title or not we can remove these methods accessing the super implementation. * (x) Review whether _legacy_ {{BaseExpressionGrid.HeaderTextAreaFactory}} related methods are required when all grids support "in place" editing of name and data-type. Removing if possible. -- This message was sent by Atlassian JIRA (v7.5.0#75005)