11:40 a.m.
Sanne Grinovero created AS7-4713:
------------------------------------
Summary: Move hibernate-commons-annotations into a dedicated module
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.0.2.SP1
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:50 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow updated AS7-4713:
------------------------------
Summary: Move hibernate-commons-annotations into a separate module that
hibernate search can also use (was: Move hibernate-commons-annotations into a dedicated
module)
Fix Version/s: 7.1.2.Final (EAP)
(was: 7.0.2.SP1)
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:03 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Randall Hauch commented on AS7-4713:
------------------------------------
One concern I have with this is that it changes the class loader used to load the
{{org.hibernate.annotations.common.util.ReflectHelper}} class, which has two forms of the
{{classForName(...)}} method:
* {{classForName(String,Class)}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
specified class.
* {{classForName(String))}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
**__the ReflectHelper class__**.
The behavior of invocations of the first form shouldn't change, since the caller is
supplying the class loader. However, invocations of the second form will experience
different behavior. With this change, the ReflectClass will not be in the same class
loader as Hibernate Core.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:03 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Randall Hauch edited comment on AS7-4713 at 5/4/12 4:02 PM:
------------------------------------------------------------
One concern I have with this is that it changes the class loader used to load the
{{org.hibernate.annotations.common.util.ReflectHelper}} class, which has two forms of the
{{classForName(...)}} method:
* {{classForName(String,Class)}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
specified class.
* {{classForName(String))}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
*_the ReflectHelper class_*.
The behavior of invocations of the first form shouldn't change, since the caller is
supplying the class loader. However, invocations of the second form will experience
different behavior. With this change, the ReflectClass will not be in the same class
loader as Hibernate Core.
was (Author: rhauch):
One concern I have with this is that it changes the class loader used to load the
{{org.hibernate.annotations.common.util.ReflectHelper}} class, which has two forms of the
{{classForName(...)}} method:
* {{classForName(String,Class)}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
specified class.
* {{classForName(String))}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
**__the ReflectHelper class__**.
The behavior of invocations of the first form shouldn't change, since the caller is
supplying the class loader. However, invocations of the second form will experience
different behavior. With this change, the ReflectClass will not be in the same class
loader as Hibernate Core.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:05 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Randall Hauch edited comment on AS7-4713 at 5/4/12 4:03 PM:
------------------------------------------------------------
One concern I have with this is that it changes the class loader used to load the
{{org.hibernate.annotations.common.util.ReflectHelper}} class, which has two forms of the
{{classForName(...)}} method:
* {{classForName(String,Class)}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
specified class.
* {{classForName(String))}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
*_the ReflectHelper class_*.
The behavior of invocations of the first form shouldn't change, since the caller is
supplying the class loader. However, invocations of the second form will experience
different behavior. With this change, the ReflectClass will no longer be in the same class
loader as Hibernate Core.
Perhaps Hibernate code should be examined for uses of the second form.
was (Author: rhauch):
One concern I have with this is that it changes the class loader used to load the
{{org.hibernate.annotations.common.util.ReflectHelper}} class, which has two forms of the
{{classForName(...)}} method:
* {{classForName(String,Class)}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
specified class.
* {{classForName(String))}} attempts to load the named class using the thread's
current context class loader or, if that fails, with the class loader used to load the
*_the ReflectHelper class_*.
The behavior of invocations of the first form shouldn't change, since the caller is
supplying the class loader. However, invocations of the second form will experience
different behavior. With this change, the ReflectClass will not be in the same class
loader as Hibernate Core.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
Pushed another change to github, previous one still had the jboss-commons-annotations jar
in the org.hibernate module (also fixed file date and some whitespace).
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:45 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
with the additional change, I'm now seeing a CNFE
"org.hibernate.annotations.common.reflection.ReflectionManager from [Module
"org.hibernate.envers:main"(see http://pastie.org/3861049) during application
deployment.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:21 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Sanne Grinovero commented on AS7-4713:
--------------------------------------
As many other Hibernate modules, Envers will need this module.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:23 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
I added an Envers dependency on jboss-commons-annotations and that addressed the CNFE.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:25 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Sanne Grinovero commented on AS7-4713:
--------------------------------------
I guess it's the other way around?
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
Randall,
If you get a chance to build again from the latest on
https://github.com/scottmarlow/jboss-as/tree/AS7-4713_movehibernatecommonjar. Let us know
if you still get a failure while testing.
If you run into any more exceptions, please add a comment with a link to the exception.
Scott
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow edited comment on AS7-4713 at 5/4/12 6:27 PM:
-----------------------------------------------------------
I updated the Envers module to have a dependency on jboss-commons-annotations and that
addressed the CNFE.
was (Author: smarlow):
I added an Envers dependency on jboss-commons-annotations and that addressed the
CNFE.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
Sanne, I updated my comment to be clearer. You are right, that Envers does need the
jboss-commons-annotations module.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
Randall, if your testing against my branch is successful, I'll reopen the pull
request.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:34 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
Randall,
In response to your question.
{quote}
The behavior of invocations of the first form shouldn't change, since the caller is
supplying the class loader. However, invocations of the second form will experience
different behavior. With this change, the ReflectClass will no longer be in the same class
loader as Hibernate Core.
{quote}
[Hibernate EntityManager has a call to ReflectHelper
here|https://github.com/hibernate/hibernate-orm/blob/master/hibernate-ent...].
This code is activated for property *hibernate.ejb.interceptor.session_scoped*, which
specifies the application name of an org.hibernate.Interceptor class. The call to
ReflectClass looks like this:
{code}
sessionInterceptorClass =
ReflectHelper.classForName( (String) localSessionInterceptor, EntityManagerImpl.class
);
{code}
The thread context classloader will handle the application classes and if the classname is
a Hibernate class (e.g. org.hibernate.EmptyInterceptor), the EntityManagerImpl.class
classloader will be able to load that (when it calls Class.forName( name, true,
caller.getClassLoader() ) where caller = EntityManagerImpl.class).
Hibernate Envers also depends on hibernate-commons-annotations but doesn't directly
reference ReflectHelper. I don't see any direct or indirect calls to the
ReflectHelper.classForName(String). I agree that with the AS7-4713 fix applied, that
don't involve an application class, will likely fail to load.
I don't see any calls to ReflectHelper.classForName(String).
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:24 a.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Randall Hauch commented on AS7-4713:
------------------------------------
Thanks, Scott. Your answer to my question makes me feel much better about the change.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:06 a.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
Randall,
Are you able to test against the changes in
https://github.com/scottmarlow/jboss-as/tree/AS7-4713_movehibernatecommon...
Scott
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:54 a.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Randall Hauch commented on AS7-4713:
------------------------------------
I'm still not able to successfully run my module against the nightly AS7 (without the
changes in
[https://github.com/scottmarlow/jboss-as/tree/AS7-4713_movehibernatecommon...]).
Note that I was able to manually alter my local AS 7.1.1.Final installation to have the
same changes, and my module worked fine.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 a.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Randall Hauch commented on AS7-4713:
------------------------------------
I should also add that my module uses Hibernate Search 4.1.0.Final, and due to MODE-1474
(caused by HSEARCH-1116) I cannot configure Hibernate Search such that it uses the
ReflectHelper. IOW, I'm not sure that my subsystem currently is testing anything
useful.
However, once HSEARCH-1116 is resolved and Hibernate Search 4.1.1.Final is released, then
I can change ModeShape to use Hibernate Search 4.1.1.Final and should be able to
configure it such that ReflectHelper is used. That will be later this week, however.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:58 a.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Randall Hauch edited comment on AS7-4713 at 5/7/12 11:58 AM:
-------------------------------------------------------------
I should also add that my module uses Hibernate Search 4.1.0.Final, and due to MODE-1474
(caused by [HSEARCH-1116|https://hibernate.onjira.com/browse/HSEARCH-1116]) I cannot
configure Hibernate Search such that it uses the ReflectHelper. IOW, I'm not sure that
my subsystem currently is testing anything useful.
However, once [HSEARCH-1116|https://hibernate.onjira.com/browse/HSEARCH-1116] is resolved
and Hibernate Search 4.1.1.Final is released, then I can change ModeShape to use
Hibernate Search 4.1.1.Final and should be able to configure it such that ReflectHelper is
used. That will be later this week, however.
was (Author: rhauch):
I should also add that my module uses Hibernate Search 4.1.0.Final, and due to
MODE-1474 (caused by HSEARCH-1116) I cannot configure Hibernate Search such that it uses
the ReflectHelper. IOW, I'm not sure that my subsystem currently is testing anything
useful.
However, once HSEARCH-1116 is resolved and Hibernate Search 4.1.1.Final is released, then
I can change ModeShape to use Hibernate Search 4.1.1.Final and should be able to
configure it such that ReflectHelper is used. That will be later this week, however.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:22 a.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
What we currently know is that the change to address AS7-4713 (move the
hibernate-commons-annotations jar into its own module so it can be shared with Hibernate
search) doesn't seem to break the AS7 testsuite.
What we don't know is whether the
(https://github.com/scottmarlow/jboss-as/tree/AS7-4713_movehibernatecommon...) change
helps ModeShape because of other problems that Randall experiences when trying to use the
latest AS7 nightly build (or my github branch).
Randall will update us when he knows more.
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:03 p.m.
New subject: [JBoss JIRA] (AS7-4713) Move hibernate-commons-annotations into a separate module that hibernate search can also use
[
https://issues.jboss.org/browse/AS7-4713?page=com.atlassian.jira.plugin.s...
]
Scott Marlow commented on AS7-4713:
-----------------------------------
[HSEARCH-1120|https://hibernate.onjira.com/browse/HSEARCH-1120] is for creating a
Hibernate Search module
Move hibernate-commons-annotations into a separate module that
hibernate search can also use
--------------------------------------------------------------------------------------------
Key: AS7-4713
URL: https://issues.jboss.org/browse/AS7-4713
Project: Application Server 7
Issue Type: Task
Components: JPA / Hibernate
Reporter: Sanne Grinovero
Assignee: Scott Marlow
Fix For: 7.1.2.Final (EAP)
This jar file is used by several other projects which don't need Hibernate as a
dependency; if we don't split it we will either have duplicate jars, (and in the case
of Hibernate Search even possible conflicts) or all these modules will need to include
Hibernate, getting then bound to a specific version for a long time (while support times
don't match).
As a welcome side-effect, applications depending on Hibernate won't be able to see
this module, which is a good thing as this is not intended to be a public API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5124
days inactive
5127
days old
21 comments
3 participants
participants (3)
-
Randall Hauch (JIRA) -
Sanne Grinovero (JIRA)
-
Scott Marlow (JIRA)