[JBoss JIRA] (WFLY-11991) Add Hibernate ORM transformer option to transform any method parameter of type org.hibernate.engine.spi.SessionImplementor

Monday, 15 April 2019

     [
https://issues.jboss.org/browse/WFLY-11991?page=com.atlassian.jira.plugin...
]

Scott Marlow updated WFLY-11991:
--------------------------------
    Comment: was deleted

(was: The attached afterchange.zip is from running with:

./standalone.sh -DHibernate51CompatibilityTransformer=true
-DHibernate51CompatibilityTransformer.showTransformedClassFolder=/tmp/outfolder
-DHibernate51TransformSessImplMtds=true

Some of the differences to determine if they are correct in output for
BooleanAbstractStandardBasicType extends org/hibernate/type/AbstractStandardBasicType:
beforechange:
{quote}
private static
internalSessionImplementorUsingMethod(Lorg/hibernate/engine/spi/SessionImplementor;)V
...
INVOKESTATIC
org/jboss/as/test/compat/jpa/hibernate/transformer/BooleanAbstractStandardBasicType.internalSessionImplementorUsingMethod
(Lorg/hibernate/engine/spi/SessionImplementor;)V
...
public
set(Ljava/sql/PreparedStatement;Ljava/lang/Boolean;ILorg/hibernate/engine/spi/SessionImplementor;)V
throws org/hibernate/HibernateException java/sql/SQLException 
{quote}
afterchange:
{quote}
private static
internalSessionImplementorUsingMethod(Lorg/hibernate/engine/spi/SharedSessionContractImplementor;)V
...
INVOKESTATIC
org/jboss/as/test/compat/jpa/hibernate/transformer/BooleanAbstractStandardBasicType.internalSessionImplementorUsingMethod
(Lorg/hibernate/engine/spi/SharedSessionContractImplementor;)V
...
public
set(Ljava/sql/PreparedStatement;Ljava/lang/Boolean;ILorg/hibernate/engine/spi/SharedSessionContractImplementor;)V
throws org/hibernate/HibernateException java/sql/SQLException 
{quote}

In question is whether the set() method should of been transformed.)

...
 Add Hibernate ORM transformer option to transform any method
parameter of type org.hibernate.engine.spi.SessionImplementor

--------------------------------------------------------------------------------------------------------------------------

                 Key: WFLY-11991
                 URL: https://issues.jboss.org/browse/WFLY-11991
             Project: WildFly
          Issue Type: Enhancement
          Components: JPA / Hibernate
            Reporter: Scott Marlow
            Assignee: Scott Marlow
            Priority: Major
         Attachments: afterchange.zip, beforechange.zip

 The idea is to transform any class method parameter of type
org.hibernate.engine.spi.SessionImplementor, in user application, to instead use type
org.hibernate.engine.spi.SharedSessionContractImplementor.
 The test case (change) is for this enhancement is
[https://github.com/simkam/wildfly/compare/hibernate_transformer].  
 The test case change is adding an internalNullSafeGet method that should also be
transformed to use the SharedSessionContractImplementor type but was not, which led to an
application failure with code: 
 {code}
  public Object nullSafeGet(ResultSet rs, String[] names, SessionImplementor session,
Object owner) throws HibernateException, SQLException {
         return internalNullSafeGet(rs, names, session, owner);
     }
     private Object internalNullSafeGet(ResultSet rs, String[] names, SessionImplementor
session, Object owner) throws HibernateException, SQLException {
         internalSessionImplementorUsingMethod(session);
         session.isTransactionInProgress();
         int result = rs.getInt( names[0] );
         if ( rs.wasNull() ) return null;
         return State.values()[result];
     }
 }
 {code} 

--
This message was sent by Atlassian Jira
(v7.12.1#712002)

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006