[JBoss JIRA] Created: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
11:15 a.m.
It is impossible to use html forms in portlets or js to build http request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:29 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2356:
----------------------------------------
Why do you pass twice the same parameter in the form ?
I don't understand the issue.
(And why conforming to the spec is a bug)
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:45 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Bernard de Terwangne commented on JBPORTAL-2356:
------------------------------------------------
Thomas,
Let's put it another way :
<form action="<portlet:actionURL/>">
<input name="q" type="text/>
<input type="submit"/>
</form>
now my trace will allways print "null". You can only get values of parameters
declared in portlet:param tags. This means it is impossible to send any value the end user
has typed to the java code.
I've been digging into the source code to understand how it work and it seems to be
designed to prevent passing parameters from the browser. Liferay for instance only uses
common HTTP parameters. When instanciating the PortletRequest from the HttpServletRequest,
it removes all portal specific parameters so the your java code sees only the ones it
expects.
It is a bug because it is just impossible to use. Note that you can find such construct in
some of the samples that come with the product. The samples of course do not work !!!
Bernard
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:21 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2356:
----------------------------------------
This example:
https://svn.jboss.org/repos/portal/examples/tags/JBoss_Portal_2_7_2/JSPHe...
Will run fine on JBoss Portal 2.7.2 and EAP 4.3.
Now maybe the portlet container sample portal indeed has a bug, but there was no recent
release of this project with the newest code.
Passing parameters straight from the browser to the portlet is an obvious risk of
collision.
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:45 p.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Bernard de Terwangne updated JBPORTAL-2356:
-------------------------------------------
Attachment: ControllerRequestFactory.java
Thomas,
I attach a fix for this bug . You will find a new function at the end of the file and
calls to this function are commented //bdt.
Bernard
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
Attachments: ControllerRequestFactory.java
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:22 a.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Bernard de Terwangne updated JBPORTAL-2356:
-------------------------------------------
Attachment: ControllerRequestFactory.java
Thomas,
The version on yesterday was a bit buggy. I attach a new version that I tested more
seriously.
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
Attachments: ControllerRequestFactory.java, ControllerRequestFactory.java
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:24 a.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Bernard de Terwangne updated JBPORTAL-2356:
-------------------------------------------
Attachment: ControllerRequestFactoryTestCase.java
This is a test case for the new method I added
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
Attachments: ControllerRequestFactory.java, ControllerRequestFactory.java,
ControllerRequestFactoryTestCase.java
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:29 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Bernard de Terwangne commented on JBPORTAL-2356:
------------------------------------------------
Thomas,
I'm getting back to you on this issue. My client just does want a full portal and
prefers a simple portlet container. For now I'm providing JBPC with the attached fix.
I see that the fix is not included in JBPC source code neither on the trunk or in tag
2.0.7. Can I have some hope that it would be included in a future version ?
On the other hand the comment in ControllerRequestFactory.java states that :
/**
* A factory that provides a way to create ControllerRequest. This factory is just a
default implementation and is not
* an authority which means that any client of the controller framework is free to
determine how a controller request is
* created.
*
* @author <a href="mailto:julien@jboss.org">Julien Viet</a>
* @version $Revision: 630 $
*/
This is true only if you assume that my client provided implementation of the factory has
the same fully qualified name. Indeed is instanciated in several places in the source code
(ControllerFilter, PortalServlet, TCKServlet) always this way :
ControllerRequestFactory factory = new
ControllerRequestFactory(context.getPageNavigationalStateSerialization());
So the only method for providing an alternative application as suggested by Julien Viet in
its comment is to replace the class file. No possible configuration of the class name is
provided or so. This is why it would be great to have my fix incorporated in a future
version.
Bernard
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
Attachments: ControllerRequestFactory.java, ControllerRequestFactory.java,
ControllerRequestFactoryTestCase.java
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:50 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-2356) It is impossible to use html forms in portlets or js to build http request
[
https://jira.jboss.org/jira/browse/JBPORTAL-2356?page=com.atlassian.jira....
]
Thomas Heute commented on JBPORTAL-2356:
----------------------------------------
In order to apply your patch I would need you to sign the contributor agreement if
possible:
https://www.jboss.org/contribute/
Thanks !
It is impossible to use html forms in portlets or js to build http
request
--------------------------------------------------------------------------
Key: JBPORTAL-2356
URL: https://jira.jboss.org/jira/browse/JBPORTAL-2356
Project: JBoss Portal
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Portal Portlet
Affects Versions: Portlet-2.0.1
Environment: Linux, Java 5, Tomcat, JBoss Portlet Container 2.0
Reporter: Bernard de Terwangne
Attachments: ControllerRequestFactory.java, ControllerRequestFactory.java,
ControllerRequestFactoryTestCase.java
JBoss Portlet container conforms to the spec so well that it becomes unusable. It is
impossible to query the end-user for a value and pass that value in processAction or
serveResource calls. Let's say you write this in your JSP page :
<form action="<portlet:actionURL><portlet:param name='q'
value='yop'/></portlet:actionURL">
<input name="q" type="text/>
<input type="submit"/>
</form>
and in the Java code
public void processAction(ActionRequest req, ActionResponse res)
throws IOException, PortletException {
System.out.println(req.getParameter("q");
}
The printed value will allways be "yop" (the value placed in the portlet:param
tag. There is no way to retrieve the value actually typed by the end user.
This is due to the fact JBoss Portlet container mangles in Base64 the parameters from
<portlet:param> and disregards parameters appended by the browser's form
implementation. Same thing with <resourceURL>. There is no way to pass user input to
the portlet's Java code.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6257
days inactive
6382
days old
8 comments
2 participants
participants (2)
-
Bernard de Terwangne (JIRA) -
Thomas Heute (JIRA)