4:40 a.m.
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public (Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Mark Little
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:58 a.m.
New subject: [JBoss JIRA] Assigned: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=all ]
Mark Little reassigned JBTM-116:
--------------------------------
Assignee: Kevin Conner (was: Mark Little)
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:46 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=comments#action_12343731 ]
Kevin Conner commented on JBTM-116:
-----------------------------------
-1 has no meaning for the default timeout but the clause should be changed.
The lower level action only understands
0 == no timeout
0 == timeout
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:49 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=comments#action_12343732 ]
Mark Little commented on JBTM-116:
----------------------------------
Which lower level? JBossTS understands -1. It means "transactions never time
out".
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:03 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=comments#action_12343733 ]
Kevin Conner commented on JBTM-116:
-----------------------------------
Okay, just looked at the code again and I missed a step.
Setting the default timeout to 0 means that it defers to the default timeout in the
property file.
So
-1 = don't call the reaper (no timeout)
0 = don't replace the property file value (i.e. use the property default)
0 = timeout
So the code in the mbean should read
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout != 0)
{
TxControl.setDefaultTimeout(timeout);
}
}
Ignore 0 and set the others.
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:15 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=comments#action_12343734 ]
Kevin Conner commented on JBTM-116:
-----------------------------------
BTW The lower level was the transaction reaper code :-)
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=comments#action_12343736 ]
Mark Little commented on JBTM-116:
----------------------------------
Yes, but we don't add transactions to the reaper unless they have a non-zero timeout
;-)
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=comments#action_12343737 ]
Kevin Conner commented on JBTM-116:
-----------------------------------
Ah but we do in at least one case, which is where the misunderstanding came from ;-)
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:48 a.m.
New subject: [JBoss JIRA] Commented: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=comments#action_12343938 ]
Kevin Conner commented on JBTM-116:
-----------------------------------
Fixed in revision 6410
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:48 a.m.
New subject: [JBoss JIRA] Closed: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=all ]
Kevin Conner closed JBTM-116.
-----------------------------
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:48 a.m.
New subject: [JBoss JIRA] Resolved: (JBTM-116) setting of default timeout logic broken in mbean
[ http://jira.jboss.com/jira/browse/JBTM-116?page=all ]
Kevin Conner resolved JBTM-116.
-------------------------------
Resolution: Done
setting of default timeout logic broken in mbean
------------------------------------------------
Key: JBTM-116
URL: http://jira.jboss.com/jira/browse/JBTM-116
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public(Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.1
Reporter: Mark Little
Assigned To: Kevin Conner
Fix For: 4.2.2
The mbean code for setting the default timeout says:
public void setTransactionTimeout(int timeout) throws javax.transaction.SystemException
{
if (timeout > 0)
{
TxControl.setDefaultTimeout(timeout);
}
else
throw new javax.transaction.SystemException("Transaction Timeout <
0");
}
This means that it's not possible for anyone to provide a value of -1, which means:
transactions never timeout. Also, the if clause should say >= 0 if the else clause is
to be accurate.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7210
days inactive
7259
days old
10 comments
2 participants
participants (2)
-
Kevin Conner (JIRA) -
Mark Little (JIRA)