JSFSubsystemTransformers and JBossStandaloneEJBContainerProvider classes comparing ModelNode and String always returns false ---------------------------------------------------------------------------------------------------------------------------- Key: WFLY-1738 URL: https://issues.jboss.org/browse/WFLY-1738 Project: WildFly Issue Type: Bug Components: JSF Affects Versions: 8.0.0.Beta1 Reporter: Cheng Fang Assignee: Jeff Mesnil JSFSubsystemTransformers class has the following block, FindBugs detects the equals method between ModelNode and String: {code} final ModelNode value = operation.get(ModelDescriptionConstants.VALUE); if (SLOT_ATTRIBUTE_NAME.equals(name)) { if (value.isDefined() && value.equals(SLOT_DEFAULT_VALUE)) { return DISCARD.transformOperation(context, address, operation); } else { return new TransformedOperation(operation, new RejectionWithFailurePolicy(MESSAGES.invalidJSFSlotValue(value.asString())), OperationResultTransformer.ORIGINAL_RESULT); } } {code} The same problem in another class JBossStandaloneEJBContainerProvider: {code} final ModelNode result = server.getModelControllerClient().execute(add); if (!result.get(OUTCOME).equals(SUCCESS)) { throw new EJBException(result.asString()); } {code}