[
https://issues.jboss.org/browse/WFLY-9908?page=com.atlassian.jira.plugin....
]
Radoslav Husar commented on WFLY-9908:
--------------------------------------
I wonder why this one specifically got attention to warrant a Jira, since there are dozens
and dozens of unused declarations in the JMS subsystem, just take a look at
org.wildfly.extension.messaging.activemq.CommonAttributes or
org.wildfly.extension.messaging.activemq.SecurityRoleDefinition#getObjectTypeAttributeDefinition
or org.wildfly.extension.messaging.activemq.ServerAdd#PATH_BASE, etc.
Unused PathAddress variable in BroadcastGroupAdd.performRuntime
method
----------------------------------------------------------------------
Key: WFLY-9908
URL:
https://issues.jboss.org/browse/WFLY-9908
Project: WildFly
Issue Type: Bug
Components: Clustering, JMS
Affects Versions: 12.0.0.Beta1
Reporter: Martin Styk
Assignee: Radoslav Husar
Priority: Minor
Variable {{final PathAddress address}} in method {{BroadcastGroupAdd.performRuntime}} is
declared but never used.
{code}
@Override
protected void performRuntime(OperationContext context, ModelNode operation,
ModelNode model) throws OperationFailedException {
...
else {
final PathAddress address = context.getCurrentAddress();
final String name = context.getCurrentAddressValue();
final ServiceTarget target = context.getServiceTarget();
if (model.hasDefined(JGROUPS_CLUSTER.getName())) {
// nothing to do, in that case, the clustering.jgroups subsystem will
have setup the stack
} else
if(model.hasDefined(RemoteTransportDefinition.SOCKET_BINDING.getName())) {
final GroupBindingService bindingService = new GroupBindingService();
target.addService(GroupBindingService.getBroadcastBaseServiceName(serviceName).append(name),
bindingService)
.addDependency(SocketBinding.JBOSS_BINDING_NAME.append(model.get(SOCKET_BINDING).asString()),
SocketBinding.class, bindingService.getBindingRef())
.install();
}
}
}
{code}
https://github.com/wildfly/wildfly/blame/master/messaging-activemq/src/ma...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)