[JBoss JIRA] (LOGMGR-54) org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call flush when queue runs empty
10:33 a.m.
Rico Neubauer created LOGMGR-54:
-----------------------------------
Summary: org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call
flush when queue runs empty
Key: LOGMGR-54
URL: https://issues.jboss.org/browse/LOGMGR-54
Project: JBoss Log Manager
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: core
Affects Versions: 1.3.2.Final, 1.4.0.Beta1
Reporter: Rico Neubauer
Assignee: David Lloyd
When using the org.jboss.logmanager.handlers.AsyncHandler in combination with handlers
that use autoFlush=false it happens that output stalls when queue runs empty.
A workaround is to set autoflush=true, however this introduces a flush always, even if
there are more records in the queue, which render the flush useless.
An optimization is to invoke flush() on the handlers if the AsyncTask's queue ran
empty - since then there is nothing else to do anyhow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 a.m.
[
https://issues.jboss.org/browse/LOGMGR-54?page=com.atlassian.jira.plugin....
]
Rico Neubauer updated LOGMGR-54:
--------------------------------
Attachment: jboss-logmanager_master.patch
proposed patch
org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call
flush when queue runs empty
--------------------------------------------------------------------------------------------
Key: LOGMGR-54
URL: https://issues.jboss.org/browse/LOGMGR-54
Project: JBoss Log Manager
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: core
Affects Versions: 1.3.2.Final, 1.4.0.Beta1
Reporter: Rico Neubauer
Assignee: David Lloyd
Attachments: jboss-logmanager_master.patch
When using the org.jboss.logmanager.handlers.AsyncHandler in combination with handlers
that use autoFlush=false it happens that output stalls when queue runs empty.
A workaround is to set autoflush=true, however this introduces a flush always, even if
there are more records in the queue, which render the flush useless.
An optimization is to invoke flush() on the handlers if the AsyncTask's queue ran
empty - since then there is nothing else to do anyhow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:39 a.m.
[
https://issues.jboss.org/browse/LOGMGR-54?page=com.atlassian.jira.plugin....
]
Rico Neubauer edited comment on LOGMGR-54 at 11/20/12 10:37 AM:
----------------------------------------------------------------
proposed patch
Idea is to poll() the queue and therefore recognize when it is empty and invoke a flush.
Then call take() to wait for the next record
} else {
rec = recordQueue.poll();
if (rec == null) {
// queue ran empty, so let's do a flush on the handlers
// this way ExtHandlers usually do not need autoflush=true
flush();
// wait for next entry in queue
rec = recordQueue.take();
}
}
was (Author: MrEasy):
proposed patch
org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call
flush when queue runs empty
--------------------------------------------------------------------------------------------
Key: LOGMGR-54
URL: https://issues.jboss.org/browse/LOGMGR-54
Project: JBoss Log Manager
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: core
Affects Versions: 1.3.2.Final, 1.4.0.Beta1
Reporter: Rico Neubauer
Assignee: David Lloyd
Attachments: jboss-logmanager_master.patch
When using the org.jboss.logmanager.handlers.AsyncHandler in combination with handlers
that use autoFlush=false it happens that output stalls when queue runs empty.
A workaround is to set autoflush=true, however this introduces a flush always, even if
there are more records in the queue, which render the flush useless.
An optimization is to invoke flush() on the handlers if the AsyncTask's queue ran
empty - since then there is nothing else to do anyhow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:39 a.m.
[
https://issues.jboss.org/browse/LOGMGR-54?page=com.atlassian.jira.plugin....
]
Rico Neubauer edited comment on LOGMGR-54 at 11/20/12 10:39 AM:
----------------------------------------------------------------
proposed patch
Idea is to poll() the queue and therefore recognize when it is empty and invoke a flush.
Then call take() to wait for the next record
{code:java}
} else {
rec = recordQueue.poll();
if (rec == null) {
// queue ran empty, so let's do a flush on the handlers
// this way ExtHandlers usually do not need autoflush=true
flush();
// wait for next entry in queue
rec = recordQueue.take();
}
}
{code}
was (Author: MrEasy):
proposed patch
Idea is to poll() the queue and therefore recognize when it is empty and invoke a flush.
Then call take() to wait for the next record
} else {
rec = recordQueue.poll();
if (rec == null) {
// queue ran empty, so let's do a flush on the handlers
// this way ExtHandlers usually do not need autoflush=true
flush();
// wait for next entry in queue
rec = recordQueue.take();
}
}
org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call
flush when queue runs empty
--------------------------------------------------------------------------------------------
Key: LOGMGR-54
URL: https://issues.jboss.org/browse/LOGMGR-54
Project: JBoss Log Manager
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: core
Affects Versions: 1.3.2.Final, 1.4.0.Beta1
Reporter: Rico Neubauer
Assignee: David Lloyd
Attachments: jboss-logmanager_master.patch
When using the org.jboss.logmanager.handlers.AsyncHandler in combination with handlers
that use autoFlush=false it happens that output stalls when queue runs empty.
A workaround is to set autoflush=true, however this introduces a flush always, even if
there are more records in the queue, which render the flush useless.
An optimization is to invoke flush() on the handlers if the AsyncTask's queue ran
empty - since then there is nothing else to do anyhow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:41 a.m.
[
https://issues.jboss.org/browse/LOGMGR-54?page=com.atlassian.jira.plugin....
]
David Lloyd reassigned LOGMGR-54:
---------------------------------
Assignee: James Perkins (was: David Lloyd)
Definitely a bug. James, can you look into this? Thanks.
org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call
flush when queue runs empty
--------------------------------------------------------------------------------------------
Key: LOGMGR-54
URL: https://issues.jboss.org/browse/LOGMGR-54
Project: JBoss Log Manager
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: core
Affects Versions: 1.3.2.Final, 1.4.0.Beta1
Reporter: Rico Neubauer
Assignee: James Perkins
Attachments: jboss-logmanager_master.patch
When using the org.jboss.logmanager.handlers.AsyncHandler in combination with handlers
that use autoFlush=false it happens that output stalls when queue runs empty.
A workaround is to set autoflush=true, however this introduces a flush always, even if
there are more records in the queue, which render the flush useless.
An optimization is to invoke flush() on the handlers if the AsyncTask's queue ran
empty - since then there is nothing else to do anyhow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:43 a.m.
[
https://issues.jboss.org/browse/LOGMGR-54?page=com.atlassian.jira.plugin....
]
David Lloyd commented on LOGMGR-54:
-----------------------------------
The behavior should probably be configurable though, in the case where we legitimately do
not want to flush children unless our buffer is absolutely full. I think defaulting to
flush on queue-empty is probably reasonable though.
org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call
flush when queue runs empty
--------------------------------------------------------------------------------------------
Key: LOGMGR-54
URL: https://issues.jboss.org/browse/LOGMGR-54
Project: JBoss Log Manager
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: core
Affects Versions: 1.3.2.Final, 1.4.0.Beta1
Reporter: Rico Neubauer
Assignee: James Perkins
Attachments: jboss-logmanager_master.patch
When using the org.jboss.logmanager.handlers.AsyncHandler in combination with handlers
that use autoFlush=false it happens that output stalls when queue runs empty.
A workaround is to set autoflush=true, however this introduces a flush always, even if
there are more records in the queue, which render the flush useless.
An optimization is to invoke flush() on the handlers if the AsyncTask's queue ran
empty - since then there is nothing else to do anyhow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:40 p.m.
[
https://issues.jboss.org/browse/LOGMGR-54?page=com.atlassian.jira.plugin....
]
James Perkins commented on LOGMGR-54:
-------------------------------------
Pull request sent https://github.com/jboss-logging/jboss-logmanager/pull/8 and
https://github.com/jboss-logging/jboss-logmanager/pull/9
Took the approach suggested with the exception is the {{autoFlush}} attribute needs to the
set to {{true}} on the {{AsyncHandler}}.
org.jboss.logmanager.handlers.AsyncHandler.AsyncTask should call
flush when queue runs empty
--------------------------------------------------------------------------------------------
Key: LOGMGR-54
URL: https://issues.jboss.org/browse/LOGMGR-54
Project: JBoss Log Manager
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: core
Affects Versions: 1.3.2.Final, 1.4.0.Beta1
Reporter: Rico Neubauer
Assignee: James Perkins
Attachments: jboss-logmanager_master.patch
When using the org.jboss.logmanager.handlers.AsyncHandler in combination with handlers
that use autoFlush=false it happens that output stalls when queue runs empty.
A workaround is to set autoflush=true, however this introduces a flush always, even if
there are more records in the queue, which render the flush useless.
An optimization is to invoke flush() on the handlers if the AsyncTask's queue ran
empty - since then there is nothing else to do anyhow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4164
days inactive
4173
days old
6 comments
3 participants
participants (3)
-
David Lloyd (JIRA) -
James Perkins (JIRA)
-
Rico Neubauer (JIRA)