[ https://jira.jboss.org/jira/browse/JBRULES-2351?page=com.atlassian.jira.p... ] Hugues Malphettes commented on JBRULES-2351: -------------------------------------------- Thanks for working on this. Here are a couple more changes to support OSGi. I am importing drools-api, drools-core, drools-compiler, drools-bpmn2 into eclipse PDE and change the nature and classpath of those projects to behave as pure OSGi projects: the .classpath does not point to any jars on the filesystem. I define a custom OSGi target platform made of eclipse-PDE and of the bundles located inside jboss-drools/trunk/osgi-bundles/plugins Eclipse identifies a couple more issues for those 4 projects: 1- drools-api 1.1- drools-api/src/main/java/org/drools/util/ServiceRegistryImpl.java a couple of unused imports of osgi related packages. 1.2- org.drools.builder.help.DroolsJaxbHelperProvider and KnowledgeBuilderHelper need to import the package com.sun.tools.xjc BND does not import it and it is best to make it an option import anyways. For some unknown reason, I need to import the com.springsource.com.sun.tools.xjc bundle in my workspace before PDE can find the package com.sun.tools.xjc 2- drools-core 2.1- BND is convinced that drools-core should export the package org.drools.visualize which is not defined in this project. Explicitly prevent this in the pom.xml. 2.2- the project drools-compiler imports the package org.drools.retoo in the class org.drools.reteoo.compiled.ObjecttypeNodeCompiler It is required to export that package. 3- drools-compiler 3.1- Export the package org.drools.lang.descr. It is required by the bpmn2 project where org.drools.bpmn2.xpath.XPathDialect does import that package. Please note that the order in which BND's instructions are provided is important. For example !org.drools.lang.*,org.drools.lang.descr does not do anything This works: org.drools.lang.descr,!org.drools.lang.* -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBRULES-2351?page=com.atlassian.jira.p... ] Hugues Malphettes updated JBRULES-2351: --------------------------------------- Attachment: drools-bpmn2-in-pde-optional-java-compilers.patch Same patch with this extra tweak. In drools-compiler the dependency on janino and eclipse-java-compiler should be optional: only one of them is required. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBRULES-2351?page=com.atlassian.jira.plugin... ] Edson Tirelli updated JBRULES-2351: ----------------------------------- Fix Version/s: 5.1.0.CR1 (was: 5.1.0.M2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBRULES-2351?page=com.atlassian.jira.plugin... ] Mark Proctor commented on JBRULES-2351: --------------------------------------- The mylin Manifest you provide has no exports, is that correct? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBRULES-2351?page=com.atlassian.jira.plugin... ] Mark Proctor updated JBRULES-2351: ---------------------------------- Attachment: EclipseJavaCompilerSetting-CompatibleWith-ECJ.patch @author Hugues Malphettes -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBRULES-2351?page=com.atlassian.jira.plugin... ] Mark Proctor commented on JBRULES-2351: --------------------------------------- For: https://jira.jboss.org/secure/attachment/12335817/osgi-bundle-support-sl4... I applied the patches to the jxls-reader, but not for the miilyn one as I'm now just using the provided jar and project from the attachments in this jira. I checked the provided milyn jar, it has no experts is that correct? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira