7:57 a.m.
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://jira.jboss.org/jira/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Mark Proctor
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you need
more information or help.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:29 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://jira.jboss.org/jira/browse/JBRULES-2409?page=com.atlassian.jira.p...
]
Fabio Mauro commented on JBRULES-2409:
--------------------------------------
You could try to transform 'm.getMessage("msg") into
'm.getMessage(\"msg\") ...Drools double-escape the string but in my test it
works right.
Bye,
Fabio
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://jira.jboss.org/jira/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Mark Proctor
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:13 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Mark Proctor reassigned JBRULES-2409:
-------------------------------------
Assignee: Michael Anstis (was: Mark Proctor)
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.2.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:13 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Mark Proctor updated JBRULES-2409:
----------------------------------
Fix Version/s: 5.2.0.CR1
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.2.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:36 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Geoffrey De Smet updated JBRULES-2409:
--------------------------------------
Fix Version/s: 5.2.0.CR2
(was: 5.2.0.CR1)
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.2.0.CR2
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Geoffrey De Smet updated JBRULES-2409:
--------------------------------------
Fix Version/s: 5.3.0.Beta1
(was: 5.2.0.Final)
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.Beta1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:42 a.m.
New subject: [JBoss JIRA] Updated: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Geoffrey De Smet updated JBRULES-2409:
--------------------------------------
Fix Version/s: 5.3.0.CR1
(was: 5.3.0.Beta1)
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:30 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Michael Anstis commented on JBRULES-2409:
-----------------------------------------
Also consider the implications of this thread:
http://drools.46999.n3.nabble.com/rules-users-no-subject-td3280773.html
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:34 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
kenneth westelinck commented on JBRULES-2409:
---------------------------------------------
Suggested workaround does not seem to work: m.getMessage(\"msg\") in drools is
converted to m.getMessage("msg\") in java, instead of
m.getMessage("msg").
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:40 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Jos Hendriks commented on JBRULES-2409:
---------------------------------------
I suggest to have a "escape quotes" setting in de the decision table. Similiar
to the sequential setting. When true or not present you get the current behaviour and when
false you get the old behaviour.
I would be happy to implement it.
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:58 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Michael Anstis commented on JBRULES-2409:
-----------------------------------------
Hi Jos, any help is always welcome :) As you note, the problem is some people want the
default to be no escaping, whereas others (JBRULES-1811) want the default to be escaping.
A global parameter would be of help, but then if you need to parse a mix of decision
tables you need to keep switching the parameter. Another idea could be to escape quotes
not already escaped and to remove escaping from quotes escaped - so:
$myObject.setField(\"A 12" rule\"); would parse to:
$myObject.setField("A 12\" rule"); - those that *want* escaping are
"business users" not wanting (needing) to understand the technical need to
escape, whereas those that *do not want* escaping understand the technicalities. So
"reverse escaping" would be a technicality understood by developers. Only a
thought.... if Kenneth is happy for the parameter route I'll be happy to support your
pull request. Cheers.
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:47 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
kenneth westelinck commented on JBRULES-2409:
---------------------------------------------
I like the second idea where you expect the developer to deliberately escape the quotes in
the cells.
Although I think it would be more natural for a developer to write:
$myObject.setField("A 12\" rule") in a cell. A business user will never
write this, he will write 'A 12" rule'.
Ideally, the escaping "rule" should be intelligent enough to see the cell
contains actual code, so no escaping is necessary (since the cell is written and
maintained by a developer). But I guess there will always be scenarios slipping through
the holes of the safety net. Could we provide some kind of indication in a cell (or
column) to tell Drools the cell contains actual code, so its safe to expect the developer
properly escaped everything?
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:40 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Jos Hendriks commented on JBRULES-2409:
---------------------------------------
I really like the parser to be intelligent. But I agree that it is very hard (much work)
to make it work properly. Even in case of Michael's idea what should we do in the rare
case a business user writes \"? He would then get " in the drl without expecting
it. I know chances are small but still.
As ar as I'm aware there is curently no mechanism in the decision table to add meta
data to a specific cell (Or is there?). The way I see it is that in most cases you want to
enable/disable quote escaping per sheet. Developers and business users typically do not
edit the same rule sheet. The busines user should not be bothered with stuff that he does
not understand or may not edit.
Given that the sequential parameter is also a sheet based parameter, I therefor think it
is best to use that mechanism.
Kenneth would you be happy with a global (e.g. sheet) parameter?
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
kenneth westelinck commented on JBRULES-2409:
---------------------------------------------
Yes, go ahead. Thanks.
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:28 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Jos Hendriks commented on JBRULES-2409:
---------------------------------------
Here is the pull request: https://github.com/Jospfh/drools/pull/1
Do I need to do anything else?
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:38 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Michael Anstis commented on JBRULES-2409:
-----------------------------------------
Hi Jos, thanks for the fix :) We are however having problems merging your pull request
into droolsjbpm :( The pull request is not appearing in droolsjbpm. Can you please re-try
making the pull request ensuring you have droolsjbpm\drools@master as the target repo?
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:14 a.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Michael Anstis resolved JBRULES-2409.
-------------------------------------
Resolution: Done
Merged Jos Hendrik's pull request https://github.com/droolsjbpm/drools/pull/62 into
master. Thanks Jos!
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:44 a.m.
New subject: [JBoss JIRA] (JBRULES-2409) Quotes should not be escaped when parsing a decision table
[
https://issues.jboss.org/browse/JBRULES-2409?page=com.atlassian.jira.plug...
]
Michael Anstis updated JBRULES-2409:
------------------------------------
Issue Type: Enhancement (was: Bug)
Forum Reference:
http://n3.nabble.com/How-to-call-a-method-from-a-cell-in-Drools-5-decisio...
(was:
http://n3.nabble.com/How-to-call-a-method-from-a-cell-in-Drools-5-decisio...)
Quotes should not be escaped when parsing a decision table
----------------------------------------------------------
Key: JBRULES-2409
URL: https://issues.jboss.org/browse/JBRULES-2409
Project: Drools
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Components: drools-decisiontables
Affects Versions: 5.0.1.FINAL
Environment: jdk 1.6 update 12
windows XP
Reporter: Jos Hendriks
Assignee: Michael Anstis
Labels: decision, drl, escaping, generated, quotes, table
Fix For: 5.3.0.CR1
Since drools 5 quotes that are in an action cell of a decision table are escaped. As we
are using method calls with String parameters in our action cells this results in invalid
drl.
I've reproduced the issue in the example decision table project generated
by the eclipse plugin. After generating a new Drools project with decision
table example I added the following to the Message class:
public String getMessage(String dummy) {
return this.message;
}
In the decision table I change cell E9 from
'm.setMessage("$param");update(m);' to
'm.setMessage($param);update(m);'
and cell E11 from 'Goodbye cruel world' to
'm.getMessage("msg")'.
When I use Drools 5 I get escaped double-quotes which causes an error
in com.sample.DecisionTableTest.readKnowledgeBase:
m.setMessage(m.getMessage(\"msg\"));update(m);
Version 4.0.7 did not escape quotes and correctly generated the drl:
m.setMessage(m.getMessage("msg"));update(m);
I found out that escaping of quoted has been added by request, JBRULES-1811. Please
reconsider the decision and or implementation made to solve that issue. Possibly add a
keyword to the decision table to define the way qoutes are parsed? Like Sequential for
salience....
The forum entry I have made includes the files and full drl. Please contact me if you
need more information or help.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4632
days inactive
5262
days old
17 comments
7 participants
participants (7)
-
Fabio Mauro (JIRA) -
Geoffrey De Smet (JIRA)
-
Jos Hendriks (JIRA)
-
kenneth westelinck (JIRA)
-
Mark Proctor (JIRA)
-
Michael Anstis (JIRA)
-
Michael Anstis (Updated) (JIRA)