[JBoss JIRA] Created: (JBWEB-190) TomcatResolver in RewriteValve can't resolve environment variable previously stored by a RewriteRule directive
12:36 a.m.
TomcatResolver in RewriteValve can't resolve environment variable previously stored by
a RewriteRule directive
--------------------------------------------------------------------------------------------------------------
Key: JBWEB-190
URL: https://jira.jboss.org/browse/JBWEB-190
Project: JBoss Web
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Rewrite Valve
Reporter: Wenwei Liao
Assignee: Remy Maucherat
In the following test case, http://test.foo.net/news/123 will be rewrote into /null.do
instead of /test.do
RewriteCond %{HTTP_HOST} ^(.*).foo.net$ [NC]
RewriteRule .* $0 [E=subdomain:%1]
# news
RewriteRule /news/(\d+) /%{ENV:subdomain}.do [L]
It seems that subdomain=test has been stored into request.attributes but TomcatResolver
doesn't retrive subdomain from request.attributes but via System.getProperty
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:36 a.m.
New subject: [JBoss JIRA] Updated: (JBWEB-190) TomcatResolver in RewriteValve can't resolve environment variable previously stored by a RewriteRule directive
[
https://jira.jboss.org/browse/JBWEB-190?page=com.atlassian.jira.plugin.sy...
]
Wenwei Liao updated JBWEB-190:
------------------------------
Priority: Minor (was: Major)
TomcatResolver in RewriteValve can't resolve environment variable
previously stored by a RewriteRule directive
--------------------------------------------------------------------------------------------------------------
Key: JBWEB-190
URL: https://jira.jboss.org/browse/JBWEB-190
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Rewrite Valve
Reporter: Wenwei Liao
Assignee: Remy Maucherat
Priority: Minor
In the following test case, http://test.foo.net/news/123 will be rewrote into /null.do
instead of /test.do
RewriteCond %{HTTP_HOST} ^(.*).foo.net$ [NC]
RewriteRule .* $0 [E=subdomain:%1]
# news
RewriteRule /news/(\d+) /%{ENV:subdomain}.do [L]
It seems that subdomain=test has been stored into request.attributes but TomcatResolver
doesn't retrive subdomain from request.attributes but via System.getProperty
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:53 a.m.
New subject: [JBoss JIRA] Resolved: (JBWEB-190) TomcatResolver in RewriteValve can't resolve environment variable previously stored by a RewriteRule directive
[
https://jira.jboss.org/browse/JBWEB-190?page=com.atlassian.jira.plugin.sy...
]
Remy Maucherat resolved JBWEB-190.
----------------------------------
Fix Version/s: JBossWeb-3.0.0.Beta8
Resolution: Done
The patch was bad though.
TomcatResolver in RewriteValve can't resolve environment variable
previously stored by a RewriteRule directive
--------------------------------------------------------------------------------------------------------------
Key: JBWEB-190
URL: https://jira.jboss.org/browse/JBWEB-190
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Rewrite Valve
Reporter: Wenwei Liao
Assignee: Remy Maucherat
Priority: Minor
Fix For: JBossWeb-3.0.0.Beta8
In the following test case, http://test.foo.net/news/123 will be rewrote into /null.do
instead of /test.do
RewriteCond %{HTTP_HOST} ^(.*).foo.net$ [NC]
RewriteRule .* $0 [E=subdomain:%1]
# news
RewriteRule /news/(\d+) /%{ENV:subdomain}.do [L]
It seems that subdomain=test has been stored into request.attributes but TomcatResolver
doesn't retrive subdomain from request.attributes but via System.getProperty
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:41 a.m.
New subject: [JBoss JIRA] Commented: (JBWEB-190) TomcatResolver in RewriteValve can't resolve environment variable previously stored by a RewriteRule directive
[
https://jira.jboss.org/browse/JBWEB-190?page=com.atlassian.jira.plugin.sy...
]
Wenwei Liao commented on JBWEB-190:
-----------------------------------
Never see that patch being accepted ...
By the way, this is my first piece of code contributed to the open source world. Although
it's bad, but I think it still means a lot to me, thanks Remy.
TomcatResolver in RewriteValve can't resolve environment variable
previously stored by a RewriteRule directive
--------------------------------------------------------------------------------------------------------------
Key: JBWEB-190
URL: https://jira.jboss.org/browse/JBWEB-190
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Rewrite Valve
Reporter: Wenwei Liao
Assignee: Remy Maucherat
Priority: Minor
Fix For: JBossWeb-3.0.0.Beta8
In the following test case, http://test.foo.net/news/123 will be rewrote into /null.do
instead of /test.do
RewriteCond %{HTTP_HOST} ^(.*).foo.net$ [NC]
RewriteRule .* $0 [E=subdomain:%1]
# news
RewriteRule /news/(\d+) /%{ENV:subdomain}.do [L]
It seems that subdomain=test has been stored into request.attributes but TomcatResolver
doesn't retrive subdomain from request.attributes but via System.getProperty
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:35 a.m.
New subject: [JBoss JIRA] Commented: (JBWEB-190) TomcatResolver in RewriteValve can't resolve environment variable previously stored by a RewriteRule directive
[
https://jira.jboss.org/browse/JBWEB-190?page=com.atlassian.jira.plugin.sy...
]
Remy Maucherat commented on JBWEB-190:
--------------------------------------
Ok, thanks. So the patch was bad because the toString will cause NPEs, and if it passes
that it won't return null.
TomcatResolver in RewriteValve can't resolve environment variable
previously stored by a RewriteRule directive
--------------------------------------------------------------------------------------------------------------
Key: JBWEB-190
URL: https://jira.jboss.org/browse/JBWEB-190
Project: JBoss Web
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Rewrite Valve
Reporter: Wenwei Liao
Assignee: Remy Maucherat
Priority: Minor
Fix For: JBossWeb-3.0.0.Beta8
In the following test case, http://test.foo.net/news/123 will be rewrote into /null.do
instead of /test.do
RewriteCond %{HTTP_HOST} ^(.*).foo.net$ [NC]
RewriteRule .* $0 [E=subdomain:%1]
# news
RewriteRule /news/(\d+) /%{ENV:subdomain}.do [L]
It seems that subdomain=test has been stored into request.attributes but TomcatResolver
doesn't retrive subdomain from request.attributes but via System.getProperty
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4932
days inactive
4933
days old
4 comments
2 participants
participants (2)
-
Remy Maucherat (JIRA) -
Wenwei Liao (JIRA)