[JBoss JIRA] (JBMETA-346) LoadOnStartup annotation of a servlet is ignored if servlet is mentioned in the web.xml even without a load-on-startup element
8:36 a.m.
LoadOnStartup annotation of a servlet is ignored if servlet is mentioned in the web.xml
even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Carlo de Wolf
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Robert Panzer updated JBMETA-346:
---------------------------------
Git Pull Request: https://github.com/jboss/metadata/pull/27
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Carlo de Wolf
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:32 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Carlo de Wolf reassigned JBMETA-346:
------------------------------------
Assignee: Robert Panzer (was: Carlo de Wolf)
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:34 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Remy Maucherat commented on JBMETA-346:
---------------------------------------
The patch to ServletMetaData is bad (calling setLoadOnStartup multiple times will only use
the first one, which is of course not what it should do). Please provide a test case.
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:16 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Robert Panzer commented on JBMETA-346:
--------------------------------------
I will provide a test case that shows the error on monday when I am back to work.
I did not want to change the whole logic because I did not understand it fully yet.
But if there is a problem like this for instance when defining a servlet in multiple
web-fragment.xmls it must have been there before.
One point I really dislike about the special treatment of nulls or illegal content like
defining it as zero is that it changes the way servlets get initialized without giving the
user any hint. I would prefer giving the user a proper error message on which he can
react. In particular after following the discussions on the mailing lists regarding
validation of deployment descriptors where the common opinion was that DDs should not be
validated and the well known tolerant handling should be used.
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:49 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Robert Panzer resolved JBMETA-346.
----------------------------------
Resolution: Done
The issue does not show up any longer with the last commit 8aa869d.
But I really do not like the idea, that it is a must now, to call setLoadOnStartup() as
well as setLoadOnStartupInt() afterwards. Sequence of the calls matters!
Especially when someone enters an illegal value into the deployment descriptor, no error
message is given and the order of the servlet initializations changes unpredictably.
I would prefer not storing the string content of the load-on-startup element at all and
instead stop the deployment when recognizing illegal content. The setter
setLoadOnStartup(String) could stay but it should just try to convert the given string and
set corresponding int member or throw an exception if the content is not numeric.
I don't want to add a test case using this approach, but it works now as expected so
imo the issue can be closed now.
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Robert Panzer closed JBMETA-346.
--------------------------------
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:46 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Carlo de Wolf reopened JBMETA-346:
----------------------------------
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
Fix For: 7.0.0.Beta31
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:46 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Carlo de Wolf closed JBMETA-346.
--------------------------------
Resolution: Done
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
Fix For: 7.0.0.Beta31
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:46 a.m.
[
https://issues.jboss.org/browse/JBMETA-346?page=com.atlassian.jira.plugin...
]
Carlo de Wolf updated JBMETA-346:
---------------------------------
Fix Version/s: 7.0.0.Beta31
Git Pull Request: https://github.com/jboss/metadata/pull/27 (was:
https://github.com/jboss/metadata/pull/27)
LoadOnStartup annotation of a servlet is ignored if servlet is
mentioned in the web.xml even without a load-on-startup element
------------------------------------------------------------------------------------------------------------------------------
Key: JBMETA-346
URL: https://issues.jboss.org/browse/JBMETA-346
Project: JBoss Metadata
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: web
Environment: JBoss 7.1.0.CR1-SNAPSHOT, Win7 64Bit, JDK 1.6.0-29 64Bit
Reporter: Robert Panzer
Assignee: Robert Panzer
Fix For: 7.0.0.Beta31
I have a servlet that defines a loadOnStartup value using an annotation.
Additionally I have a web.xml that mentions this servlet but does not contain a
load-on-startup element and is not metadata-complete.
Then the annotated value is ignored and the loadOnStartup value falls back to a
"default" of 0 (instead of -1 being the predefined default).
I already found the bug and will attach a pull request
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5202
days inactive
5327
days old
9 comments
8 participants
participants (8)
-
Carlo de Wolf (Assigned) (JIRA) -
Carlo de Wolf (JIRA)
-
Remy Maucherat (Commented) (JIRA)
-
Robert Panzer (Closed) (JIRA)
-
Robert Panzer (Commented) (JIRA)
-
Robert Panzer (Created) (JIRA)
-
Robert Panzer (Resolved) (JIRA)
-
Robert Panzer (Updated) (JIRA)