]
Ilia Vassilev resolved ELY-1593.
--------------------------------
Resolution: Rejected
Coverity static analysis, Resource leak on the exceptional path of
setFile in FileAuditEndpoint
-----------------------------------------------------------------------------------------------
Key: ELY-1593
URL:
https://issues.jboss.org/browse/ELY-1593
Project: WildFly Elytron
Issue Type: Bug
Components: Audit
Affects Versions: 1.3.2.Final
Reporter: Ilia Vassilev
Assignee: Ilia Vassilev
Coverity static analysis found possible occurrence of resource leak.
https://scan7.coverity.com/reports.htm#v20225/p11778/fileInstanceId=53592...
When {{fos.getFD()}} will throw exception {{FileOutputStream fos}} won't be closed.
{code:java|title=FileAuditEndpoint.java}
void setFile(final File file) throws IOException {
boolean ok = false;
final FileOutputStream fos = new FileOutputStream(file, true);
try {
final OutputStream bos = new BufferedOutputStream(fos);
try {
this.fileDescriptor = fos.getFD();
this.outputStream = bos;
this.file = file;
ok = true;
} finally {
if (! ok) {
safeClose(bos);
}
}
} finally {
if (! ok) {
safeClose(fos);
}
}
}
{code}